roachtest: remove the FUSE-variants of the disk-stall roachtest #102492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These variants have proved flaky, sometimes hanging during setup or teardown. We have coverage through the cgroups and dmsetup variants. Epic: none Release note: none
|
This change is |
jbowens
added
backport-22.2.x
backport-23.1.x
nicktrav
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
Should we consider ripping out the setup instructions here too? I think we'd also need to rip out pkg/cmd/roachtest/tests/synctest.go too. It's disabled, so maybe that's ok. Can be a follow up.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @itsbilal)
|
TFTR! bors r=nicktrav I'll follow up with giving synctest another look. I wonder if we can replace charybdefs in it with a custom vfs. |
|
Build succeeded: |
This was referenced Apr 28, 2023
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error setting reviewers, but backport branch blathers/backport-release-22.2-102492 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/102648/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. [] Backport to branch 22.2.x failed. See errors above. error setting reviewers, but backport branch blathers/backport-release-23.1-102492 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/102649/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. [] Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
jbowens
added a commit
that referenced
this pull request
May 18, 2023
Backport of #102492. These variants have proved flaky, sometimes hanging during setup or teardown. We have coverage through the cgroups and dmsetup variants. Epic: none Release note: none Release justification: non-production code changes
sumeerbhola
added a commit
to sumeerbhola/cockroach
that referenced
this pull request
Jul 17, 2023
This test has been skipped since May 2020, because Pebble code is written to crash on an error when writing to the MANIFEST and the WAL, since it is not viable to continue. Additionally, there were problems with hangs due to charybdefs returning EAGAIN (which have since been fixed). We are deleting this now since: - The purpose of this test is to test that Pebble does not lose data due to filesystem errors. It does so in a cruder manner than Pebble's strict MemFS based testing (which came later). Given the existence of the latter, there is no good reason to retain this test. - Working around charybdefs flakiness (see cockroachdb#102492), and Pebble's failstop-on-error behavior is not worth the initial and ongoing maintenance effort. Epic: none Fixes: cockroachdb#48603 Release note: None
sumeerbhola
added a commit
to sumeerbhola/cockroach
that referenced
this pull request
Jul 17, 2023
This test has been skipped since May 2020, because Pebble code is written to crash on an error when writing to the MANIFEST and the WAL, since it is not viable to continue. Additionally, there were problems with hangs due to charybdefs returning EAGAIN (which have since been fixed). We are deleting this now since: - The purpose of this test is to test that Pebble does not lose data due to filesystem errors. It does so in a cruder manner than Pebble's strict MemFS based testing (which came later). Given the existence of the latter, there is no good reason to retain this test. - Working around charybdefs flakiness (see cockroachdb#102492), and Pebble's failstop-on-error behavior is not worth the initial and ongoing maintenance effort. Epic: none Fixes: cockroachdb#48603 Release note: None
craig bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
106917: roachtest: delete synctest r=RaduBerinde,itsbilal a=sumeerbhola This test has been skipped since May 2020, because Pebble code is written to crash on an error when writing to the MANIFEST and the WAL, since it is not viable to continue. Additionally, there were problems with hangs due to charybdefs returning EAGAIN (which have since been fixed). We are deleting this now since: - The purpose of this test is to test that Pebble does not lose data due to filesystem errors. It does so in a cruder manner than Pebble's strict MemFS based testing (which came later). Given the existence of the latter, there is no good reason to retain this test. - Working around charybdefs flakiness (see #102492), and Pebble's failstop-on-error behavior is not worth the initial and ongoing maintenance effort. Epic: none Fixes: #48603 Release note: None 106941: build: use pnpm for cluster-ui auto-publishing r=nathanstilwell,rickystewart a=sjbarag The pkg/ui/ tree recently switched to pnpm (from yarn) for package management [1], but the GitHub workflow to automatically publish new versions of pkg/ui/workspaces/cluster-ui wasn't updated to align with that. Use pnpm for dependency management when auto-publishing canary and full-release versions of cluster-ui. Release note: None Epic: None Co-authored-by: sumeerbhola <[email protected]> Co-authored-by: Sean Barag <[email protected]>
renatolabs
added a commit
to renatolabs/cockroach
that referenced
this pull request
Apr 11, 2024
The following install targets are removed in this commit: * `cassandra`: this should have been removed along with cockroachdb#64029. * `charybdefs`: this is also no longer used and should have been removed along with cockroachdb#102492. * `confluent`: only cdc tests would use this, and they implement their own logic to install `confluent`. In the future, we can consider including that logic in roachprod itself as part of `Install`, but that can be done in the future separately. * `tools`: this target doesn't work, which indicates no one has been using it. Epic: none Release note: None
blathers-crl bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
The following install targets are removed in this commit: * `cassandra`: this should have been removed along with #64029. * `charybdefs`: this is also no longer used and should have been removed along with #102492. * `confluent`: only cdc tests would use this, and they implement their own logic to install `confluent`. In the future, we can consider including that logic in roachprod itself as part of `Install`, but that can be done in the future separately. * `tools`: this target doesn't work, which indicates no one has been using it. Epic: none Release note: None
renatolabs
added a commit
to renatolabs/cockroach
that referenced
this pull request
Apr 12, 2024
The following install targets are removed in this commit: * `cassandra`: this should have been removed along with cockroachdb#64029. * `charybdefs`: this is also no longer used and should have been removed along with cockroachdb#102492. * `confluent`: only cdc tests would use this, and they implement their own logic to install `confluent`. In the future, we can consider including that logic in roachprod itself as part of `Install`, but that can be done in the future separately. * `tools`: this target doesn't work, which indicates no one has been using it. Epic: none Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These variants have proved flaky, sometimes hanging during setup or teardown. We have coverage through the cgroups and dmsetup variants.
Epic: none
Release note: none