Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: roachtest: load AWS fixtures from us-east-2 to avoid egress #106075

Merged

Conversation

srosenberg
Copy link
Member

@srosenberg srosenberg commented Jul 3, 2023

Backport 1/1 commits from #105969.

/cc @cockroachdb/release


In [1], new restore tests have been added to load fixtures from s3://cockroach-fixtures. Since the regional bucket is located in us-east-1, and roachprod provisions in us-east-2, egress during nightly and weekly runs amounted to non-trivial cost.

This change replaces the bucket with the regional
s3://cockroach-fixtures-us-east-2, which was replicated from us-east-1. As a precaution, other roachtest which depend on s3://cockroach-fixtures but do not currently run in AWS, are now guarded by a conditional skip. A new issue (#105968) has been created to address
the problem of localizing fixtures under a given
cloud provider.

[1] #94143

Epic: none
Informs: #105968

Release note: None
Release justification: ci/test only change

In [1], new restore tests have been added to load fixtures
from `s3://cockroach-fixtures`. Since the regional bucket
is located in us-east-1, and roachprod provisions in
us-east-2, egress during nightly and weekly runs amounted
to non-trivial cost.

This change replaces the bucket with the regional
`s3://cockroach-fixtures-us-east-2`, which was replicated
from us-east-1. As a precaution, other roachtest which
depend on `s3://cockroach-fixtures` but do not currently
run in AWS, are now guarded by a conditional skip.
A new issue (cockroachdb#105968) has been created to address
the problem of localizing fixtures under a given
cloud provider.

[1] cockroachdb#94143

Epic: none
Informs: cockroachdb#105968

Release note: None
@srosenberg srosenberg requested a review from a team as a code owner July 3, 2023 17:47
@srosenberg srosenberg requested review from smg260 and renatolabs and removed request for a team July 3, 2023 17:47
@blathers-crl
Copy link

blathers-crl bot commented Jul 3, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@srosenberg srosenberg merged commit 9a48060 into cockroachdb:release-22.2 Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants