Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: load AWS fixtures from us-east-2 to avoid egress #105969

Conversation

srosenberg
Copy link
Member

In [1], new restore tests have been added to load fixtures from s3://cockroach-fixtures. Since the regional bucket is located in us-east-1, and roachprod provisions in us-east-2, egress during nightly and weekly runs amounted to non-trivial cost.

This change replaces the bucket with the regional
s3://cockroach-fixtures-us-east-2, which was replicated from us-east-1. As a precaution, other roachtest which depend on s3://cockroach-fixtures but do not currently run in AWS, are now guarded by a conditional skip. A new issue (#105968) has been created to address
the problem of localizing fixtures under a given
cloud provider.

[1] #94143

Epic: none
Informs: #105968

Release note: None

@srosenberg srosenberg requested a review from a team as a code owner July 2, 2023 01:41
@srosenberg srosenberg requested review from smg260, renatolabs and msbutler and removed request for a team July 2, 2023 01:41
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@srosenberg srosenberg requested review from herkolategan and removed request for smg260 July 2, 2023 01:42
@srosenberg srosenberg added backport-23.1.x Flags PRs that need to be backported to 23.1 backport-22.2.x labels Jul 2, 2023
In [1], new restore tests have been added to load fixtures
from `s3://cockroach-fixtures`. Since the regional bucket
is located in us-east-1, and roachprod provisions in
us-east-2, egress during nightly and weekly runs amounted
to non-trivial cost.

This change replaces the bucket with the regional
`s3://cockroach-fixtures-us-east-2`, which was replicated
from us-east-1. As a precaution, other roachtest which
depend on `s3://cockroach-fixtures` but do not currently
run in AWS, are now guarded by a conditional skip.
A new issue (cockroachdb#105968) has been created to address
the problem of localizing fixtures under a given
cloud provider.

[1] cockroachdb#94143

Epic: none
Informs: cockroachdb#105968

Release note: None
@srosenberg srosenberg force-pushed the sr/roachtest_aws_cockroach_fixtures_us_east_2 branch from ecca0c0 to a2ba442 Compare July 2, 2023 02:28
@srosenberg
Copy link
Member Author

TFTR!

bors r=herkolategan

@craig
Copy link
Contributor

craig bot commented Jul 3, 2023

Build succeeded:

@blathers-crl
Copy link

blathers-crl bot commented Jul 3, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from a2ba442 to blathers/backport-release-22.2-105969: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants