Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: release: use in-source version for Red Hat publishing #100820

Merged
merged 1 commit into from
Apr 6, 2023
Merged

release-23.1: release: use in-source version for Red Hat publishing #100820

merged 1 commit into from
Apr 6, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 6, 2023 •
edited by rail
Loading

Backport 1/1 commits from #100784 on behalf of @rail.

/cc @cockroachdb/release

Previously, we passed the version we want to publish via TeamCIty. With version available in pkg/build/version.txt, we can start using it to simplify our automation.

This PR copies the existing publishing script and adjusts the way we read the version.

Epic: none
Release note: None

Release justification: Red Hat specific change

@rail
release: use in-source version for Red Hat publishing
843d021 
Previously, we passed the version we want to publish via TeamCIty. With
version available in `pkg/build/version.txt`, we can start using it to
simplify our automation.

This PR copies the existing publishing script and adjusts the way we
read the version.

Epic: none
Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner April 6, 2023 15:10
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-100784 branch from a988b16 to 0ef5e17 Compare April 6, 2023 15:10
@blathers-crl blathers-crl bot requested review from celiala and jlinder April 6, 2023 15:10
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-100784 branch from c2eab08 to 843d021 Compare April 6, 2023 15:10
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 6, 2023 •
edited by rail
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 6, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rail rail merged commit 47d9abf into release-23.1 Apr 6, 2023
@rail rail deleted the blathers/backport-release-23.1-100784 branch April 6, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlinder jlinder jlinder approved these changes

@celiala celiala Awaiting requested review from celiala

Assignees

@rail rail

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @jlinder @rail