Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: use in-source version for Red Hat publishing #100784

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

rail
Copy link
Member

@rail rail commented Apr 6, 2023

Previously, we passed the version we want to publish via TeamCIty. With version available in pkg/build/version.txt, we can start using it to simplify our automation.

This PR copies the existing publishing script and adjusts the way we read the version.

Epic: none
Release note: None

Previously, we passed the version we want to publish via TeamCIty. With
version available in `pkg/build/version.txt`, we can start using it to
simplify our automation.

This PR copies the existing publishing script and adjusts the way we
read the version.

Epic: none
Release note: None
@rail rail added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-release T-release Release Engineering & Automation Team backport-23.1.x Flags PRs that need to be backported to 23.1 labels Apr 6, 2023
@rail rail requested a review from celiala April 6, 2023 03:15
@rail rail self-assigned this Apr 6, 2023
@rail rail requested a review from a team as a code owner April 6, 2023 03:15
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rail rail requested a review from jlinder April 6, 2023 14:09
@rail
Copy link
Member Author

rail commented Apr 6, 2023

You can see the diff between the old and the new script here https://gist.github.com/rail/8ed9c61ad82470bef5d67a7f8c25abda

Copy link
Collaborator

@jlinder jlinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting! LGTM!

@rail
Copy link
Member Author

rail commented Apr 6, 2023

bors r=jlinder

@craig
Copy link
Contributor

craig bot commented Apr 6, 2023

Build succeeded:

@craig craig bot merged commit 01f3b26 into cockroachdb:master Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-release backport-23.1.x Flags PRs that need to be backported to 23.1 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-release Release Engineering & Automation Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants