Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cockroachdb/errors: support multi-errors for 1.20 #97799

Closed
3 tasks done
ajwerner opened this issue Feb 28, 2023 · 1 comment
Closed
3 tasks done

cockroachdb/errors: support multi-errors for 1.20 #97799

ajwerner opened this issue Feb 28, 2023 · 1 comment
Assignees
@dhartunian
Labels
A-observability-inf branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) db-cy-23 release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.

Comments

@ajwerner
Copy link
Contributor

ajwerner commented Feb 28, 2023 •
edited by dhartunian
Loading

Is your feature request related to a problem? Please describe.
See cockroachdb/errors#99 and #96443.
We must do this before we release a version with go1.20.

Describe alternatives you've considered
We can not upgrade to go 1.20.

Checklist

Jira issue: CRDB-24894

Epic CRDB-29601
@ajwerner ajwerner added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 labels Feb 28, 2023
@ajwerner ajwerner self-assigned this Feb 28, 2023
@ajwerner ajwerner mentioned this issue Feb 28, 2023
Closed
15 tasks
@ajwerner ajwerner removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Mar 8, 2023
@StevenACoffman StevenACoffman mentioned this issue Mar 12, 2023
Closed
@ajwerner ajwerner removed their assignment Mar 27, 2023
@dhartunian dhartunian added release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 and removed branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 labels Aug 14, 2023
@dhartunian dhartunian mentioned this issue Aug 24, 2023
Merged
@dhartunian dhartunian mentioned this issue Aug 24, 2023
Closed
dhartunian added a commit to dhartunian/cockroach that referenced this issue Aug 25, 2023
@dhartunian
deps: update errors dependency to 1.10.1
db016c2 
This errors lib release is a compatibility release that adds multi-
cause error support in preparation for go 1.20.

One test needed to have datadriven output updated due to a bugfix that
improved error printing for certain kinds of wrapped error chains.

Part of cockroachdb#97799
Epic: None

Release note: None
dhartunian added a commit to dhartunian/cockroach that referenced this issue Aug 25, 2023
@dhartunian
deps: update errors dependency to 1.10.1
0b33ba5 
This errors lib release is a compatibility release that adds multi-
cause error support in preparation for go 1.20.

One test needed to have datadriven output updated due to a bugfix that
improved error printing for certain kinds of wrapped error chains.

Part of cockroachdb#97799
Epic: None

Release note: None

Release justification: enables mixed-version compatibility with
errors generated from 23.2 if they use a newer version of this library
compatible with go 1.20
craig bot pushed a commit that referenced this issue Aug 25, 2023
@dhartunian
Merge #109355
be9d15a 
109355: deps: update errors dependency to 1.10.1 r=knz a=dhartunian

This errors lib release is a compatibility release that adds multi-
cause error support in preparation for go 1.20.

One test needed to have datadriven output updated due to a bugfix that
improved error printing for certain kinds of wrapped error chains.

Part of #97799
Epic: None

Release note: None

Co-authored-by: David Hartunian <[email protected]>
@dhartunian
Copy link
Collaborator

cockroachdb/errors v1.11.0 and higher support multi-cause errors and go 1.20 https://github.com/cockroachdb/errors/releases/tag/v1.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhartunian dhartunian

Labels
A-observability-inf branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) db-cy-23 release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dhartunian @ajwerner @healthy-pod