Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/pgwire: TestAuthenticationAndHBARules failed #52026

Closed
cockroach-teamcity opened this issue Jul 28, 2020 · 8 comments · Fixed by #52200
Closed

sql/pgwire: TestAuthenticationAndHBARules failed #52026

cockroach-teamcity opened this issue Jul 28, 2020 · 8 comments · Fixed by #52200
Assignees
@knz
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Milestone
20.2

Comments

@cockroach-teamcity
Copy link
Member

(sql/pgwire).TestAuthenticationAndHBARules failed on master@629ce5ea3f105e4db7a51b388b96e519d271425d:

Fatal error:

panic: logging already active; first use:

Stack:

goroutine 40451 [running]:
runtime/debug.Stack(0x73, 0x43ecb4e, 0x6)
	/usr/local/go/src/runtime/debug/stack.go:24 +0x9d
github.com/cockroachdb/cockroach/pkg/util/log.setActive()
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:424 +0x9a
github.com/cockroachdb/cockroach/pkg/util/log.(*loggerT).outputLogEntry(0xc003da1800, 0x1, 0x1625fe9e84466501, 0x9e03, 0x7019357, 0x14, 0x1f2, 0xc00080cf90, 0x23, 0xc0003bfa40, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:246 +0xc9
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).output(0xc003da1800, 0x4ffeac0, 0xc0019fdb60, 0x1, 0xe00000001, 0x4425b9a, 0x1a, 0xc000d63c28, 0x1, 0x1)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:119 +0x118
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).Logf(...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:124
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).ServeConn.func1(0xc0024df200, 0xc000d63ec8, 0x2a7bb9ea, 0xed6b267ff, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/server.go:498 +0x11d
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).ServeConn(0xc0024df200, 0x4ffeac0, 0xc0019fdb60, 0x50560c0, 0xc002830000, 0xc0005d9401, 0x0, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/server.go:589 +0x6c2
github.com/cockroachdb/cockroach/pkg/server.(*sqlServer).startServeSQL.func1.1(0x50573e0, 0xc000597fa0)
	/go/src/github.com/cockroachdb/cockroach/pkg/server/server.go:1907 +0x166
github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith.func1(0xc0004e3b00, 0x4ffeac0, 0xc0009c08d0, 0xc000386670, 0x50573e0, 0xc000597fa0, 0xc0009c0900)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:147 +0xaf
created by github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:144 +0x25c
 [recovered]
	panic: logging already active; first use:
goroutine 40451 [running]:
runtime/debug.Stack(0x73, 0x43ecb4e, 0x6)
	/usr/local/go/src/runtime/debug/stack.go:24 +0x9d
github.com/cockroachdb/cockroach/pkg/util/log.setActive()
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:424 +0x9a
github.com/cockroachdb/cockroach/pkg/util/log.(*loggerT).outputLogEntry(0xc003da1800, 0x1, 0x1625fe9e84466501, 0x9e03, 0x7019357, 0x14, 0x1f2, 0xc00080cf90, 0x23, 0xc0003bfa40, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:246 +0xc9
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).output(0xc003da1800, 0x4ffeac0, 0xc0019fdb60, 0x1, 0xe00000001, 0x4425b9a, 0x1a, 0xc000d63c28, 0x1, 0x1)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:119 +0x118
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).Logf(...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:124
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).ServeConn.func1(0xc0024df200, 0xc000d63ec8, 0x2a7bb9ea, 0xed6b267ff, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/server.go:498 +0x11d
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).ServeConn(0xc0024df200, 0x4ffeac0, 0xc0019fdb60, 0x50560c0, 0xc002830000, 0xc0005d9401, 0x0, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/server.go:589 +0x6c2
github.com/cockroachdb/cockroach/pkg/server.(*sqlServer).startServeSQL.func1.1(0x50573e0, 0xc000597fa0)
	/go/src/github.com/cockroachdb/cockroach/pkg/server/server.go:1907 +0x166
github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith.func1(0xc0004e3b00, 0x4ffeac0, 0xc0009c08d0, 0xc000386670, 0x50573e0, 0xc000597fa0, 0xc0009c0900)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:147 +0xaf
created by github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:144 +0x25c
Log preceding fatal error

=== RUN   TestAuthenticationAndHBARules
--- FAIL: TestAuthenticationAndHBARules (11.71s)
=== RUN   TestAuthenticationAndHBARules/insecure=false/trust_reject
        --- FAIL: TestAuthenticationAndHBARules/insecure=false/trust_reject (0.00s)

More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestAuthenticationAndHBARules PKG=./pkg/sql/pgwire TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Jul 28, 2020
@cockroach-teamcity cockroach-teamcity added this to the 20.2 milestone Jul 28, 2020
@cockroach-teamcity
Copy link
Member Author

(sql/pgwire).TestAuthenticationAndHBARules failed on master@3c358360ebbec8a7780a752f750d3a672e97714e:

Fatal error:

panic: logging already active; first use:

Stack:

goroutine 33164 [running]:
runtime/debug.Stack(0x73, 0x43ecb4e, 0x6)
	/usr/local/go/src/runtime/debug/stack.go:24 +0x9d
github.com/cockroachdb/cockroach/pkg/util/log.setActive()
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:424 +0x9a
github.com/cockroachdb/cockroach/pkg/util/log.(*loggerT).outputLogEntry(0xc003b9fd00, 0x1, 0x162600f1ccfd063b, 0x818c, 0x7019357, 0x14, 0x1f2, 0xc0018c81e0, 0x24, 0xc001946b00, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:246 +0xc9
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).output(0xc003b9fd00, 0x4ffeac0, 0xc0041b6360, 0x1, 0xe00000001, 0x4425b9a, 0x1a, 0xc000767c28, 0x1, 0x1)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:119 +0x118
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).Logf(...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:124
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).ServeConn.func1(0xc0011557a0, 0xc000767ec8, 0x117e5d0e, 0xed6b271fc, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/server.go:498 +0x11d
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).ServeConn(0xc0011557a0, 0x4ffeac0, 0xc0041b6360, 0x50560c0, 0xc002661c00, 0xc0020d2101, 0x0, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/server.go:589 +0x6c2
github.com/cockroachdb/cockroach/pkg/server.(*sqlServer).startServeSQL.func1.1(0x50573e0, 0xc0019b1060)
	/go/src/github.com/cockroachdb/cockroach/pkg/server/server.go:1907 +0x166
github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith.func1(0xc004482fc0, 0x4ffeac0, 0xc003456000, 0xc0019b0da0, 0x50573e0, 0xc0019b1060, 0xc003456030)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:147 +0xaf
created by github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:144 +0x25c
 [recovered]
	panic: logging already active; first use:
goroutine 33164 [running]:
runtime/debug.Stack(0x73, 0x43ecb4e, 0x6)
	/usr/local/go/src/runtime/debug/stack.go:24 +0x9d
github.com/cockroachdb/cockroach/pkg/util/log.setActive()
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:424 +0x9a
github.com/cockroachdb/cockroach/pkg/util/log.(*loggerT).outputLogEntry(0xc003b9fd00, 0x1, 0x162600f1ccfd063b, 0x818c, 0x7019357, 0x14, 0x1f2, 0xc0018c81e0, 0x24, 0xc001946b00, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:246 +0xc9
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).output(0xc003b9fd00, 0x4ffeac0, 0xc0041b6360, 0x1, 0xe00000001, 0x4425b9a, 0x1a, 0xc000767c28, 0x1, 0x1)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:119 +0x118
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).Logf(...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:124
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).ServeConn.func1(0xc0011557a0, 0xc000767ec8, 0x117e5d0e, 0xed6b271fc, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/server.go:498 +0x11d
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).ServeConn(0xc0011557a0, 0x4ffeac0, 0xc0041b6360, 0x50560c0, 0xc002661c00, 0xc0020d2101, 0x0, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/server.go:589 +0x6c2
github.com/cockroachdb/cockroach/pkg/server.(*sqlServer).startServeSQL.func1.1(0x50573e0, 0xc0019b1060)
	/go/src/github.com/cockroachdb/cockroach/pkg/server/server.go:1907 +0x166
github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith.func1(0xc004482fc0, 0x4ffeac0, 0xc003456000, 0xc0019b0da0, 0x50573e0, 0xc0019b1060, 0xc003456030)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:147 +0xaf
created by github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:144 +0x25c
Log preceding fatal error

=== RUN   TestAuthenticationAndHBARules
--- FAIL: TestAuthenticationAndHBARules (7.87s)
=== RUN   TestAuthenticationAndHBARules/insecure=false/hba_syntax
        --- FAIL: TestAuthenticationAndHBARules/insecure=false/hba_syntax (0.00s)

More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestAuthenticationAndHBARules PKG=./pkg/sql/pgwire TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity
Copy link
Member Author

(sql/pgwire).TestAuthenticationAndHBARules failed on master@629ce5ea3f105e4db7a51b388b96e519d271425d:

Fatal error:

panic: logging already active; first use:

Stack:

goroutine 39896 [running]:
runtime/debug.Stack(0xc005e7d208, 0x6f6fbc, 0xc003f115d4)
	/usr/local/go/src/runtime/debug/stack.go:24 +0x9d
github.com/cockroachdb/cockroach/pkg/util/log.setActive()
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:424 +0x9a
github.com/cockroachdb/cockroach/pkg/util/log.(*loggerT).outputLogEntry(0xc003f11580, 0x1, 0x162602618080a3c2, 0x9bd8, 0x7019399, 0x12, 0xe0, 0xc00286f740, 0x2a, 0xc0006250c0, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:246 +0xc9
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).output(0xc003f11580, 0x4ffea00, 0xc0020c6640, 0x1, 0xe00000001, 0x443ecc8, 0x20, 0xc005e7d850, 0x1, 0x1)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:119 +0x118
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).Logf(...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:124
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).serveImpl.func2(0xc0027bad00, 0xc003f11580, 0xc003d5c9d0, 0x103eb8b1, 0xed6b27827, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:224 +0x10c
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).serveImpl(0xc0027bad00, 0x4ffeac0, 0xc005a7f020, 0xc003d5c9c0, 0xc003f0ec00, 0x5400, 0x15000, 0xc003f2a500, 0x0, 0x4, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:457 +0x919
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).serveConn(0xc003f42fc0, 0x4ffeac0, 0xc005a7f020, 0x50560c0, 0xc002536000, 0xc001635033, 0x4, 0xc005a7f050, 0x4fbfdc0, 0xc005a7eab0, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:154 +0x1d1
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).ServeConn(0xc003f42fc0, 0x4ffeac0, 0xc005a7f020, 0x50560c0, 0xc002536000, 0xc003d5c401, 0x0, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/server.go:579 +0x6b6
github.com/cockroachdb/cockroach/pkg/server.(*sqlServer).startServeSQL.func1.1(0x50573e0, 0xc002c82120)
	/go/src/github.com/cockroachdb/cockroach/pkg/server/server.go:1907 +0x166
github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith.func1(0xc000792000, 0x4ffeac0, 0xc003ed8900, 0xc0014bb4f8, 0x50573e0, 0xc002c82120, 0xc003ed8930)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:147 +0xaf
created by github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:144 +0x25c
 [recovered]
	panic: logging already active; first use:
goroutine 39896 [running]:
runtime/debug.Stack(0xc005e7d208, 0x6f6fbc, 0xc003f115d4)
	/usr/local/go/src/runtime/debug/stack.go:24 +0x9d
github.com/cockroachdb/cockroach/pkg/util/log.setActive()
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:424 +0x9a
github.com/cockroachdb/cockroach/pkg/util/log.(*loggerT).outputLogEntry(0xc003f11580, 0x1, 0x162602618080a3c2, 0x9bd8, 0x7019399, 0x12, 0xe0, 0xc00286f740, 0x2a, 0xc0006250c0, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:246 +0xc9
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).output(0xc003f11580, 0x4ffea00, 0xc0020c6640, 0x1, 0xe00000001, 0x443ecc8, 0x20, 0xc005e7d850, 0x1, 0x1)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:119 +0x118
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).Logf(...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:124
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).serveImpl.func2(0xc0027bad00, 0xc003f11580, 0xc003d5c9d0, 0x103eb8b1, 0xed6b27827, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:224 +0x10c
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).serveImpl(0xc0027bad00, 0x4ffeac0, 0xc005a7f020, 0xc003d5c9c0, 0xc003f0ec00, 0x5400, 0x15000, 0xc003f2a500, 0x0, 0x4, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:457 +0x919
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).serveConn(0xc003f42fc0, 0x4ffeac0, 0xc005a7f020, 0x50560c0, 0xc002536000, 0xc001635033, 0x4, 0xc005a7f050, 0x4fbfdc0, 0xc005a7eab0, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:154 +0x1d1
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).ServeConn(0xc003f42fc0, 0x4ffeac0, 0xc005a7f020, 0x50560c0, 0xc002536000, 0xc003d5c401, 0x0, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/server.go:579 +0x6b6
github.com/cockroachdb/cockroach/pkg/server.(*sqlServer).startServeSQL.func1.1(0x50573e0, 0xc002c82120)
	/go/src/github.com/cockroachdb/cockroach/pkg/server/server.go:1907 +0x166
github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith.func1(0xc000792000, 0x4ffeac0, 0xc003ed8900, 0xc0014bb4f8, 0x50573e0, 0xc002c82120, 0xc003ed8930)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:147 +0xaf
created by github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:144 +0x25c
Log preceding fatal error

=== RUN   TestAuthenticationAndHBARules
--- FAIL: TestAuthenticationAndHBARules (12.45s)
=== RUN   TestAuthenticationAndHBARules/insecure=false/trust_reject
        --- FAIL: TestAuthenticationAndHBARules/insecure=false/trust_reject (0.00s)

More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestAuthenticationAndHBARules PKG=./pkg/sql/pgwire TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity
Copy link
Member Author

(sql/pgwire).TestAuthenticationAndHBARules failed on master@4de665c6cf65850b4910787e88f377c213085a53:

Fatal error:

panic: logging already active; first use:

Stack:

goroutine 39145 [running]:
runtime/debug.Stack(0xc0004c9208, 0x6f6fbc, 0xc0018d1454)
	/usr/local/go/src/runtime/debug/stack.go:24 +0x9d
github.com/cockroachdb/cockroach/pkg/util/log.setActive()
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:424 +0x9a
github.com/cockroachdb/cockroach/pkg/util/log.(*loggerT).outputLogEntry(0xc0018d1400, 0x1, 0x162608dfdf47bd9b, 0x98e9, 0x701b9b9, 0x12, 0xe0, 0xc0004d1cb0, 0x2a, 0xc002899ac0, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:246 +0xc9
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).output(0xc0018d1400, 0x5000420, 0xc00463a140, 0x1, 0xe00000001, 0x4440329, 0x20, 0xc0004c9850, 0x1, 0x1)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:119 +0x118
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).Logf(...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:124
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).serveImpl.func2(0xc00051db00, 0xc0018d1400, 0xc0044ee360, 0x2e53525a, 0xed6b2940a, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:224 +0x10c
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).serveImpl(0xc00051db00, 0x50004e0, 0xc003dfc300, 0xc0044ee350, 0xc001820c00, 0x5400, 0x15000, 0xc001d461e0, 0x0, 0x4, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:457 +0x919
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).serveConn(0xc001863b00, 0x50004e0, 0xc003dfc300, 0x5057ae0, 0xc001040700, 0xc00620701e, 0x4, 0xc003dfc330, 0x4fc1820, 0xc0029c1c80, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:154 +0x1d1
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).ServeConn(0xc001863b00, 0x50004e0, 0xc003dfc300, 0x5057ae0, 0xc001040700, 0xc002a46501, 0x0, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/server.go:579 +0x6b6
github.com/cockroachdb/cockroach/pkg/server.(*sqlServer).startServeSQL.func1.1(0x5058e00, 0xc005482128)
	/go/src/github.com/cockroachdb/cockroach/pkg/server/server.go:1907 +0x166
github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith.func1(0xc004ffd4d0, 0x50004e0, 0xc00540e090, 0xc004b17008, 0x5058e00, 0xc005482128, 0xc00540e0c0)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:147 +0xaf
created by github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:144 +0x25c
 [recovered]
	panic: logging already active; first use:
goroutine 39145 [running]:
runtime/debug.Stack(0xc0004c9208, 0x6f6fbc, 0xc0018d1454)
	/usr/local/go/src/runtime/debug/stack.go:24 +0x9d
github.com/cockroachdb/cockroach/pkg/util/log.setActive()
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:424 +0x9a
github.com/cockroachdb/cockroach/pkg/util/log.(*loggerT).outputLogEntry(0xc0018d1400, 0x1, 0x162608dfdf47bd9b, 0x98e9, 0x701b9b9, 0x12, 0xe0, 0xc0004d1cb0, 0x2a, 0xc002899ac0, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:246 +0xc9
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).output(0xc0018d1400, 0x5000420, 0xc00463a140, 0x1, 0xe00000001, 0x4440329, 0x20, 0xc0004c9850, 0x1, 0x1)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:119 +0x118
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).Logf(...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:124
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).serveImpl.func2(0xc00051db00, 0xc0018d1400, 0xc0044ee360, 0x2e53525a, 0xed6b2940a, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:224 +0x10c
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).serveImpl(0xc00051db00, 0x50004e0, 0xc003dfc300, 0xc0044ee350, 0xc001820c00, 0x5400, 0x15000, 0xc001d461e0, 0x0, 0x4, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:457 +0x919
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).serveConn(0xc001863b00, 0x50004e0, 0xc003dfc300, 0x5057ae0, 0xc001040700, 0xc00620701e, 0x4, 0xc003dfc330, 0x4fc1820, 0xc0029c1c80, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:154 +0x1d1
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).ServeConn(0xc001863b00, 0x50004e0, 0xc003dfc300, 0x5057ae0, 0xc001040700, 0xc002a46501, 0x0, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/server.go:579 +0x6b6
github.com/cockroachdb/cockroach/pkg/server.(*sqlServer).startServeSQL.func1.1(0x5058e00, 0xc005482128)
	/go/src/github.com/cockroachdb/cockroach/pkg/server/server.go:1907 +0x166
github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith.func1(0xc004ffd4d0, 0x50004e0, 0xc00540e090, 0xc004b17008, 0x5058e00, 0xc005482128, 0xc00540e0c0)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:147 +0xaf
created by github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:144 +0x25c
Log preceding fatal error

=== RUN   TestAuthenticationAndHBARules
--- FAIL: TestAuthenticationAndHBARules (13.30s)
=== RUN   TestAuthenticationAndHBARules/insecure=false/trust_reject
        --- FAIL: TestAuthenticationAndHBARules/insecure=false/trust_reject (0.00s)

More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestAuthenticationAndHBARules PKG=./pkg/sql/pgwire TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

@adityamaru adityamaru mentioned this issue Jul 28, 2020
Merged
@adityamaru
Copy link
Contributor

@knz temporarily skipped this test in #52041.

@cockroach-teamcity
Copy link
Member Author

(sql/pgwire).TestAuthenticationAndHBARules failed on master@4de665c6cf65850b4910787e88f377c213085a53:

Fatal error:

panic: logging already active; first use:

Stack:

goroutine 28118 [running]:
runtime/debug.Stack(0xc00076b208, 0x6f6fbc, 0xc002d1a8d4)
	/usr/local/go/src/runtime/debug/stack.go:24 +0x9d
github.com/cockroachdb/cockroach/pkg/util/log.setActive()
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:424 +0x9a
github.com/cockroachdb/cockroach/pkg/util/log.(*loggerT).outputLogEntry(0xc002d1a880, 0x1, 0x16260caba7cc3022, 0x6dd6, 0x701b9b9, 0x12, 0xe0, 0xc001864030, 0x29, 0xc002e8ed80, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:246 +0xc9
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).output(0xc002d1a880, 0x5000420, 0xc0034a19c0, 0x1, 0xe00000001, 0x4440329, 0x20, 0xc00076b850, 0x1, 0x1)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:119 +0x118
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).Logf(...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:124
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).serveImpl.func2(0xc0005dd200, 0xc002d1a880, 0xc000689460, 0x10633dfb, 0xed6b2a459, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:224 +0x10c
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).serveImpl(0xc0005dd200, 0x50004e0, 0xc00204d9b0, 0xc000689450, 0xc000b12580, 0x5400, 0x15000, 0xc002e3afa0, 0x0, 0x4, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:457 +0x919
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).serveConn(0xc0028367e0, 0x50004e0, 0xc00204d9b0, 0x5057ae0, 0xc00050aa80, 0xc000e5201e, 0x4, 0xc00204d9e0, 0x4fc1820, 0xc002f68030, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:154 +0x1d1
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).ServeConn(0xc0028367e0, 0x50004e0, 0xc00204d9b0, 0x5057ae0, 0xc00050aa80, 0xc00357e001, 0x0, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/server.go:579 +0x6b6
github.com/cockroachdb/cockroach/pkg/server.(*sqlServer).startServeSQL.func1.1(0x5058e00, 0xc000294020)
	/go/src/github.com/cockroachdb/cockroach/pkg/server/server.go:1907 +0x166
github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith.func1(0xc0015c6900, 0x50004e0, 0xc0038e4180, 0xc000132a78, 0x5058e00, 0xc000294020, 0xc0038e41b0)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:147 +0xaf
created by github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:144 +0x25c
 [recovered]
	panic: logging already active; first use:
goroutine 28118 [running]:
runtime/debug.Stack(0xc00076b208, 0x6f6fbc, 0xc002d1a8d4)
	/usr/local/go/src/runtime/debug/stack.go:24 +0x9d
github.com/cockroachdb/cockroach/pkg/util/log.setActive()
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:424 +0x9a
github.com/cockroachdb/cockroach/pkg/util/log.(*loggerT).outputLogEntry(0xc002d1a880, 0x1, 0x16260caba7cc3022, 0x6dd6, 0x701b9b9, 0x12, 0xe0, 0xc001864030, 0x29, 0xc002e8ed80, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:246 +0xc9
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).output(0xc002d1a880, 0x5000420, 0xc0034a19c0, 0x1, 0xe00000001, 0x4440329, 0x20, 0xc00076b850, 0x1, 0x1)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:119 +0x118
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).Logf(...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:124
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).serveImpl.func2(0xc0005dd200, 0xc002d1a880, 0xc000689460, 0x10633dfb, 0xed6b2a459, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:224 +0x10c
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).serveImpl(0xc0005dd200, 0x50004e0, 0xc00204d9b0, 0xc000689450, 0xc000b12580, 0x5400, 0x15000, 0xc002e3afa0, 0x0, 0x4, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:457 +0x919
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).serveConn(0xc0028367e0, 0x50004e0, 0xc00204d9b0, 0x5057ae0, 0xc00050aa80, 0xc000e5201e, 0x4, 0xc00204d9e0, 0x4fc1820, 0xc002f68030, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:154 +0x1d1
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).ServeConn(0xc0028367e0, 0x50004e0, 0xc00204d9b0, 0x5057ae0, 0xc00050aa80, 0xc00357e001, 0x0, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/server.go:579 +0x6b6
github.com/cockroachdb/cockroach/pkg/server.(*sqlServer).startServeSQL.func1.1(0x5058e00, 0xc000294020)
	/go/src/github.com/cockroachdb/cockroach/pkg/server/server.go:1907 +0x166
github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith.func1(0xc0015c6900, 0x50004e0, 0xc0038e4180, 0xc000132a78, 0x5058e00, 0xc000294020, 0xc0038e41b0)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:147 +0xaf
created by github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:144 +0x25c
Log preceding fatal error

=== RUN   TestAuthenticationAndHBARules
--- FAIL: TestAuthenticationAndHBARules (3.46s)
=== RUN   TestAuthenticationAndHBARules/insecure=false/empty_hba
        --- FAIL: TestAuthenticationAndHBARules/insecure=false/empty_hba (0.00s)

More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestAuthenticationAndHBARules PKG=./pkg/sql/pgwire TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity
Copy link
Member Author

(sql/pgwire).TestAuthenticationAndHBARules failed on master@c9c2aa454d5428d5327993a696464072d8224507:

Fatal error:

panic: logging already active; first use:

Stack:

goroutine 41310 [running]:
runtime/debug.Stack(0xc0024c1208, 0x6f6fbc, 0xc0036dcdd4)
	/usr/local/go/src/runtime/debug/stack.go:24 +0x9d
github.com/cockroachdb/cockroach/pkg/util/log.setActive()
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:424 +0x9a
github.com/cockroachdb/cockroach/pkg/util/log.(*loggerT).outputLogEntry(0xc0036dcd80, 0x1, 0x162623da6ffa3dcf, 0xa15e, 0x701d411, 0x12, 0xe0, 0xc003e2b320, 0x2a, 0xc002f49600, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:246 +0xc9
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).output(0xc0036dcd80, 0x5001680, 0xc000676bc0, 0x1, 0xe00000001, 0x44412e0, 0x20, 0xc0024c1850, 0x1, 0x1)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:119 +0x118
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).Logf(...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:124
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).serveImpl.func2(0xc000981200, 0xc0036dcd80, 0xc000673e30, 0x31daa7c5, 0xed6b307ea, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:224 +0x10c
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).serveImpl(0xc000981200, 0x5001740, 0xc003030630, 0xc000673e20, 0xc000def700, 0x5400, 0x15000, 0xc005b46640, 0x0, 0x4, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:457 +0x919
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).serveConn(0xc0014b9320, 0x5001740, 0xc003030630, 0x5058d40, 0xc003996a80, 0xc000865046, 0x4, 0xc003030660, 0x4fc29c0, 0xc0010601e0, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:154 +0x1d1
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).ServeConn(0xc0014b9320, 0x5001740, 0xc003030630, 0x5058d40, 0xc003996a80, 0xc00252ce01, 0x0, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/server.go:579 +0x6b6
github.com/cockroachdb/cockroach/pkg/server.(*sqlServer).startServeSQL.func1.1(0x505a060, 0xc001eb41c0)
	/go/src/github.com/cockroachdb/cockroach/pkg/server/server.go:1907 +0x166
github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith.func1(0xc005b0db00, 0x5001740, 0xc0020d0fc0, 0xc005df24d0, 0x505a060, 0xc001eb41c0, 0xc0020d0ff0)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:147 +0xaf
created by github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:144 +0x25c
 [recovered]
	panic: logging already active; first use:
goroutine 41310 [running]:
runtime/debug.Stack(0xc0024c1208, 0x6f6fbc, 0xc0036dcdd4)
	/usr/local/go/src/runtime/debug/stack.go:24 +0x9d
github.com/cockroachdb/cockroach/pkg/util/log.setActive()
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:424 +0x9a
github.com/cockroachdb/cockroach/pkg/util/log.(*loggerT).outputLogEntry(0xc0036dcd80, 0x1, 0x162623da6ffa3dcf, 0xa15e, 0x701d411, 0x12, 0xe0, 0xc003e2b320, 0x2a, 0xc002f49600, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:246 +0xc9
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).output(0xc0036dcd80, 0x5001680, 0xc000676bc0, 0x1, 0xe00000001, 0x44412e0, 0x20, 0xc0024c1850, 0x1, 0x1)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:119 +0x118
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).Logf(...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:124
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).serveImpl.func2(0xc000981200, 0xc0036dcd80, 0xc000673e30, 0x31daa7c5, 0xed6b307ea, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:224 +0x10c
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).serveImpl(0xc000981200, 0x5001740, 0xc003030630, 0xc000673e20, 0xc000def700, 0x5400, 0x15000, 0xc005b46640, 0x0, 0x4, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:457 +0x919
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).serveConn(0xc0014b9320, 0x5001740, 0xc003030630, 0x5058d40, 0xc003996a80, 0xc000865046, 0x4, 0xc003030660, 0x4fc29c0, 0xc0010601e0, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:154 +0x1d1
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).ServeConn(0xc0014b9320, 0x5001740, 0xc003030630, 0x5058d40, 0xc003996a80, 0xc00252ce01, 0x0, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/server.go:579 +0x6b6
github.com/cockroachdb/cockroach/pkg/server.(*sqlServer).startServeSQL.func1.1(0x505a060, 0xc001eb41c0)
	/go/src/github.com/cockroachdb/cockroach/pkg/server/server.go:1907 +0x166
github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith.func1(0xc005b0db00, 0x5001740, 0xc0020d0fc0, 0xc005df24d0, 0x505a060, 0xc001eb41c0, 0xc0020d0ff0)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:147 +0xaf
created by github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:144 +0x25c
Log preceding fatal error

=== RUN   TestAuthenticationAndHBARules
--- FAIL: TestAuthenticationAndHBARules (6.60s)
=== RUN   TestAuthenticationAndHBARules/insecure=true
    --- FAIL: TestAuthenticationAndHBARules/insecure=true (0.00s)
=== RUN   TestAuthenticationAndHBARules/insecure=true/conn_log
        --- FAIL: TestAuthenticationAndHBARules/insecure=true/conn_log (0.00s)

More

Parameters:

  • TAGS=
  • GOFLAGS=-parallel=4
make stressrace TESTS=TestAuthenticationAndHBARules PKG=./pkg/sql/pgwire TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

@irfansharif irfansharif mentioned this issue Jul 29, 2020
Merged
craig bot pushed a commit that referenced this issue Jul 29, 2020
@jhatcher9999 @dt
@adityamaru @sumeerbhola @otan
Merge #52017 #52029 #52041 #52064 #52068
a22cc72 
52017: added Jim Hatcher to authors file r=jhatcher9999 a=jhatcher9999



52029: EXPORT: remove license check r=dt a=dt

Release note (sql change): the EXPORT statement no longer requires an enterprise license

52041: pgwire: skip TestAuthenticationAndHBARules due to repeated failures r=irfansharif a=adityamaru

Informs: #52026

52064: geoindex: make geometry index bounds a square r=sumeerbhola a=sumeerbhola

For SRIDs where the rectangle defined by the dimensions
(maxX-minX, maxY-minY) is not close to a square, the
original shape is distorted when converting the planar
point to an S2 point. This can make shapes that have
good coverings when not distorted to have poor coverings
post-distortion. For example SRID 26918, used in the NYC
dataset, has SRID bounds where the span of the X axis is
~1/10th the span of the Y axis. Before this change, the
average ratio of the cell covering area to the shape
area was ~14 (closer to 1 is good). After this change,
the ratio is ~5.2.

This ratio improvement helps queries. For example, in a
query of the form

SELECT ... FROM nyc_census_blocks@geom_idx AS census
JOIN nyc_subway_stations AS subways
ON ST_Intersects(subways.geom, census.geom)

the false positive row count produced by the inverted
joiner reduced from 6712 to 2615. And the query latency
reduced from ~146ms to ~110ms.
A similar query with ST_DWithin(subways.geom, census.geom, 200)
had a latency reduction from ~410ms to ~275ms, because
the final filtering step done by the joinReader had a
reduction in rows from 48257 to 23183 (of these rows,
only 8608 rows passed the filter).

Release note: None

52068: sql: allow escape of any character for COPY r=mjibson a=otan

According to the PostgreSQL docs:
  Any other backslashed character that is not mentioned in the above
  table will be taken to represent itself.

Reflect that change by converting error conditions from decodeCopy into
interpreting the characters as is.

Resolves #52067.

Release note (bug fix): `COPY` previously did not allow a backslash of
any character other than the special table set. CockroachDB would error
in these cases. This is changed to allow in any character after a
backslash and interpret it to mean the character itself as per PostgreSQL
(e.g. now `\a` will be interpreted as `a`). Furthermore, non hex-digits
following a `\x` is now interpreted without the backslash, (e.g. `\xH` as
`xH`). Strings ending with a single backslash will use the backslash
(e.g. `x\\` is interpreted as `x\`).

Co-authored-by: Jim Hatcher <[email protected]>
Co-authored-by: David Taylor <[email protected]>
Co-authored-by: Aditya Maru <[email protected]>
Co-authored-by: sumeerbhola <[email protected]>
Co-authored-by: Oliver Tan <[email protected]>
@cockroach-teamcity
Copy link
Member Author

(sql/pgwire).TestAuthenticationAndHBARules failed on master@8dff8dae1c90e66439a1d7c808713e6fe28997e5:

Fatal error:

panic: logging already active; first use:

Stack:

goroutine 31394 [running]:
runtime/debug.Stack(0x73, 0x43f6f6e, 0x6)
	/usr/local/go/src/runtime/debug/stack.go:24 +0x9d
github.com/cockroachdb/cockroach/pkg/util/log.setActive()
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:424 +0x9a
github.com/cockroachdb/cockroach/pkg/util/log.(*loggerT).outputLogEntry(0xc00391b680, 0x1, 0x16265a637f5c5d6f, 0x7aa2, 0x702a680, 0x14, 0x1f2, 0xc0019732c0, 0x24, 0xc003370040, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:246 +0xc9
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).output(0xc00391b680, 0x5008be0, 0xc0015f26f0, 0x1, 0xe00000001, 0x4430016, 0x1a, 0xc000c93c28, 0x1, 0x1)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:119 +0x118
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).Logf(...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:124
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).ServeConn.func1(0xc003c41440, 0xc000c93ec8, 0x2f965fd7, 0xed6b3f223, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/server.go:498 +0x11d
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).ServeConn(0xc003c41440, 0x5008be0, 0xc0015f26f0, 0x5060240, 0xc003b21c00, 0xc003898301, 0x0, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/server.go:589 +0x6c2
github.com/cockroachdb/cockroach/pkg/server.(*sqlServer).startServeSQL.func1.1(0x5061560, 0xc000011600)
	/go/src/github.com/cockroachdb/cockroach/pkg/server/server.go:1907 +0x166
github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith.func1(0xc004ba38c0, 0x5008be0, 0xc005a7f320, 0xc0003bb048, 0x5061560, 0xc000011600, 0xc005a7f350)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:147 +0xaf
created by github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:144 +0x25c
 [recovered]
	panic: logging already active; first use:
goroutine 31394 [running]:
runtime/debug.Stack(0x73, 0x43f6f6e, 0x6)
	/usr/local/go/src/runtime/debug/stack.go:24 +0x9d
github.com/cockroachdb/cockroach/pkg/util/log.setActive()
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:424 +0x9a
github.com/cockroachdb/cockroach/pkg/util/log.(*loggerT).outputLogEntry(0xc00391b680, 0x1, 0x16265a637f5c5d6f, 0x7aa2, 0x702a680, 0x14, 0x1f2, 0xc0019732c0, 0x24, 0xc003370040, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:246 +0xc9
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).output(0xc00391b680, 0x5008be0, 0xc0015f26f0, 0x1, 0xe00000001, 0x4430016, 0x1a, 0xc000c93c28, 0x1, 0x1)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:119 +0x118
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).Logf(...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:124
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).ServeConn.func1(0xc003c41440, 0xc000c93ec8, 0x2f965fd7, 0xed6b3f223, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/server.go:498 +0x11d
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).ServeConn(0xc003c41440, 0x5008be0, 0xc0015f26f0, 0x5060240, 0xc003b21c00, 0xc003898301, 0x0, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/server.go:589 +0x6c2
github.com/cockroachdb/cockroach/pkg/server.(*sqlServer).startServeSQL.func1.1(0x5061560, 0xc000011600)
	/go/src/github.com/cockroachdb/cockroach/pkg/server/server.go:1907 +0x166
github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith.func1(0xc004ba38c0, 0x5008be0, 0xc005a7f320, 0xc0003bb048, 0x5061560, 0xc000011600, 0xc005a7f350)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:147 +0xaf
created by github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:144 +0x25c
Log preceding fatal error

=== RUN   TestAuthenticationAndHBARules
--- FAIL: TestAuthenticationAndHBARules (7.50s)
=== RUN   TestAuthenticationAndHBARules/insecure=false/hba_host_selection
        --- FAIL: TestAuthenticationAndHBARules/insecure=false/hba_host_selection (0.00s)

More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestAuthenticationAndHBARules PKG=./pkg/sql/pgwire TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity
Copy link
Member Author

(sql/pgwire).TestAuthenticationAndHBARules failed on master@8dff8dae1c90e66439a1d7c808713e6fe28997e5:

Fatal error:

panic: logging already active; first use:

Stack:

goroutine 30250 [running]:
runtime/debug.Stack(0xc0020cf208, 0x6f6fbc, 0xc0037261d4)
	/usr/local/go/src/runtime/debug/stack.go:24 +0x9d
github.com/cockroachdb/cockroach/pkg/util/log.setActive()
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:424 +0x9a
github.com/cockroachdb/cockroach/pkg/util/log.(*loggerT).outputLogEntry(0xc003726180, 0x1, 0x16265dab04b5a2df, 0x762a, 0x702a6c2, 0x12, 0xe0, 0xc00463a8a0, 0x2a, 0xc001b46f00, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:246 +0xc9
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).output(0xc003726180, 0x5008b20, 0xc001e6c080, 0x1, 0xe00000001, 0x4449198, 0x20, 0xc0020cf850, 0x1, 0x1)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:119 +0x118
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).Logf(...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:124
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).serveImpl.func2(0xc000650d00, 0xc003726180, 0xc003508580, 0x3696df4b, 0xed6b4003a, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:224 +0x10c
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).serveImpl(0xc000650d00, 0x5008be0, 0xc004a616e0, 0xc003508410, 0xc000e83600, 0x5400, 0x15000, 0xc000fa7540, 0x0, 0x4, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:444 +0x822
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).serveConn(0xc003535440, 0x5008be0, 0xc004a616e0, 0x5060240, 0xc001a7dc00, 0xc00321c7e0, 0x11, 0xc004a61710, 0x4fc9e60, 0xc004a61080, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:154 +0x1d1
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).ServeConn(0xc003535440, 0x5008be0, 0xc004a616e0, 0x5060240, 0xc001a7dc00, 0xc003314001, 0x0, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/server.go:579 +0x6b6
github.com/cockroachdb/cockroach/pkg/server.(*sqlServer).startServeSQL.func1.1(0x5061560, 0xc0017c1208)
	/go/src/github.com/cockroachdb/cockroach/pkg/server/server.go:1907 +0x166
github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith.func1(0xc00490a750, 0x5008be0, 0xc00414cab0, 0xc000f149a8, 0x5061560, 0xc0017c1208, 0xc00414cae0)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:147 +0xaf
created by github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:144 +0x25c
 [recovered]
	panic: logging already active; first use:
goroutine 30250 [running]:
runtime/debug.Stack(0xc0020cf208, 0x6f6fbc, 0xc0037261d4)
	/usr/local/go/src/runtime/debug/stack.go:24 +0x9d
github.com/cockroachdb/cockroach/pkg/util/log.setActive()
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:424 +0x9a
github.com/cockroachdb/cockroach/pkg/util/log.(*loggerT).outputLogEntry(0xc003726180, 0x1, 0x16265dab04b5a2df, 0x762a, 0x702a6c2, 0x12, 0xe0, 0xc00463a8a0, 0x2a, 0xc001b46f00, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/clog.go:246 +0xc9
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).output(0xc003726180, 0x5008b20, 0xc001e6c080, 0x1, 0xe00000001, 0x4449198, 0x20, 0xc0020cf850, 0x1, 0x1)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:119 +0x118
github.com/cockroachdb/cockroach/pkg/util/log.(*SecondaryLogger).Logf(...)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/log/secondary_log.go:124
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).serveImpl.func2(0xc000650d00, 0xc003726180, 0xc003508580, 0x3696df4b, 0xed6b4003a, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:224 +0x10c
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).serveImpl(0xc000650d00, 0x5008be0, 0xc004a616e0, 0xc003508410, 0xc000e83600, 0x5400, 0x15000, 0xc000fa7540, 0x0, 0x4, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:444 +0x822
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).serveConn(0xc003535440, 0x5008be0, 0xc004a616e0, 0x5060240, 0xc001a7dc00, 0xc00321c7e0, 0x11, 0xc004a61710, 0x4fc9e60, 0xc004a61080, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:154 +0x1d1
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).ServeConn(0xc003535440, 0x5008be0, 0xc004a616e0, 0x5060240, 0xc001a7dc00, 0xc003314001, 0x0, 0x0)
	/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/server.go:579 +0x6b6
github.com/cockroachdb/cockroach/pkg/server.(*sqlServer).startServeSQL.func1.1(0x5061560, 0xc0017c1208)
	/go/src/github.com/cockroachdb/cockroach/pkg/server/server.go:1907 +0x166
github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith.func1(0xc00490a750, 0x5008be0, 0xc00414cab0, 0xc000f149a8, 0x5061560, 0xc0017c1208, 0xc00414cae0)
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:147 +0xaf
created by github.com/cockroachdb/cockroach/pkg/util/netutil.(*Server).ServeWith
	/go/src/github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:144 +0x25c
Log preceding fatal error

=== RUN   TestAuthenticationAndHBARules
--- FAIL: TestAuthenticationAndHBARules (5.00s)
=== RUN   TestAuthenticationAndHBARules/insecure=false/hba_default_equivalence
        --- FAIL: TestAuthenticationAndHBARules/insecure=false/hba_default_equivalence (0.00s)

More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestAuthenticationAndHBARules PKG=./pkg/sql/pgwire TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

@knz knz mentioned this issue Jul 31, 2020
Merged
@craig craig bot closed this as completed in 62b11e1 Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knz knz

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
20.2
Development

Successfully merging a pull request may close this issue.

util/log: improvements, simplifications and bug fixes knz/cockroach
3 participants
@knz @adityamaru @cockroach-teamcity