Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added Jim Hatcher to authors file #52017

Merged
merged 1 commit into from
Jul 29, 2020
Merged

added Jim Hatcher to authors file #52017

merged 1 commit into from
Jul 29, 2020

Conversation

jhatcher9999
Copy link
Collaborator

No description provided.

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jul 28, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jhatcher9999 jhatcher9999 requested a review from otan July 28, 2020 18:06
@jhatcher9999 jhatcher9999 force-pushed the author_name_changes branch from 9f35bff to 4ec8c3a Compare July 28, 2020 18:11
@otan
Copy link
Contributor

otan commented Jul 28, 2020

AUTHORS, line 309 at r1 (raw file):

智雅楠 <[email protected]>
Abby Hersh <[email protected]>
Jim Hatcher <[email protected]>

example comment

otan
otan approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @jhatcher9999 and @otan)

@jhatcher9999
Copy link
Collaborator Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jul 29, 2020

Build succeeded:

@craig craig bot merged commit a22cc72 into cockroachdb:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otan otan otan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhatcher9999 @cockroach-teamcity @otan