pkg/ccl/testccl/workload/schemachange/schemachange_test: TestWorkload failed [mismatched type in violatesFkConstraintsHelper query] #119288
Assignees
Labels
branch-master
Failures and bugs on the master branch.
C-test-failure
Broken test (automatically or manually discovered).
O-robot
Originated from a bot.
P-1
Issues/test failures with a fix SLA of 1 month
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
X-noreuse
Prevent automatic commenting from CI test failures
Milestone
Comments
cockroach-teamcity
added
branch-master
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 7d0697b632066ee78735fc57e8150222d5576d0d: Parameters:
Same failure on other branches
|
rafiss
changed the title
rafiss
added
P-1
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 1340a1e0419ce5df9ae05f5a362a8bbedbcc0a07: Parameters:
Same failure on other branches
|
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 04f0416d526a43741d22fd03966758dcccdeb79f: Parameters:
Same failure on other branches
|
|
Here is the table that is leading to this failure in the most recent test run ^, along with the query generated by violatesFkConstriantsHelper that gets us in this fail state: |
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 24414b864f65c6544ea987f7970fa1c192ca3310: Parameters:
Same failure on other branches
|
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ c9c3cc5f3c3a4a6ab556f4b9d5b6ec0381901bdb: Parameters:
Same failure on other branches
|
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed on master @ c9c3cc5f3c3a4a6ab556f4b9d5b6ec0381901bdb: Parameters:
Same failure on other branches
|
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 140ecc0c19c46204bb04a70ea0e513c45a26ad0d: Parameters:
Same failure on other branches
|
|
ah - i see what is going on. in the |
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 7bb52a7d1c75d5adfdfa53e5fcff6f5e6497408f: Parameters:
Same failure on other branches
|
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ fed794450894a7d1197c763ed26f75d773b93070: Parameters:
Same failure on other branches
|
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 14d19acfdfbc8eb5074ddb38f29ed92c40fac35b: Parameters:
Same failure on other branches
|
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ d4a51117deac22a2ffa280bac5404811cd694265: Parameters:
Same failure on other branches
|
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 72646a555214c0705781e440b9df585d5eea9511: Parameters:
Same failure on other branches
|
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 2e7ab27484135f6cd16199004ba9f20dce777859: Parameters:
Same failure on other branches
|
annrpom
added a commit
to annrpom/cockroach
that referenced
this issue
Mar 11, 2024
Previously, we would check if an insert violated a foreign key constraint by checking if the values to-be inserted conflicted with any existing values in the parent table. At one point, we had to grab the parent column's index by looking it up in a map; however this map did not contain details of every column - just the non-generated ones. This results in some logical errors, but in cases where the incorrectly referenced column type was different, we saw flakes like `ERROR: unsupported comparison operator: <string> = <timetz>`. This patch ensures we use the right map, along with adding a check to ensure a value that we look up in the map actually exists before me assume it does. Epic: none Fixes: cockroachdb#119288 Release note: None
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed on master @ 431d56840cacdc86638ccb48e9f3bdc16897d341: Parameters:
Same failure on other branches
|
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 431d56840cacdc86638ccb48e9f3bdc16897d341: Parameters:
Same failure on other branches
|
exalate-issue-sync
bot
added
P-2
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed on master @ 455b16592df7d8efd121b3ba1256fb477e227564: Parameters:
|
rafiss
added a commit
to rafiss/cockroach
that referenced
this issue
Mar 15, 2024
Until cockroachdb#119288 is resolved, this should be disabled. Release note: None
craig bot
pushed a commit
that referenced
this issue
Mar 15, 2024
120454: roachtest: fix bundle collection on failure in tpchvec/mt-shared-process r=yuzefovich a=yuzefovich Previously, we hard-coded using the connection to the system tenant when collecting the stmt bundle in case the test is failing, and this is now fixed. Additionally, the output of EXPLAIN ANALYZE (DEBUG) doesn't contain the AdminUI link (present in the system tenant) that we used to download the bundle, so this commit refactors the code to use the CLI client instead, that is common for both system and application tenants. Fixes: #120397. Release note: None 120575: workload/schemachange: disable foreign keys due to flakes r=rafiss a=rafiss Until #119288 is resolved, this should be disabled. informs #119288 Release note: None Co-authored-by: Yahor Yuzefovich <[email protected]> Co-authored-by: Rafi Shamim <[email protected]>
annrpom
added a commit
to annrpom/cockroach
that referenced
this issue
Mar 19, 2024
Previously, we would check if an insert violated a foreign key constraint by checking if the values to-be inserted conflicted with any existing values in the parent table. At one point, we had to grab the parent column's index by looking it up in a map; however this map did not contain details of every column - just the non-generated ones. This results in some logical errors, but in cases where the incorrectly referenced column type was different, we saw flakes like `ERROR: unsupported comparison operator: <string> = <timetz>`. This patch ensures we use the right map, along with adding a check to ensure a value that we look up in the map actually exists before me assume it does. Epic: none Fixes: cockroachdb#119288 Release note: None
annrpom
added a commit
to annrpom/cockroach
that referenced
this issue
Mar 21, 2024
Previously, we saw flakes like `ERROR: unsupported comparison operator: <string> = <timetz>` occurring in the rsw because at times, we were indexing a column name in a map without any guards. This meant that if any improperly quoted column name was being looked up in the map, we would just return the default for that key not existing in our map (0). This caused us to refer an arbitrary column's values when validating FK constraints, causing a mismatch that we see above. We now have checks to guard us from making this mistake again, along with proper quotes around column names. In addition, alter FK statements and inserts in the same explicit txn did not bode well - as the query to get our fkConstraints relied on the crdb_internal.is_constraint_active builtin, which does not work in the legacy schema changer: cockroachdb#120702. In this case, we do not need the builtin to filter for our FK constraints. Epic: none Fixes: cockroachdb#119288 Release note: None
craig bot
pushed a commit
that referenced
this issue
Mar 22, 2024
119653: workload/schemachange: deflake violatesFkConstraintsHelper in workload r=rafiss a=annrpom Previously, we saw flakes like `ERROR: unsupported comparison operator: <string> = <timetz>` occurring in the rsw because at times, we were indexing a column name in a map without any guards. This meant that if any improperly quoted column name was being looked up in the map, we would just return the default for that key not existing in our map (0). This caused us to refer an arbitrary column's values when validating FK constraints, causing a mismatch that we see above. We now have checks to guard us from making this mistake again, along with proper quotes around column names. In addition, alter FK statements and inserts in the same explicit txn did not bode well - as the query to get our `fkConstraints` relied on the `crdb_internal.is_constraint_active` builtin, which does not work in the legacy schema changer: #120702. In this case, we do not need the builtin to filter for our FK constraints. Epic: none Fixes: #119288 Release note: None Co-authored-by: Annie Pompa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed on master @ 617bf347978dcc0d711399b1a76402d7f88de958:
Parameters:
attempt=1run=8shard=1Help
See also: How To Investigate a Go Test Failure (internal)
Same failure on other branches
This test on roachdash | Improve this report!
Jira issue: CRDB-36128
The text was updated successfully, but these errors were encountered: