roachtest: fix bundle collection on failure in tpchvec/mt-shared-process #120454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuzefovich
added
the
backport-23.2.x
yuzefovich
requested review from
a team and
rytaft
and removed request for
a team
yuzefovich
requested review from
srosenberg and
renatolabs
and removed request for
a team
|
This change is |
Previously, we hard-coded using the connection to the system tenant when collecting the stmt bundle in case the test is failing, and this is now fixed. Additionally, the output of EXPLAIN ANALYZE (DEBUG) doesn't contain the AdminUI link (present in the system tenant) that we used to download the bundle, so this commit refactors the code to use the CLI client instead, that is common for both system and application tenants. Release note: None
mgartner
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rytaft)
|
TFTR! bors r+ |
|
Build succeeded: |
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 4d21fed to blathers/backport-release-23.2-120454: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we hard-coded using the connection to the system tenant when collecting the stmt bundle in case the test is failing, and this is now fixed.
Additionally, the output of EXPLAIN ANALYZE (DEBUG) doesn't contain the AdminUI link (present in the system tenant) that we used to download the bundle, so this commit refactors the code to use the CLI client instead, that is common for both system and application tenants.
Fixes: #120397.
Release note: None