Remove inline comments from DDL files via ScriptRunner #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds Github Actions CI support via the SqlServer Docker image. * Adds other docker run support. * Adds a column store based schema creation command in addition to the row store one, and a symlink to chose between them (defaulting to cstore).
Also replace some tabs with spaces for consistency
…ectly ... when passing them along to the target server
apavlo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the SQL in src/main/resources/benchmarks/tpch/ddl-sqlserver.sql have lines with comments inline. Because the final SQL statement submitted is a concatenation of all the lines, these in-line comments break the syntax. This PR removes inline comments from the lines.