Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TPC-H support for SQL Server #147

Merged
merged 11 commits into from
Apr 23, 2022
Merged

Add TPC-H support for SQL Server #147

merged 11 commits into from
Apr 23, 2022

Conversation

jcamachor
Copy link
Contributor

No description provided.

apavlo
apavlo requested changes Apr 8, 2022
View reviewed changes
Copy link
Member

@apavlo apavlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor quibbles.

@apavlo
Copy link
Member

apavlo commented Apr 8, 2022

@jcamachor Thanks for sending this. We should probably be testing MSSQL in our Github actions. Is this something you could help with?

@jcamachor
Copy link
Contributor Author

@apavlo , sure, I can do that in a follow-up PR, I can use one of the images in https://hub.docker.com/_/microsoft-mssql-server (already doing some quick tests using one of those) and enable a few different benchmarks.

@bpkroth
Copy link
Collaborator

bpkroth commented Apr 18, 2022

@jcamachor Thanks for sending this. We should probably be testing MSSQL in our Github actions. Is this something you could help with?

I added that in this PR to @jcamachor's branch: jcamachor#1
Also added TPC-C support to CI checks. Can probably add others at a later date as well if desired.

jcamachor and others added 2 commits April 18, 2022 16:11
@jcamachor
Addressing review comments
823ee1b
@bpkroth @jcamachor
Adding tests for MSSQL in Github actions (TPC-C and TPC-H)
a2b505f 
* Adds Github Actions CI support via the SqlServer Docker image.

* Adds other docker run support.

* Adds a column store based schema creation command in addition to the row store one, and a symlink to chose between them (defaulting to cstore).
This was referenced Apr 19, 2022
Merged
Closed
@apavlo
Copy link
Member

apavlo commented Apr 19, 2022

@jcamachor @bpkroth Everything looks good except for the symlink to the DDL file. I think that it is better to have a single file for now and then comment out the column store stuff. Then create issue about being able to specify/override the DDL file from the config file.

bpkroth added a commit to bpkroth/benchbase that referenced this pull request Apr 20, 2022
@bpkroth
addressing comments in <cmu-db#147>
8d2a5f9 
See <cmu-db#147 (comment)>
This was referenced Apr 20, 2022
Closed
Closed
@jcamachor jcamachor mentioned this pull request Apr 20, 2022
Closed
1 task
@apavlo apavlo self-requested a review April 22, 2022 16:14
apavlo
apavlo approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@apavlo apavlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcamachor jcamachor mentioned this pull request Apr 22, 2022
Closed
@apavlo apavlo merged commit c212e02 into cmu-db:main Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apavlo apavlo apavlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcamachor @apavlo @bpkroth