Added selection of IOV sequence snapshot

[ggovi]

This PR introduce the functionality for selecting the IOV sequence ( Tag ) snapshot. It is enabled by specifying a snapshot validity in the Global Tag ( none for the moment ) or to set a user-defined parameter in the cfg file. The default behaviour is unchanged.

[ggovi]

+1

[cmsbuild]

A new Pull Request was created by @ggovi for CMSSW_7_5_X.

Added selection of IOV sequence snapshot

It involves the following packages:

CondCore/CondDB
CondCore/ESSources

@cmsbuild, @mmusich, @diguida, @cerminar, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1 this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[mmusich]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[mmusich]

+1
provided jenkins agrees

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

[cmsbuild]

I had the issue

 Couldn't find remote ref refs/pull/9124/head

Please restart the tests in jenkins providing the complete branch name

[mmusich]

please test

[cmsbuild]

-1

Tested at: 304883c
I found errors in the following unit tests:

---> test testConditionDatabase_0 had ERRORS
---> test runtestTqafTopJetCombination had ERRORS
---> test runtestTqafTopEventSelection had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9124/84/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

[davidlange6]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9124/9459/summary.html

[Martin-Grunewald]

CondCore.CondDB.CondDB_cfi does not contain a "CondDBSetup" PSet needed later in this cfi file.
It does include a CondDB PSet. Should the latter be use, or should the above change be reverted?
(75X/76X).

[ggovi]

@Martin-Grunewald
If I'm not wrong, the search of references to CondCore.ESSources.PoolDBESSource_cfi in CMSSW does not show a single entry. Would be ok to make separate PR to fix this? It is anyhow for usage in cfg files that are (currently ) outside the release...

[Martin-Grunewald]

ConfDB parsing uses CondCore.ESSources.PoolDBESSource_cfi to get the parameters of the
GT PoolDBESSource module (IOW, we need at least a correct cfi file, or a fillDescriptions method).
Separate PRs are fine, of course (75X and 76X).

[Martin-Grunewald]

@ggovi
Any progress on the fix for 75/76?

[ggovi]

@Martin-Grunewald
i should be able to do it this afternoon, will be done by today!