Fix for the reconnect-each-run policy in CondDBESSource

[ggovi]

The fix consists in reverting back the previous fix in PayloadProxy::reload

[cmsbuild]

A new Pull Request was created by @ggovi for CMSSW_7_5_X.

It involves the following packages:

CondCore/CondDB

@ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1 this is something you requested to watch as well.

Following commands in first line of a comment are recognized

• +1|approve[d]|sign[ed]: L1/L2's to approve it
• -1|reject[ed]: L1/L2's to reject it
• assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
• unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
• hold: L1/L2's to mark it as on hold
• merge: L1 to merge this request
• [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
• [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[ggovi]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9658/console

[cmsbuild]

+1
Tested at: 7d1bfd6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12386/9658/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12386/9658/summary.html

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

[diguida]

@mmusich @franzoni to watch

[mmusich]

@diguida @ggovi thanks. Are 7.6.X and 8.0.X safe?

[diguida]

@mmusich seems so...

[mmusich]

am I misreading? https://github.com/cms-sw/cmssw/blob/CMSSW_8_0_X/CondCore/CondDB/src/PayloadProxy.cc#L34 (looks like it has the same bug as 75X). Or is it handled in a deeper way?

[diguida]

@mmusich seems so = seems it is buggy!

[diguida]

PR coming...

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

Could someone summarize what changed since 74x to set off this "bug"?

[ggovi]

Hi David,
the package CondCore/CondDB (and the concerned function in particular) in 75X and 76X diverged from 74X for the introduction of the IOV sequence snapshot.
Here is the PR:
#9124
This is also contain the 'bad' fix which we are reverting here...