Removed TFWLiteSelector system

[Dr15Jones]

PR description:

This has not been actively used in over a decade

PR validation:

A search of CMSSW did not show up any dependencies.

resolves cms-sw/framework-team#1151

[Dr15Jones]

Please test

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47053/43201

• There are other open Pull requests which might conflict with changes you have proposed:
  • File FWCore/TFWLiteSelector/src/TFWLiteSelectorBasic.cc modified in PR(s): Moved construction of ProductResolvers to a separate function #47051

[cmsbuild]

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

• FWCore/TFWLiteSelector (core)
• FWCore/TFWLiteSelectorTest (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[makortel]

type -changes-dataformats

The removed classes_def.xml did not contain persistable classes.

[cmsbuild]

-1

Failed Tests: UnitTests
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e1e8c/43658/summary.html
COMMIT: 08108e5
CMSSW: CMSSW_15_0_X_2025-01-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47053/43658/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @mmusich Add BeamSpotCompatibilityChecker to all alignment offline validation configuration files #47044
• @mmusich add fillDescriptions to several more plugins in the reco area used at HLT (2/N) #47045
• @thomreis ECAL - Fix compilation issue with gcc13 #47046
• @makortel Add StreamID parameter to Transformer callback functions #47036
• @mmusich add fillDescriptions to a bunch of plugins in the EventFilter and Reco areas used at HLT (1/N) #47017
• @smuzaffar clang19 fix: template argument list is expected after a name prefixed #47019
• @martinamalberti MTD simulation: fix association tracking particle - MtdSimLayerCluster #47018

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e1e8c/43658/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e1e8c/43658/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 1 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3818730
• DQMHistoTests: Total failures: 850
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3817860
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 214 log files, 184 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[Dr15Jones]

The unit test failure is also in the IB.

[makortel]

Could you remove also

• FWCore/Skeletons/mkTemplates/TSelector directory
• FWCore/Skeletons/scripts/mktsel script
• These lines

  cmssw/FWCore/Skeletons/test/runtests.sh

  Lines 56 to 57 in 134545c

  	mktsel TestSelector -author "Test Author"
  	mktsel TestSelectorTrack example_track -author "Test Author"

• In principle also

  cmssw/FWCore/Skeletons/doc/man/skeletons.1

  Lines 61 to 62 in 134545c

  	.IP \(bu 2
  	\fBmktsel\fP generate code based on TSelector template

  although I'm not sure how up-to-date that manpage is
• This line

  cmssw/Utilities/ReleaseScripts/scripts/duplicateReflexLibrarySearch.py

  Line 74 in 134545c

  {'TFWLiteSelectorTest' : ['tfwliteselectortest']},

?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47053/43209

• There are other open Pull requests which might conflict with changes you have proposed:
  • File FWCore/TFWLiteSelector/src/TFWLiteSelectorBasic.cc modified in PR(s): Moved construction of ProductResolvers to a separate function #47051

[cmsbuild]

Pull request #47053 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

[Dr15Jones]

All requested changes should now be in

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47053/43212

• There are other open Pull requests which might conflict with changes you have proposed:
  • File FWCore/TFWLiteSelector/src/TFWLiteSelectorBasic.cc modified in PR(s): Moved construction of ProductResolvers to a separate function #47051
  • File Utilities/ReleaseScripts/scripts/duplicateReflexLibrarySearch.py modified in PR(s): Update lost dict def for EcalRecHitSoA #47048

[cmsbuild]

Pull request #47053 was updated. @Dr15Jones, @makortel, @smuzaffar can you please check and sign again.

[cmsbuild]

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e1e8c/43674/summary.html
COMMIT: e49a6fb
CMSSW: CMSSW_15_0_X_2025-01-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47053/43674/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3818730
• DQMHistoTests: Total failures: 451
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3818259
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 214 log files, 184 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[makortel]

Comparison differences are related to #39803 and #46416

[makortel]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1