-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BeamSpotCompatibilityChecker
to all alignment offline validation configuration files
#47044
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47044/43173 |
A new Pull Request was created by @mmusich for master. It involves the following packages:
@atpathak, @cmsbuild, @consuegs, @jfernan2, @mandrenguyen, @perrotta can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Size: This PR adds an extra 64KB to repository Comparison SummarySummary:
|
Alignment/OfflineValidation/python/TkAlAllInOneTool/DiMuonV_cfg.py
Outdated
Show resolved
Hide resolved
Alignment/OfflineValidation/python/TkAlAllInOneTool/JetHT_cfg.py
Outdated
Show resolved
Hide resolved
Alignment/OfflineValidation/python/TkAlAllInOneTool/SplitV_cfg.py
Outdated
Show resolved
Hide resolved
Alignment/OfflineValidation/python/TkAlAllInOneTool/Zmumu_cfg.py
Outdated
Show resolved
Hide resolved
Alignment/OfflineValidation/test/PrimaryVertexResolution_cfg.py
Outdated
Show resolved
Hide resolved
Alignment/OfflineValidation/test/PrimaryVertexResolution_templ_cfg.py
Outdated
Show resolved
Hide resolved
…ls where it is relevant and to several test configurations
1580c96
to
8f9313e
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47044/43183
|
@cmsbuild, please test |
+1 Size: This PR adds an extra 40KB to repository Comparison SummarySummary:
|
+alca
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
PR #45589 introduced
BeamSpotCompatibilityChecker
anedm::global::EDAnalyzer
designed to compare the Beam Spot payload in the Database with the one (potentially) available as a collection in the input data.This is useful when e.g. refitting tracks from file and using a
GlobalTag
(too much) different from the one used for the original processing. This would allow the user to catch the configuration mistake and correct it.As per internal discussion with the alignment conveners I add this module to all the the cmssw paths present in the configuration files related to the alignment offline validation package. This should allow to catch early on during the validation procedure if the configuration used for the validation is inconsistent (the users can still allow to use stale beam spot conditions via the all-in-one meta configuration language be it
yaml
orjson
).Unit tests of the package are changed in order to allow them to pass automatic execution. This is done as the generic autoCond keys were updated with respect to the one used to create the samples used for the tests. Keeping the
autoCond
entry makes the test fail (as expected as the Beam Spot in the GlobalTag is not the one used to process the input data).Finally commit 8f9313e adds the
offlineBeamSpot
collection to theTkAlZMuMu
andTkAlDiMuonAndVertex
data-tiers.This is useful in order to apply the same sort of checks also to the resonant di-muon based validations. The increase in data volume should be negligible.
PR validation:
scram b runtests
runs fine.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, could be backported if there is interest.
FYI: @henriettepetersen @TomasKello