Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BeamSpotCompatibilityChecker to all alignment offline validation configuration files #47044

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jan 6, 2025

PR description:

PR #45589 introduced BeamSpotCompatibilityChecker an edm::global::EDAnalyzer designed to compare the Beam Spot payload in the Database with the one (potentially) available as a collection in the input data.
This is useful when e.g. refitting tracks from file and using a GlobalTag (too much) different from the one used for the original processing. This would allow the user to catch the configuration mistake and correct it.
As per internal discussion with the alignment conveners I add this module to all the the cmssw paths present in the configuration files related to the alignment offline validation package. This should allow to catch early on during the validation procedure if the configuration used for the validation is inconsistent (the users can still allow to use stale beam spot conditions via the all-in-one meta configuration language be it yaml or json).
Unit tests of the package are changed in order to allow them to pass automatic execution. This is done as the generic autoCond keys were updated with respect to the one used to create the samples used for the tests. Keeping the autoCond entry makes the test fail (as expected as the Beam Spot in the GlobalTag is not the one used to process the input data).
Finally commit 8f9313e adds the offlineBeamSpot collection to the TkAlZMuMu and TkAlDiMuonAndVertex data-tiers.
This is useful in order to apply the same sort of checks also to the resonant di-muon based validations. The increase in data volume should be negligible.

PR validation:

scram b runtests runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, could be backported if there is interest.

FYI: @henriettepetersen @TomasKello

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2025

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Alignment/CommonAlignmentProducer (alca)
  • Alignment/OfflineValidation (alca)
  • RecoVertex/BeamSpotProducer (alca, reconstruction)

@atpathak, @cmsbuild, @consuegs, @jfernan2, @mandrenguyen, @perrotta can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @adewit, @dgulhan, @fabiocos, @francescobrivio, @martinamalberti, @missirol, @mmusich, @mtosi, @pakhotin, @rovere, @rsreds, @tlampen, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jan 6, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2025

+1

Size: This PR adds an extra 64KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f4d1e8/43629/summary.html
COMMIT: 1580c96
CMSSW: CMSSW_15_0_X_2025-01-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47044/43629/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47044/43183

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2025

Pull request #47044 was updated. @atpathak, @cmsbuild, @consuegs, @jfernan2, @mandrenguyen, @perrotta can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Jan 6, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2025

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f4d1e8/43641/summary.html
COMMIT: 8f9313e
CMSSW: CMSSW_15_0_X_2025-01-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47044/43641/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3931808
  • DQMHistoTests: Total failures: 458
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3931330
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Jan 6, 2025

+alca

  • I can't foresee any sizeable increase in the data size after adding the offlineBeamSpot collection to the TkAlZMuMu and TkAlDiMuonAndVertex data-tiers

@jfernan2
Copy link
Contributor

jfernan2 commented Jan 7, 2025

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d564c84 into cms-sw:master Jan 7, 2025
11 checks passed
@mmusich mmusich deleted the mm_dev_beamspot_checker branch January 7, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants