Era for UPC re-reco of 2016 pPb data #46087

stahlleiton · 2024-09-21T23:48:18Z

PR description:

This PR creates a new era "Run2_2016_UPC" meant for the re-reco of 2016 pPb data using the UPC reconstruction. It includes the same era modifiers (highBetaStar, egamma_lowPt_exclusive and run3_upc) introduced in #43378 on top of the Run2_2016 era.

A new relval 142.903 is added to test the new era.

More details on the validations done are documented in the slide

@mandrenguyen

PR validation:

Tested using the relvals 180,180.1,181,181.1,141.901,142.901,142.903

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR will be backported to 14_1_X.

cmsbuild · 2024-09-21T23:48:44Z

cms-bot internal usage

cmsbuild · 2024-09-21T23:52:35Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46087/41876

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Add 2024 FastSim workflow #46068
- File Configuration/StandardSequences/python/Eras.py modified in PR(s): Add run3 tracking low pu era #33532, Introduce era modifier run3_nanoAOD_pre142X #46066
- File RecoHI/HiTracking/python/HILowPtConformalPixelTracks_cfi.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076

cmsbuild · 2024-09-21T23:53:02Z

A new Pull Request was created by @stahlleiton for master.

It involves the following packages:

Configuration/Eras (operations)
Configuration/PyReleaseValidation (upgrade, pdmv)
Configuration/StandardSequences (operations)
RecoHI/HiTracking (reconstruction)
RecoTracker/IterativeTracking (reconstruction)

@AdrianoDee, @Moanwar, @antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @jfernan2, @kskovpen, @mandrenguyen, @miquork, @rappoccio, @srimanob, @subirsarkar, @sunilUIET can you please review it and eventually sign? Thanks.
@AnnikaStein, @GiacomoSguazzoni, @JanFSchulte, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @fabiocos, @felicepantaleo, @gpetruc, @jazzitup, @kurtejung, @makortel, @mandrenguyen, @missirol, @mmusich, @mtosi, @rovere, @sameasy, @slomeo, @yenjie, @yetkinyilmaz this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2024-09-23T06:06:27Z

Configuration/Eras/python/Era_Run2_2016_UPC_cff.py

+from Configuration.Eras.Modifier_highBetaStar_2018_cff import highBetaStar_2018
+from Configuration.Eras.Modifier_run3_upc_cff import run3_upc
+
+Run2_2016_UPC = cms.ModifierChain(Run2_2016, egamma_lowPt_exclusive, highBetaStar_2018, run3_upc)


Unrequested comment, from a non-reviewer. Perhaps these modifiers are generic enough to be renamed without directly referencing any data taking year? It is somewhat confusing to define a 2016 era with 2018 and run3 ingredients in it.

I could rename the era modifiers "highBetaStar_2018" into "highBetaStar", and "run3_upc" into "upc", if that helps

Changed the modifier "highBetaStar_2018" to "highBetaSta" in 5573b8f

cmsbuild · 2024-09-30T19:25:33Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46087/41957

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Add 2024 FastSim workflow #46068
- File Configuration/StandardSequences/python/Eras.py modified in PR(s): Add run3 tracking low pu era #33532, Boosted DeepTauID v2.0 #46112, Remove run3_nanoAOD_122 & 124 modifiers #46151
- File RecoHI/HiTracking/python/HILowPtConformalPixelTracks_cfi.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076

cmsbuild · 2024-09-30T19:25:57Z

Pull request #46087 was updated. @AdrianoDee, @Moanwar, @antoniovilela, @atpathak, @cmsbuild, @consuegs, @davidlange6, @fabiocos, @jfernan2, @kskovpen, @mandrenguyen, @miquork, @perrotta, @rappoccio, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again.

perrotta · 2024-10-01T09:17:01Z

Configuration/AlCa/python/autoCond.py

@@ -24,7 +24,7 @@
    # GlobalTag for MC production (p-Pb collisions) with realistic alignment and calibrations for Run2
    'run2_mc_pa'                   :    '131X_mcRun2_pA_v3',
    # GlobalTag for Run2 data reprocessing
-    'run2_data'                    :    '140X_dataRun2_v2',
+    'run2_data'                    :    '141X_dataRun2_v1',


Please replace with

Suggested change

'run2_data' : '141X_dataRun2_v1',

'run2_data' : '141X_dataRun2_v2',

(which contains the updated DeDxCalibration tag for the 2016 pA reReco, see https://cms-talk.web.cern.ch/t/gt-offline-prompt-update-of-dedxcalibration-tag-driven-from-2016-pa-data-for-141x-datarun2/50752/3)

Implemented in 5573b8f

cmsbuild · 2024-10-03T11:59:41Z

+1

Size: This PR adds an extra 104KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13c565/41904/summary.html
COMMIT: 5573b8f
CMSSW: CMSSW_14_2_X_2024-10-02-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46087/41904/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 22 differences found in the comparisons
DQMHistoTests: Total files compared: 45
DQMHistoTests: Total histograms compared: 3438002
DQMHistoTests: Total failures: 1694
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3436288
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
Checked 197 log files, 168 edm output root files, 45 DQM output files
TriggerResults: no differences found

perrotta · 2024-10-03T13:19:48Z

+alca

The new workflow 142.903 was tested running without errors in lxplus

jfernan2 · 2024-10-03T17:50:55Z

+1

stahlleiton · 2024-10-08T05:42:58Z

@cms-sw/upgrade-l2 @cms-sw/pdmv-l2 : would you kindly review/sign ?

Moanwar · 2024-10-08T08:13:01Z

+Upgrade

AdrianoDee · 2024-10-08T13:57:29Z

+pdmv

mandrenguyen · 2024-10-09T15:11:15Z

+1

cmsbuild · 2024-10-09T15:11:39Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

cmsbuild added this to the CMSSW_14_2_X milestone Sep 21, 2024

cmsbuild added reconstruction-pending operations-pending pending-signatures tests-pending orp-pending pdmv-pending upgrade-pending code-checks-pending tracking labels Sep 21, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 21, 2024

mmusich reviewed Sep 23, 2024

View reviewed changes

This was referenced Sep 24, 2024

Boosted DeepTauID v2.0 #46112

Merged

Remove run3_nanoAOD_122 & 124 modifiers #46151

Merged

stahlleiton force-pushed the Era_Run2_2016_UPC_CMSSW_14_2_X branch from 3542f83 to 8238ddb Compare September 30, 2024 19:24

cmsbuild added alca-pending code-checks-pending and removed code-checks-approved labels Sep 30, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 30, 2024

perrotta reviewed Oct 1, 2024

View reviewed changes

This was referenced Oct 1, 2024

Update Run3 data, Run3 2024 pp MC, Run3 2024 ppRef5TeV MC GTs in autoCond #46184

Merged

Move "hybrid" tau production from nano to mini step #46196

Merged

Implement Run2_2016_UPC era

5573b8f

cmsbuild added the tests-started label Oct 3, 2024

cmsbuild added tests-approved and removed tests-started labels Oct 3, 2024

cmsbuild added alca-approved and removed alca-pending labels Oct 3, 2024

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Oct 3, 2024

cmsbuild mentioned this pull request Oct 4, 2024

Updating phase2_realistic to point to 141X_mcRun4_realistic_v2 #46264

Merged

cmsbuild added upgrade-approved and removed upgrade-pending labels Oct 8, 2024

cmsbuild added pdmv-approved and removed pdmv-pending labels Oct 8, 2024

cmsbuild added operations-approved fully-signed orp-approved and removed operations-pending pending-signatures orp-pending labels Oct 9, 2024

cmsbuild merged commit b8676ee into cms-sw:master Oct 9, 2024
11 checks passed

cmsbuild mentioned this pull request Oct 9, 2024

Phase-2 mkFit: propagation to plane / Kalman operations on plane / Matriplex with support for scalar operations and VDT #46325

Merged

stahlleiton mentioned this pull request Oct 11, 2024

[14_1_X] Era for UPC re-reco of 2016 pPb data #46347

Merged

stahlleiton deleted the Era_Run2_2016_UPC_CMSSW_14_2_X branch October 12, 2024 11:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Era for UPC re-reco of 2016 pPb data #46087

Era for UPC re-reco of 2016 pPb data #46087

stahlleiton commented Sep 21, 2024 •

edited

Loading

cmsbuild commented Sep 21, 2024 •

edited

Loading

cmsbuild commented Sep 21, 2024

cmsbuild commented Sep 21, 2024

mmusich Sep 23, 2024 •

edited

Loading

stahlleiton Sep 23, 2024 •

edited

Loading

stahlleiton Oct 3, 2024

cmsbuild commented Sep 30, 2024

cmsbuild commented Sep 30, 2024

perrotta Oct 1, 2024

stahlleiton Oct 3, 2024

cmsbuild commented Oct 3, 2024

perrotta commented Oct 3, 2024

jfernan2 commented Oct 3, 2024

stahlleiton commented Oct 8, 2024

Moanwar commented Oct 8, 2024

AdrianoDee commented Oct 8, 2024

mandrenguyen commented Oct 9, 2024

cmsbuild commented Oct 9, 2024

	'run2_data' : '141X_dataRun2_v1',
	'run2_data' : '141X_dataRun2_v2',

Era for UPC re-reco of 2016 pPb data #46087

Era for UPC re-reco of 2016 pPb data #46087

Conversation

stahlleiton commented Sep 21, 2024 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Sep 21, 2024 • edited Loading

cmsbuild commented Sep 21, 2024

cmsbuild commented Sep 21, 2024

mmusich Sep 23, 2024 • edited Loading

Choose a reason for hiding this comment

stahlleiton Sep 23, 2024 • edited Loading

Choose a reason for hiding this comment

stahlleiton Oct 3, 2024

Choose a reason for hiding this comment

cmsbuild commented Sep 30, 2024

cmsbuild commented Sep 30, 2024

perrotta Oct 1, 2024

Choose a reason for hiding this comment

stahlleiton Oct 3, 2024

Choose a reason for hiding this comment

cmsbuild commented Oct 3, 2024

Comparison Summary

perrotta commented Oct 3, 2024

jfernan2 commented Oct 3, 2024

stahlleiton commented Oct 8, 2024

Moanwar commented Oct 8, 2024

AdrianoDee commented Oct 8, 2024

mandrenguyen commented Oct 9, 2024

cmsbuild commented Oct 9, 2024

stahlleiton commented Sep 21, 2024 •

edited

Loading

cmsbuild commented Sep 21, 2024 •

edited

Loading

mmusich Sep 23, 2024 •

edited

Loading

stahlleiton Sep 23, 2024 •

edited

Loading