Run3 era for 2023 PbPb UPC re-reco #43378

stahlleiton · 2023-11-23T22:31:35Z

PR description:

This PR creates a new era "Run3_2023_UPC" meant for the 2023 PbPb UPC re-reco. It includes the following changes on top of "Run3_2023":

High Beta Star (highBetaStar_2018) modifier: reduces min pt of tracks down to 0.05 GeV.
Light by light (egamma_lowPt_exclusive) modifier: reduces min et of electrons and photons down to 1 GeV
run3_upc modifier:
- Change pixelPairStepTrackingRegions.originRadius from 0.2 to 0.015 (see issue)
- Reduce min pt of lowPtGsfElectrons and hiPixelTracks down to 0.05 GeV.
- Filter on clusters as: # pixel clusters < 10000 and # strip clusters < 30000.
- Adds: hiPixelTracks, hiCentrality, hiClusterCompatibility, ZDC digis and miniAOD chi2 maps.
- Remove miniAOD selections for electrons, muons, dEdx, lost tracks and pf candidates.
- Set miniAOD min pt for slimmed calo jets to 5 GeV.

More details on the validations done are documented in the slide

@mandrenguyen

cmsbuild · 2023-11-23T22:39:33Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43378/37860

This PR adds an extra 60KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/StandardSequences/python/Eras.py modified in PR(s): Add run3 tracking low pu era #33532, Phase2 Trigger Primitive generation for Ecal Barrel #42633, Add Phase-2 workflow with Phase-2 ECal trigger primitive, also with ECal component #43057
- File PhysicsTools/PatAlgos/python/slimming/MicroEventContent_cff.py modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167
- File PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py modified in PR(s): Run3 HZZ electron ID #43369

cmsbuild · 2023-11-23T22:39:58Z

A new Pull Request was created by @stahlleiton (Andre Stahl) for master.

It involves the following packages:

Configuration/Eras (operations)
Configuration/StandardSequences (operations)
PhysicsTools/PatAlgos (reconstruction, xpog)
RecoEgamma/EgammaElectronProducers (reconstruction)
RecoHI/HiCentralityAlgos (reconstruction)
RecoHI/HiTracking (reconstruction)
RecoJets/Configuration (reconstruction)
RecoTracker/Configuration (reconstruction)
RecoTracker/IterativeTracking (reconstruction)
RecoTracker/TkSeedGenerator (reconstruction)

@mandrenguyen, @rappoccio, @antoniovilela, @fabiocos, @jfernan2, @simonepigazzini, @vlimant, @davidlange6, @cmsbuild can you please review it and eventually sign? Thanks.
@demuller, @kurtejung, @gkasieczka, @VinInn, @mtosi, @fabiocos, @Prasant1993, @mmusich, @ahinzmann, @missirol, @yenjie, @sobhatta, @andrzejnovak, @JanFSchulte, @sameasy, @schoef, @nhanvtran, @gpetruc, @AlexDeMoor, @makortel, @rovere, @mandrenguyen, @valsdav, @JyothsnaKomaragiri, @jdamgov, @seemasharmafnal, @mariadalfonso, @a-kapoor, @gouskos, @Sam-Harper, @jazzitup, @mbluj, @AnnikaStein, @azotz, @yetkinyilmaz, @VourMa, @rappoccio, @jainshilpi, @mmarionncern, @Ming-Yan, @emilbols, @ebrondol, @jdolen, @Martin-Grunewald, @varuns23, @lgray, @felicepantaleo, @clelange, @GiacomoSguazzoni, @dgulhan, @afiqaize, @ram1123, @hatakeyamak, @Senphy, @slomeo this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

slava77 · 2023-11-23T22:59:04Z

Configuration/Eras/python/Era_Run3_UPC_2023_cff.py

+from Configuration.Eras.Era_Run3_UPC_cff import Run3_UPC
+from Configuration.Eras.Modifier_run3_egamma_2023_cff import run3_egamma_2023
+
+Run3_UPC_2023 = cms.ModifierChain(Run3_UPC, run3_egamma_2023)


A large fraction of Eras are named RunX_YYYY_mod is it practical to create a bubble in the implementation of the pp era (here you re-implement the Run3 -> Run3_2023 detail). ... why do we need Run3_UPC?

Not needed at the moment, so I will remove Run3_UPC

slava77 · 2023-11-23T23:04:44Z

RecoEgamma/EgammaElectronProducers/python/lowPtGsfElectronSeeds_cfi.py

@@ -52,3 +52,6 @@ def thresholds( wp ) :

 from Configuration.ProcessModifiers.pp_on_AA_cff import pp_on_AA
 pp_on_AA.toModify(lowPtGsfElectronSeeds,MinPtThreshold = 5.0)
+
+from Configuration.Eras.Modifier_run3_upc_cff import run3_upc
+run3_upc.toModify(lowPtGsfElectronSeeds, ModelThresholds = thresholds("VL"), MinPtThreshold = 0.05)


shouldn't everything egamma just follow egamma_lowPt_exclusive modifier ?

Moved all the egamma related changes to egamma_lowPt_exclusive

slava77 · 2023-11-23T23:14:43Z

RecoTracker/IterativeTracking/python/PixelPairStep_cff.py

@@ -92,6 +92,8 @@
     originRadius = 0.2,
     fixedError   = 4.
 ))
+from Configuration.Eras.Modifier_highBetaStar_2023_cff import highBetaStar_2023
+highBetaStar_2023.toModify(pixelPairStepTrackingRegions,RegionPSet = dict(originRadius = 0.015))


I'd add a comment about the issue in the efficiency recovery; once that problem is addressed I expect that highBetaStar_2018 and highBetaStar_2023 will be identical.
It may even be more practical to use (highBetaStar_2018 & run3_upc) here.

IIRC, the only highBeta run in 2023 was after the BPIX problem appeared, but as I recall those fills had no pixel tracker readout. @sroychow @mmusich please check and correct me if I'm wrong

Changed to the approach suggested using "(highBetaStar_2018 & run3_upc)"

IIRC, the only highBeta run in 2023 was after the BPIX problem appeared, but as I recall those fills had no pixel tracker readout. @sroychow @mmusich please check and correct me if I'm wrong

based on OMS this year we had the fills in the interval 9095-9168 with non-nominal beta* (120cm). All of them happened in era >= Run2023E (which is after the pixel readout incident).
As far as I can tell in none of these fills either Pixel or Strip tracker was in global DAQ excepted fills 9095 and 9128.
But in any case I don't recall the Tier-0 being moved to the highBetaStar scenario.

once that problem is addressed I expect that highBetaStar_2018 and highBetaStar_2023 will be identical.

Incidentally (and certainly for outside of this particular PR), what's so intrinsically about 2018 of the highBetaStar_2018 modifier? Can't it just be highBetaStar (or highBetaStar_Phase1 to signal it applies to phase-1 tracking)?

highBetaStar_Phase1 makes sense

2018 is likely the first time it made it to the configs

slava77 · 2023-11-23T23:19:49Z

it would be nice to have a test workflow

stahlleiton · 2023-11-23T23:58:08Z

it would be nice to have a test workflow

Are there instructions on how to set up a test workflow? (never done it before)

cmsbuild · 2023-11-24T00:03:20Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43378/37864

This PR adds an extra 64KB to repository
Found files with invalid states:
- Configuration/Eras/python/Era_Run3_UPC_cff.py:
  - Added: 6d6a0c2
  - Deleted: 9e160a3
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/StandardSequences/python/Eras.py modified in PR(s): Add run3 tracking low pu era #33532, Phase2 Trigger Primitive generation for Ecal Barrel #42633, Add Phase-2 workflow with Phase-2 ECal trigger primitive, also with ECal component #43057
- File PhysicsTools/PatAlgos/python/slimming/MicroEventContent_cff.py modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167
- File PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py modified in PR(s): Run3 HZZ electron ID #43369

cmsbuild · 2023-11-24T00:03:46Z

Pull request #43378 was updated. @cmsbuild, @vlimant, @fabiocos, @davidlange6, @mandrenguyen, @simonepigazzini, @rappoccio, @jfernan2, @antoniovilela can you please check and sign again.

cmsbuild · 2023-11-24T00:11:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43378/37865

This PR adds an extra 64KB to repository
Found files with invalid states:
- Configuration/Eras/python/Era_Run3_UPC_cff.py:
  - Added: 6d6a0c2
  - Deleted: 9e160a3
- Configuration/Eras/python/Modifier_highBetaStar_2023_cff.py:
  - Added: 6d6a0c2
  - Deleted: 1ca0e39
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/StandardSequences/python/Eras.py modified in PR(s): Add run3 tracking low pu era #33532, Phase2 Trigger Primitive generation for Ecal Barrel #42633, Add Phase-2 workflow with Phase-2 ECal trigger primitive, also with ECal component #43057
- File PhysicsTools/PatAlgos/python/slimming/MicroEventContent_cff.py modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167
- File PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py modified in PR(s): Run3 HZZ electron ID #43369

cmsbuild · 2023-11-24T00:11:43Z

Pull request #43378 was updated. @vlimant, @fabiocos, @antoniovilela, @cmsbuild, @jfernan2, @rappoccio, @davidlange6, @simonepigazzini, @mandrenguyen can you please check and sign again.

makortel · 2023-12-04T14:54:20Z

Note that, there is a warning of L1 seed in the trigger menu. Is this expected, correct menu? It is just a warning. If this is confirmed, I will sign the PR. Thx.

that's unfortunately expected because the L1T people chose to hardcode the list of algorithms to monitor by L1TStage2uGTTiming here:

cmssw/DQM/L1TMonitor/python/L1TStage2uGTTiming_cfi.py

Lines 12 to 23 in 6edd3ed

"L1_SingleMu22_BMTF",

"L1_SingleMu22_OMTF",

"L1_SingleMu22_EMTF",

"L1_SingleIsoEG28er1p5",

"L1_SingleIsoEG32er2p5",

"L1_SingleEG40er2p5",

"L1_SingleEG60",

"L1_SingleTau120er2p1",

"L1_SingleJet180",

"L1_ETMHF130",

"L1_HTT360er",

"L1_ETT2000"

this - of course - becomes frequently bogus (whenever the list of algos in the L1T menu changes). We already complained (and gave suggestions here ).

Would it be worth of opening an issue about these?

mmusich · 2023-12-04T15:11:01Z

Would it be worth of opening an issue about these?

here it is: #43488

stahlleiton · 2023-12-05T06:38:17Z

Thanks for the feedback.
@cms-sw/pdmv-l2 and @cms-sw/xpog-l2: Is the PR fine to be approved?

stahlleiton · 2023-12-05T22:57:59Z

@sunilUIET , @AdrianoDee , @simonepigazzini , @vlimant : Can you please sign this PR?

mandrenguyen · 2023-12-07T07:47:07Z

@cms-sw/xpog-l2 @cms-sw/pdmv-l2 would you kindly review/sign ?

AdrianoDee · 2023-12-07T09:26:58Z

+pdmv

stahlleiton · 2023-12-11T07:54:46Z

@cms-sw/xpog-l2 please review/sign this PR

vlimant · 2023-12-11T08:17:29Z

+1

antoniovilela · 2023-12-12T15:35:46Z

+1

cmsbuild · 2023-12-12T15:36:08Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

cmsbuild added this to the CMSSW_14_0_X milestone Nov 23, 2023

cmsbuild added reconstruction-pending operations-pending pending-signatures tests-pending orp-pending code-checks-pending xpog-pending tracking labels Nov 23, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 23, 2023

slava77 reviewed Nov 23, 2023

View reviewed changes

cmsbuild added code-checks-pending and removed code-checks-approved labels Nov 23, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 24, 2023

cmsbuild added code-checks-pending and removed code-checks-approved labels Nov 24, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 24, 2023

cmsbuild added upgrade-approved and removed upgrade-pending labels Dec 4, 2023

mmusich mentioned this pull request Dec 4, 2023

hardcoded list of L1T algorithms to monitor in L1TStage2uGTTiming #43488

Open

cmsbuild added pdmv-approved and removed pdmv-pending labels Dec 7, 2023

This was referenced Dec 7, 2023

[13_2_X] Run3 era for 2023 PbPb UPC re-reco #43520

Merged

[13_3_X] Run3 era for 2023 PbPb UPC re-reco #43521

Merged

cmsbuild added xpog-approved and removed xpog-pending labels Dec 11, 2023

cmsbuild added operations-approved fully-signed orp-approved and removed operations-pending pending-signatures orp-pending labels Dec 12, 2023

cmsbuild merged commit 57ef48a into cms-sw:master Dec 12, 2023

cmsbuild mentioned this pull request Dec 12, 2023

MTD geometry: add BTL V3 (one crystal thickness only) to MTD scenario I17 (global scenario D105) #43553

Merged

stahlleiton deleted the Era_Run3_UPC_2023_CMSSW_14_0_X branch December 13, 2023 00:50

cmsbuild mentioned this pull request Dec 13, 2023

[Geant4] Update to 11.2.0 for G4VecGeom IBs cms-sw/cmsdist#8878

Merged

stahlleiton mentioned this pull request Sep 21, 2024

Era for UPC re-reco of 2016 pPb data #46087

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3 era for 2023 PbPb UPC re-reco #43378

Run3 era for 2023 PbPb UPC re-reco #43378

stahlleiton commented Nov 23, 2023 •

edited

Loading

cmsbuild commented Nov 23, 2023

cmsbuild commented Nov 23, 2023 •

edited

Loading

slava77 Nov 23, 2023

stahlleiton Nov 23, 2023

slava77 Nov 23, 2023

stahlleiton Nov 24, 2023

slava77 Nov 23, 2023

stahlleiton Nov 24, 2023

mmusich Nov 24, 2023

mmusich Nov 24, 2023

slava77 Nov 24, 2023

slava77 commented Nov 23, 2023

stahlleiton commented Nov 23, 2023 •

edited

Loading

cmsbuild commented Nov 24, 2023

cmsbuild commented Nov 24, 2023

cmsbuild commented Nov 24, 2023

cmsbuild commented Nov 24, 2023

makortel commented Dec 4, 2023

mmusich commented Dec 4, 2023

stahlleiton commented Dec 5, 2023

stahlleiton commented Dec 5, 2023

mandrenguyen commented Dec 7, 2023

AdrianoDee commented Dec 7, 2023

stahlleiton commented Dec 11, 2023

vlimant commented Dec 11, 2023

antoniovilela commented Dec 12, 2023

cmsbuild commented Dec 12, 2023

Run3 era for 2023 PbPb UPC re-reco #43378

Run3 era for 2023 PbPb UPC re-reco #43378

Conversation

stahlleiton commented Nov 23, 2023 • edited Loading

PR description:

cmsbuild commented Nov 23, 2023

cmsbuild commented Nov 23, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

slava77 commented Nov 23, 2023

stahlleiton commented Nov 23, 2023 • edited Loading

cmsbuild commented Nov 24, 2023

cmsbuild commented Nov 24, 2023

cmsbuild commented Nov 24, 2023

cmsbuild commented Nov 24, 2023

makortel commented Dec 4, 2023

mmusich commented Dec 4, 2023

stahlleiton commented Dec 5, 2023

stahlleiton commented Dec 5, 2023

mandrenguyen commented Dec 7, 2023

AdrianoDee commented Dec 7, 2023

stahlleiton commented Dec 11, 2023

vlimant commented Dec 11, 2023

antoniovilela commented Dec 12, 2023

cmsbuild commented Dec 12, 2023

stahlleiton commented Nov 23, 2023 •

edited

Loading

cmsbuild commented Nov 23, 2023 •

edited

Loading

stahlleiton commented Nov 23, 2023 •

edited

Loading