Added more ZDC functionality to DQM #45948

JoshPBR2 · 2024-09-06T20:23:54Z

PR description:

This is a clone of the PR linked here with the correct cmssw repo upstream.

PR validation:

Workarounds are still needed to test, as ZDC geometry is still an issue (here)

This PR will require backporting to 14_1_X as it is needed for heavy-ion data taking.

@hjbossi

cmsbuild · 2024-09-06T20:24:21Z

cms-bot internal usage

cmsbuild · 2024-09-06T20:27:53Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45948/41708

cmsbuild · 2024-09-06T20:28:14Z

A new Pull Request was created by @JoshPBR2 for master.

It involves the following packages:

DQM/HcalTasks (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@DryRun, @abdoulline, @bsunanda, @denizsun, @salimcerci this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mandrenguyen · 2024-09-06T21:44:57Z

"This PR will not require any back ports and is intended for heavy-ion data taking."
If it's intended for data taking it will need to be backported to 14_1_X. We're in 14_2_X now.

hjbossi · 2024-09-06T22:12:14Z

@JoshPBR2 can you update the header please?

hjbossi

Thanks @JoshPBR2 ! I left some quick comments. My understanding is that this PR would include the emulator and we would handle the geometry issues separately, but this seems to have it commented out? Let me know if I am missing something!

hjbossi · 2024-09-06T22:12:59Z

DQM/HcalTasks/plugins/ZDCQIE10Task.cc

 }
+//std::shared_ptr<hcaldqm::Cache> ZDCQIE10Task::globalBeginLuminosityBlock(edm::LuminosityBlock const& lb,


Are these comments here for a reason? otherwise we can probably remove.

Going through each comment for completeness - this was addressed in eff9cc2

hjbossi · 2024-09-06T22:13:43Z

DQM/HcalTasks/plugins/ZDCQIE10Task.cc

+    //cout << " ZDC did" <<did()<<endl;
+    uint32_t rawid = _ehashmap.lookup(did);
+
+    if (rawid == 0) {


There are some empty if statements in this code, unless it is being used for something we should remove.

hjbossi · 2024-09-06T22:13:54Z

DQM/HcalTasks/plugins/ZDCQIE10Task.cc

+    myNoiseTS = myParams->noiseTS();
+
+    for (unsigned int k : mySignalTS) {
+      std::cout << k << ' ';


Is this meant for testing?

This was removed in eff9cc2

hjbossi · 2024-09-06T22:14:40Z

DQM/HcalTasks/plugins/ZDCQIE10Task.cc

+  edm::Handle<BXVector<l1t::EtSum> > sums;
+  e.getByToken(sumToken_, sums);
+
+  //int startBX = sums->getFirstBX();


My understanding would be that this PR would have the emulated information. Why is this commented out?

This is restored as part of eff9cc2

hjbossi · 2024-09-09T18:39:53Z

For some reason when I click on the "Details" link next to the runTheMatrix output, I get an error. Is this the case for others or just on my end? It might be expected that this PR fails the runTheMatrix output for components dependent on the geometry, but it is difficult to tell without being able to see the error...

hjbossi · 2024-09-09T18:41:01Z

@JoshPBR2 can you update the header please?

I see the header is now updated!

mandrenguyen · 2024-09-09T18:51:07Z

please test

cmsbuild · 2024-09-09T22:01:07Z

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-741cdf/41420/summary.html
COMMIT: 37a743a
CMSSW: CMSSW_14_2_X_2024-09-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45948/41420/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 175 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3331158
DQMHistoTests: Total failures: 1577
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3329561
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 193 log files, 163 edm output root files, 44 DQM output files
TriggerResults: no differences found

mandrenguyen · 2024-09-11T05:37:49Z

@JoshPBR2 Please clean up code following Hannah's suggestions.
@cms-sw/dqm-l2 Can you please have a look?

antoniovagnerini · 2024-09-12T15:23:37Z

DQM/HcalTasks/interface/ZDCQIE10Task.h

+#include "DQM/HcalCommon/interface/DQTask.h"
+#include "DQM/HcalCommon/interface/Utilities.h"
+#include "DQM/HcalCommon/interface/HashFilter.h"
+#include "DQM/HcalCommon/interface/ElectronicsMap.h"


Remove the duplicated #include "DQM/HcalCommon/interface/ElectronicsMap.h".

Going thru all comments for completeness - this was done as part of eff9cc2

cmsbuild · 2024-09-13T16:11:55Z

Pull request #45948 was updated. @antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

cmsbuild · 2024-09-13T16:22:12Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45948/41779

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45948/41779/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45948/41779/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

antoniovagnerini · 2024-09-15T17:25:57Z

@JoshPBR2 After fixing the indentation issue as suggested in the patch above, could you also remove the remaining commented-out lines with the print statements? In general, std::cout is not allowed and the CMS MessageLogger is used instead, as the latter is designed to be thread-safe.

antoniovagnerini · 2024-09-15T17:27:32Z

DQM/HcalTasks/plugins/ZDCQIE10Task.cc

    for (int i = 0; i < digi.samples(); i++) {
+      //cout << " zside()    " << did.zside() <<endl;


remove line

cmsbuild · 2024-09-18T16:27:25Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45948/41835

cmsbuild · 2024-09-18T16:27:49Z

Pull request #45948 was updated. @antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

mandrenguyen · 2024-09-18T19:12:49Z

please test

cmsbuild · 2024-09-18T19:24:11Z

-1

Failed Tests: Build ClangBuild
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-741cdf/41598/summary.html
COMMIT: a712b2b
CMSSW: CMSSW_14_2_X_2024-09-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45948/41598/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin src/DQM/HcalTasks/plugins/ZDCQIE10Task.cc
>> Compiling edm plugin src/DQM/HcalTasks/plugins/ZDCTask.cc
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -D__STDC_LIMIT_MACROS -D__STDC_FORMAT_MACROS -DDD4HEP_USE_GEANT4_UNITS=1 -DCMSSW_GIT_HASH='CMSSW_14_2_X_2024-09-18-1100' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_14_2_X_2024-09-18-1100' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-09-18-1100/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/cms/coral/CORAL_2_3_21-2e6a52c24df3897c0388721417aff9df/include/LCG -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/dd4hep/v01-29-00-72e61189ceef14e8db0f50d3b9434ade/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/alpaka/1.1.0-4d4f1220bfca9be4c4149ab758d15463/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/classlib/3.1.3-c6b100380ee001a2bc06975bb0682ffc/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/onnxruntime/1.17.1-a92a94798297a38c4645dea87bce94c5/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/cudnn/8.9.7.29-dc47fff5da99a711530b313658ea643e/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/pcre/8.43-e34796d17981e9b6d174328c69446455/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/boost/1.80.0-7ac88d918a6883d593abc133ee0eb2e9/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/clhep/2.4.7.1-17c7283747b6cbc68a3534cb987a890c/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/cuda/12.4.1-fc5cb0e72dba64b6abbf00089f3a044c/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/curl/7.79.0-abae79fca02c8e83ab0f428f2a91d96b/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/gsl/2.6-4e597de26ced42091883404fa44cef2e/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/protobuf/3.21.9-cceae2b21362e2ebbf12522a68c60cb1/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/lcg/root/6.30.09-5371975256c236eab45164692fccb0e2/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/tbb/v2021.9.0-2391c941213c757dc9a1835b31681235/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/xerces-c/3.1.3-c7b88eaa36d0408120f3c29826a04bf6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/zlib/1.2.11-1a082fc322b0051b504cc023f21df178/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-39786ff94f8aa2f543922cad720e1b32/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-39786ff94f8aa2f543922cad720e1b32/include/eigen3 -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/fmt/10.2.1-deba157dd76fed17ac8b42adc60ff53f/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/OpenBLAS/0.3.27-6574458f8642b299ac965c654e194a8b/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/re2/2021-06-01-5f6cd7de45dd7b7e3aae466a74a3a0b6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/tinyxml2/6.2.0-68d511689c5dbd9a0d296bbb795fa052/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v2 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc12/src/DQM/HcalTasks/plugins/DQMHcalTasksAuto/ZDCTask.cc.d src/DQM/HcalTasks/plugins/ZDCTask.cc -o tmp/el8_amd64_gcc12/src/DQM/HcalTasks/plugins/DQMHcalTasksAuto/ZDCTask.cc.o
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -D__STDC_LIMIT_MACROS -D__STDC_FORMAT_MACROS -DDD4HEP_USE_GEANT4_UNITS=1 -DCMSSW_GIT_HASH='CMSSW_14_2_X_2024-09-18-1100' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_14_2_X_2024-09-18-1100' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-09-18-1100/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/cms/coral/CORAL_2_3_21-2e6a52c24df3897c0388721417aff9df/include/LCG -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/dd4hep/v01-29-00-72e61189ceef14e8db0f50d3b9434ade/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/alpaka/1.1.0-4d4f1220bfca9be4c4149ab758d15463/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/classlib/3.1.3-c6b100380ee001a2bc06975bb0682ffc/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/onnxruntime/1.17.1-a92a94798297a38c4645dea87bce94c5/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/cudnn/8.9.7.29-dc47fff5da99a711530b313658ea643e/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/pcre/8.43-e34796d17981e9b6d174328c69446455/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/boost/1.80.0-7ac88d918a6883d593abc133ee0eb2e9/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/clhep/2.4.7.1-17c7283747b6cbc68a3534cb987a890c/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/cuda/12.4.1-fc5cb0e72dba64b6abbf00089f3a044c/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/curl/7.79.0-abae79fca02c8e83ab0f428f2a91d96b/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/gsl/2.6-4e597de26ced42091883404fa44cef2e/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/protobuf/3.21.9-cceae2b21362e2ebbf12522a68c60cb1/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/lcg/root/6.30.09-5371975256c236eab45164692fccb0e2/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/tbb/v2021.9.0-2391c941213c757dc9a1835b31681235/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/xerces-c/3.1.3-c7b88eaa36d0408120f3c29826a04bf6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/zlib/1.2.11-1a082fc322b0051b504cc023f21df178/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-39786ff94f8aa2f543922cad720e1b32/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-39786ff94f8aa2f543922cad720e1b32/include/eigen3 -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/fmt/10.2.1-deba157dd76fed17ac8b42adc60ff53f/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/OpenBLAS/0.3.27-6574458f8642b299ac965c654e194a8b/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/re2/2021-06-01-5f6cd7de45dd7b7e3aae466a74a3a0b6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02855/el8_amd64_gcc12/external/tinyxml2/6.2.0-68d511689c5dbd9a0d296bbb795fa052/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v2 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc12/src/DQM/HcalTasks/plugins/DQMHcalTasksAuto/ZDCQIE10Task.cc.d src/DQM/HcalTasks/plugins/ZDCQIE10Task.cc -o tmp/el8_amd64_gcc12/src/DQM/HcalTasks/plugins/DQMHcalTasksAuto/ZDCQIE10Task.cc.o
src/DQM/HcalTasks/plugins/ZDCQIE10Task.cc: In member function 'virtual void ZDCQIE10Task::_process(const edm::Event&, const edm::EventSetup&)':
src/DQM/HcalTasks/plugins/ZDCQIE10Task.cc:399:9: error: 'etSumZdcP_' was not declared in this scope
  399 |         etSumZdcP_[ibx - startBX] = itr->hwPt();
      |         ^~~~~~~~~~
src/DQM/HcalTasks/plugins/ZDCQIE10Task.cc:401:9: error: 'etSumZdcM_' was not declared in this scope
  401 |         etSumZdcM_[ibx - startBX] = itr->hwPt();
      |         ^~~~~~~~~~

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Local Products Rules ..... started
>> Local Products Rules ..... done
>> Creating project symlinks
>> Entering Package DQM/HcalTasks
>> Compile sequence completed for CMSSW CMSSW_14_2_X_2024-09-18-1100
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_2_X_2024-09-18-1100/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package DQM/HcalTasks
Entering library rule at src/DQM/HcalTasks/plugins
>> Compiling edm plugin src/DQM/HcalTasks/plugins/DigiTask.cc

antoniovagnerini · 2024-09-24T07:27:17Z

hi @JoshPBR2 , could you please have a look and fix the compilation error above ?

mmusich · 2024-09-25T12:48:46Z

@JoshPBR2 is this for online or offline DQM?

hjbossi · 2024-09-29T19:24:10Z

Ideally, this change would be for both. We're still waiting on @JoshPBR2 to address the comments then we will see what is possible. Josh, do you mind having a look at this?

mmusich · 2024-09-29T19:55:28Z

test parameters:

addpkg = DQM/Integration

Joshua Bistany-Riebman added 5 commits July 24, 2024 15:54

Added more ZDC functionality to DQM

33ebd74

applied code formatting

399191e

now using already implemented adc2fc table

4b1aedc

code formatting

97debf4

Fixed typos

37a743a

cmsbuild added this to the CMSSW_14_2_X milestone Sep 6, 2024

cmsbuild added dqm-pending pending-signatures tests-pending orp-pending code-checks-pending labels Sep 6, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 6, 2024

hjbossi mentioned this pull request Sep 6, 2024

Added more ZDC functionality to DQM #45544

Closed

hjbossi reviewed Sep 6, 2024

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Sep 9, 2024

cmsbuild added tests-approved and removed tests-started labels Sep 9, 2024

antoniovagnerini reviewed Sep 12, 2024

View reviewed changes

Addressed comments

eff9cc2

cmsbuild added code-checks-pending and removed code-checks-approved labels Sep 13, 2024

cmsbuild added code-checks-rejected and removed code-checks-pending labels Sep 13, 2024

antoniovagnerini reviewed Sep 15, 2024

View reviewed changes

code patches

a712b2b

cmsbuild added code-checks-pending and removed code-checks-rejected labels Sep 18, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 18, 2024

cmsbuild added tests-started and removed tests-pending labels Sep 18, 2024

cmsbuild added tests-rejected and removed tests-started labels Sep 18, 2024

hjbossi mentioned this pull request Sep 19, 2024

Bookkeeping of issues impacted by ZDC Geometry #45530

Open

cfmcginn mentioned this pull request Oct 16, 2024

[14_1_X] Added more ZDC functionality to DQM #46407

Merged

mandrenguyen closed this Oct 22, 2024

cfmcginn mentioned this pull request Oct 22, 2024

Added more ZDC functionality to DQM #46478

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added more ZDC functionality to DQM #45948

Added more ZDC functionality to DQM #45948

JoshPBR2 commented Sep 6, 2024 •

edited

Loading

cmsbuild commented Sep 6, 2024 •

edited

Loading

cmsbuild commented Sep 6, 2024

cmsbuild commented Sep 6, 2024

mandrenguyen commented Sep 6, 2024

hjbossi commented Sep 6, 2024

hjbossi left a comment

hjbossi Sep 6, 2024

cfmcginn Oct 11, 2024

hjbossi Sep 6, 2024

hjbossi Sep 6, 2024

cfmcginn Oct 11, 2024

hjbossi Sep 6, 2024

cfmcginn Oct 11, 2024

hjbossi commented Sep 9, 2024

hjbossi commented Sep 9, 2024

mandrenguyen commented Sep 9, 2024

cmsbuild commented Sep 9, 2024

mandrenguyen commented Sep 11, 2024

antoniovagnerini Sep 12, 2024

cfmcginn Oct 11, 2024

cmsbuild commented Sep 13, 2024

cmsbuild commented Sep 13, 2024

antoniovagnerini commented Sep 15, 2024

antoniovagnerini Sep 15, 2024

cmsbuild commented Sep 18, 2024

cmsbuild commented Sep 18, 2024

mandrenguyen commented Sep 18, 2024

cmsbuild commented Sep 18, 2024

antoniovagnerini commented Sep 24, 2024

mmusich commented Sep 25, 2024

hjbossi commented Sep 29, 2024

mmusich commented Sep 29, 2024

		}
		//std::shared_ptr<hcaldqm::Cache> ZDCQIE10Task::globalBeginLuminosityBlock(edm::LuminosityBlock const& lb,

		for (int i = 0; i < digi.samples(); i++) {
		//cout << " zside() " << did.zside() <<endl;

Added more ZDC functionality to DQM #45948

Added more ZDC functionality to DQM #45948

Conversation

JoshPBR2 commented Sep 6, 2024 • edited Loading

PR description:

PR validation:

cmsbuild commented Sep 6, 2024 • edited Loading

cmsbuild commented Sep 6, 2024

cmsbuild commented Sep 6, 2024

mandrenguyen commented Sep 6, 2024

hjbossi commented Sep 6, 2024

hjbossi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hjbossi commented Sep 9, 2024

hjbossi commented Sep 9, 2024

mandrenguyen commented Sep 9, 2024

cmsbuild commented Sep 9, 2024

Comparison Summary

mandrenguyen commented Sep 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented Sep 13, 2024

cmsbuild commented Sep 13, 2024

antoniovagnerini commented Sep 15, 2024

Choose a reason for hiding this comment

cmsbuild commented Sep 18, 2024

cmsbuild commented Sep 18, 2024

mandrenguyen commented Sep 18, 2024

cmsbuild commented Sep 18, 2024

Build

Clang Build

antoniovagnerini commented Sep 24, 2024

mmusich commented Sep 25, 2024

hjbossi commented Sep 29, 2024

mmusich commented Sep 29, 2024

JoshPBR2 commented Sep 6, 2024 •

edited

Loading

cmsbuild commented Sep 6, 2024 •

edited

Loading