Added more ZDC functionality to DQM #45544

JoshPBR2 · 2024-07-24T14:46:08Z

PR description:

This PR adds additional DQM tools for the ZDC including

Timing plots
TDC plots
Sum plots
Emulator plots to be added

PR validation:

To test this PR a number of workarounds are needed as this PR is dependent on the ZDC geometry. see issue

To test

cmsrel CMSSW_14_1_0_pre5 cd CMSSW_14_1_0_pre5/src cmsenv git cms-merge-topic matt2275:Test_ZDCRecHit scram b -j8

Grab conditions here

This PR will not require any back ports and is intended for heavy-ion data taking.

@salimcerci

cmsbuild · 2024-07-24T14:46:32Z

cms-bot internal usage

cmsbuild · 2024-07-24T14:50:20Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45544/41020

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45544/41020/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45544/41020/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2024-07-24T15:08:09Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45544/41022

cmsbuild · 2024-07-24T15:08:32Z

A new Pull Request was created by @JoshPBR2 for master.

It involves the following packages:

DQM/HcalTasks (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@DryRun, @abdoulline, @bsunanda this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

abdoulline · 2024-07-24T15:46:03Z

@JoshPBR2
just wonder if you need (so) high precision conversion ADC -> fC ?
as there is already QIE10 generic/simplified table used for HF:
https://cmssdt.cern.ch/lxr/source/DQM/HcalCommon/interface/Constants.h#0258

e.g. ->
https://cmssdt.cern.ch/lxr/source/DQM/HcalCommon/interface/Utilities.h#0095

cmsbuild · 2024-07-24T16:05:44Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45544/41028

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45544/41028/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45544/41028/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

JoshPBR2 · 2024-07-24T16:08:20Z

@abdoulline
I pushed a new version now using the already implemented table. Don't think having the high precision one is of much use.

cmsbuild · 2024-08-21T09:32:33Z

-1

Failed Tests: UnitTests RelVals-INPUT
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-179a28/41044/summary.html
COMMIT: 37a743a
CMSSW: CMSSW_14_1_X_2024-08-20-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45544/41044/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 2 errors in the following unit tests:

---> test test_MC_22_setup had ERRORS
---> test test_MC_23_setup had ERRORS

RelVals-INPUT

2024.31012024.3101_RunParkingLLP2024E_1M/step1_dasquery.log
2024.3101DAS Error

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 154 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3324622
DQMHistoTests: Total failures: 5389
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3319213
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 191 log files, 161 edm output root files, 44 DQM output files
TriggerResults: no differences found

cmsbuild · 2024-08-21T16:05:46Z

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-179a28/41055/summary.html
COMMIT: 37a743a
CMSSW: CMSSW_14_1_X_2024-08-21-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45544/41055/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

2024.3030052024.303005_RunHcalNZS2024E_50k/step1_dasquery.log
2024.303005DAS Error

Comparison Summary

Summary:

You potentially removed 4 lines from the logs
Reco comparison results: 9 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3324622
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3324596
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 191 log files, 161 edm output root files, 44 DQM output files
TriggerResults: no differences found

tjavaid · 2024-08-22T03:21:54Z

please test

cmsbuild · 2024-08-23T08:28:32Z

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-179a28/41074/summary.html
COMMIT: 37a743a
CMSSW: CMSSW_14_1_X_2024-08-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45544/41074/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

2024.40912024.4091_RunParkingHH2024F_1M/step1_dasquery.log
2024.410052024.41005_RunParkingLLP2024F_500k/step1_dasquery.log
2024.41012024.4101_RunParkingLLP2024F_1M/step1_dasquery.log

Expand to see more relval errors ...

2024.41105
2024.4111
2024.41205
2024.4121
2024.4091
2024.41005
2024.4101
2024.41105
2024.4111
2024.41205
2024.4121

Comparison Summary

Summary:

You potentially added 3 lines to the logs
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3328166
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3328143
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 191 log files, 161 edm output root files, 44 DQM output files
TriggerResults: no differences found

tjavaid · 2024-08-23T08:36:23Z

@JoshPBR2 , It seems to be based on a different fork from cmssw called CmsHI/cmssw :

This branch is 51041 commits ahead of, 586 commits behind CmsHI/cmssw:forest_CMSSW_10_3_1

Would you prefer to take a recent cmssw ? (just for smooth merging)

abdoulline · 2024-08-24T04:49:15Z

FYI @denizsun @salimcerci

abdoulline · 2024-08-24T05:23:29Z

@salimcerci
now see that you were included in the PR notifications at the very beginning by Joshua.

cmsbuild · 2024-08-27T08:10:06Z

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

antoniovilela · 2024-09-03T09:31:46Z

ping (to make bot change milestone)

hjbossi · 2024-09-06T21:41:45Z

For all following this PR, it is now moved to: #45948 @abdoulline @mandrenguyen @denizsun @salimcerci

Added more ZDC functionality to DQM

33ebd74

cmsbuild added this to the CMSSW_14_1_X milestone Jul 24, 2024

cmsbuild added dqm-pending pending-signatures tests-pending orp-pending code-checks-pending labels Jul 24, 2024

hjbossi mentioned this pull request Jul 24, 2024

Bookkeeping of issues impacted by ZDC Geometry #45530

Open

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jul 24, 2024

applied code formatting

399191e

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jul 24, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 24, 2024

now using already implemented adc2fc table

4b1aedc

cmsbuild added code-checks-pending and removed code-checks-approved labels Jul 24, 2024

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jul 24, 2024

code formatting

97debf4

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jul 24, 2024

cmsbuild added the tests-started label Aug 21, 2024

cmsbuild added tests-rejected tests-started and removed tests-started tests-rejected labels Aug 21, 2024

cmsbuild added tests-rejected and removed tests-started labels Aug 21, 2024

cmsbuild added tests-started and removed tests-rejected labels Aug 22, 2024

cmsbuild added tests-rejected and removed tests-started labels Aug 23, 2024

cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Aug 27, 2024

cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Sep 3, 2024

JoshPBR2 closed this by deleting the head repository Sep 6, 2024

JoshPBR2 mentioned this pull request Sep 6, 2024

Added more ZDC functionality to DQM #45948

Closed

nothingface0 mentioned this pull request Nov 29, 2024

Added cherry-pick functionality to cmssw_deploy cms-DQM/fff_dqmtools#21

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added more ZDC functionality to DQM #45544

Added more ZDC functionality to DQM #45544

JoshPBR2 commented Jul 24, 2024

cmsbuild commented Jul 24, 2024 •

edited

Loading

cmsbuild commented Jul 24, 2024

cmsbuild commented Jul 24, 2024

cmsbuild commented Jul 24, 2024

abdoulline commented Jul 24, 2024 •

edited

Loading

cmsbuild commented Jul 24, 2024

JoshPBR2 commented Jul 24, 2024

cmsbuild commented Aug 21, 2024

cmsbuild commented Aug 21, 2024

tjavaid commented Aug 22, 2024

cmsbuild commented Aug 23, 2024

tjavaid commented Aug 23, 2024 •

edited

Loading

abdoulline commented Aug 24, 2024 •

edited

Loading

abdoulline commented Aug 24, 2024

cmsbuild commented Aug 27, 2024

antoniovilela commented Sep 3, 2024

hjbossi commented Sep 6, 2024 •

edited

Loading

Added more ZDC functionality to DQM #45544

Added more ZDC functionality to DQM #45544

Conversation

JoshPBR2 commented Jul 24, 2024

PR description:

PR validation:

cmsbuild commented Jul 24, 2024 • edited Loading

cmsbuild commented Jul 24, 2024

cmsbuild commented Jul 24, 2024

cmsbuild commented Jul 24, 2024

abdoulline commented Jul 24, 2024 • edited Loading

cmsbuild commented Jul 24, 2024

JoshPBR2 commented Jul 24, 2024

cmsbuild commented Aug 21, 2024

Unit Tests

RelVals-INPUT

Comparison Summary

cmsbuild commented Aug 21, 2024

RelVals-INPUT

Comparison Summary

tjavaid commented Aug 22, 2024

cmsbuild commented Aug 23, 2024

RelVals-INPUT

Comparison Summary

tjavaid commented Aug 23, 2024 • edited Loading

abdoulline commented Aug 24, 2024 • edited Loading

abdoulline commented Aug 24, 2024

cmsbuild commented Aug 27, 2024

antoniovilela commented Sep 3, 2024

hjbossi commented Sep 6, 2024 • edited Loading

cmsbuild commented Jul 24, 2024 •

edited

Loading

abdoulline commented Jul 24, 2024 •

edited

Loading

tjavaid commented Aug 23, 2024 •

edited

Loading

abdoulline commented Aug 24, 2024 •

edited

Loading

hjbossi commented Sep 6, 2024 •

edited

Loading