Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Adding GEM onlineDQM trigger primitive plots #45541

Merged

Conversation

Dongwoon77
Copy link
Contributor

PR description:

In this PR, GEM onlineDQM plots for trigger primitive have been implemented.

This is a backport of #45489 to 14_0_X.

PR validation:

Tests are done with cmsRun $CMSSW_BASE/src/DQM/Integration/python/clients/gem_dqm_sourceclient-live_cfg.py unitTest=True runNumber=379866 dataset=/ExpressPhysics/Run2024C-Express-v1/FEVT minLumi=20 maxLumi=30 eventsPerLumi=50000 and runTheMatrix.py -l limited -i all --ibeos since it makes effects on P5.

@jshlee @watson-ij @quark2 @hcai0520 @giovanni-mocellin

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 24, 2024

A new Pull Request was created by @Dongwoon77 for CMSSW_14_0_X.

It involves the following packages:

  • DQM/GEM (dqm)
  • DQM/Integration (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@batinkov, @francescobrivio, @threus, @watson-ij this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 24, 2024

cms-bot internal usage

@tjavaid
Copy link

tjavaid commented Jul 25, 2024

backport of #45489

@tjavaid
Copy link

tjavaid commented Jul 25, 2024

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7c8e6/40587/summary.html
COMMIT: 1f221d8
CMSSW: CMSSW_14_0_X_2024-07-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45541/40587/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@tjavaid
Copy link

tjavaid commented Jul 25, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@Dongwoon77
Copy link
Contributor Author

+1

Hi @tjavaid.

Yes, we want to deploy.

Thank you.
Dongwoon.

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4e8f017 into cms-sw:CMSSW_14_0_X Jul 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants