GEM onlineDQM trigger primitive with CMSSW_14_1_0_pre5

[Dongwoon77]

PR description:

In this PR, GEM onlineDQM plots for trigger primitive have been implemented

PR validation:

Tests are done with cmsRun $CMSSW_BASE/src/DQM/Integration/python/clients/gem_dqm_sourceclient-live_cfg.py unitTest=True runNumber=379866 dataset=/ExpressPhysics/Run2024C-Express-v1/FEVT minLumi=20 maxLumi=40 eventsPerLumi=50000 and runTheMatrix.py -l limited -i all --ibeos since it makes effects on P5

@jshlee @watson-ij @quark2 @hcai0520 @giovanni-mocellin

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45489/40957

• Found files with invalid states:
  • DQM/GEM/plugins/GEMDigiPadAnalysis.cc:
    • Added: 72d094c
    • Deleted: 40ffb14
  • DQM/GEM/interface/GEMDigiPadAnalysis.h:
    • Added: 72d094c
    • Deleted: 40ffb14

[cmsbuild]

A new Pull Request was created by @Dongwoon77 for master.

It involves the following packages:

• DQM/GEM (dqm)
• DQM/Integration (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@batinkov, @francescobrivio, @threus, @watson-ij this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[tjavaid]

please test

[cmsbuild]

+1

Size: This PR adds an extra 216KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-06c477/40469/summary.html
COMMIT: 3a61cf5
CMSSW: CMSSW_14_1_X_2024-07-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45489/40469/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 89 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3345208
• DQMHistoTests: Total failures: 2461
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3342727
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[tjavaid]

@Dongwoon77 , we are testing this PR on our playback machines using CMSSW_14_0_11 with run 382626. Could you please have a look at the plots and see whether new plots seems as expected to you ? Could you please also make its backport PR to 14_0_X ?

[quark2]

Hi @tjavaid,

Thanks for your management. I'm one of GEM DQM developers, and me and @Dongwoon77 found that many plots are missing. Not only the new plots but also most of the existing plots are being displayed with "not available" message, while they appear in the central onlineDQM as well. The change in the codes does not affect the existing ones. Even, as I understand, if the plots are not made, then they should not appear at all in the folders (not in the "layouts" area), not displaying "not available" message.

I wonder what happens on the original ROOT DQM file, but I have no idea how to retrieve it. Is there a way to download it? Also, how can I reproduce the playback result by myself?

[tjavaid]

Hi @tjavaid,

Thanks for your management. I'm one of GEM DQM developers, and me and @Dongwoon77 found that many plots are missing. Not only the new plots but also most of the existing plots are being displayed with "not available" message, while they appear in the central onlineDQM as well. The change in the codes does not affect the existing ones. Even, as I understand, if the plots are not made, then they should not appear at all in the folders (not in the "layouts" area), not displaying "not available" message.

I wonder what happens on the original ROOT DQM file, but I have no idea how to retrieve it. Is there a way to download it? Also, how can I reproduce the playback result by myself?

Hi @quark2 , @Dongwoon77 , could you please have a look now on the GUI plots ? The histograms seem being populated now. (We just restarted the run at playback. Perhaps GEM client was crashing in previous iteration)
Let us know.

[quark2]

Hi @tjavaid,

Thanks a lot! I've checked that the new plots are all available. We still need to check whether they are all sensible, though. We will notice if we have something else.

Best regards,
Byeonghak Ko

[Dongwoon77]

Hi @tjavaid.

I've checked the GUI plots, I think that is look good.

Thank you.
Dongwoon.

[tjavaid]

Hi @tjavaid.

I've checked the GUI plots, I think that is look good.

Thank you. Dongwoon.

Hi @Dongwoon77 , thanks for the cross check. Could you please make its backport PR to14_0_X for data-taking release? Thanks

[tjavaid]

+1

• P5 tests OK.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1

[Dongwoon77]

Hi @tjavaid.

I made the backport PR for CMSSW_14_0_X version.
you can check the PR at below link.

backport PR Link : #45541

Thank you.
Dongwoon.