-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12_4_X] CepGenInterface: Added missing include #45517
Conversation
A new Pull Request was created by @forthommel for CMSSW_12_4_X. It involves the following packages:
@bbilin, @cmsbuild, @lviliani, @menglu21, @mkirsano can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
@smuzaffar to get this one tested we need to mention the pr in cmsdist, right? |
please test with cms-sw/cmsdist#9308 |
REMINDER @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen: This PR was tested with cms-sw/cmsdist#9308, please check if they should be merged together |
yes this should be tested with cmsdist PR. I already have started the tests now |
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
|
@cms-sw/generators-l2 can you have a look? |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR fixes the build of CepGen release >= 1.2.2 where the include chain was strongly modified. This will cure the recent build failure encountered in cms-sw/cmsdist#9308.
PR validation:
Builds
Backport of #44647
FYI: @smuzaffar, @bbilin