Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] CepGenInterface: Added missing include #45517

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

forthommel
Copy link
Contributor

PR description:

This PR fixes the build of CepGen release >= 1.2.2 where the include chain was strongly modified. This will cure the recent build failure encountered in cms-sw/cmsdist#9308.

PR validation:

Builds

Backport of #44647

FYI: @smuzaffar, @bbilin

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @forthommel for CMSSW_12_4_X.

It involves the following packages:

  • GeneratorInterface/CepGenInterface (generators)

@bbilin, @cmsbuild, @lviliani, @menglu21, @mkirsano can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 20, 2024

cms-bot internal usage

@bbilin
Copy link
Contributor

bbilin commented Jul 20, 2024

@smuzaffar to get this one tested we need to mention the pr in cmsdist, right?

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmsdist#9308

@cmsbuild
Copy link
Contributor

REMINDER @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen: This PR was tested with cms-sw/cmsdist#9308, please check if they should be merged together

@smuzaffar
Copy link
Contributor

@smuzaffar to get this one tested we need to mention the pr in cmsdist, right?

yes this should be tested with cmsdist PR. I already have started the tests now

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5548b1/40515/summary.html
COMMIT: c90e49f
CMSSW: CMSSW_12_4_X_2024-07-21-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45517/40515/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3766083
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3766053
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 167 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

@cms-sw/generators-l2 can you have a look?

@lviliani
Copy link
Contributor

lviliani commented Sep 6, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#9308

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 334629d into cms-sw:CMSSW_12_4_X Sep 9, 2024
9 checks passed
@forthommel forthommel deleted the cepgen_patch-12_4_X branch September 9, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants