Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] Bump cepgen version to 1.2.5 #9308

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

forthommel
Copy link
Contributor

This release, among other things, fixes the missing particles status code propagation to the HepMC2 event content noticed by @bbilin, and documented in cepgen/cepgen#88.

Backport of #9305.

FYI: @bbilin

This release, among other things, fixes the missing particles status code propagation to the HepMC2 event content noticed by @bbilin, and documented in cepgen/cepgen#88.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @forthommel for branch IB/CMSSW_12_4_X/master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 19, 2024

cms-bot internal usage

@bbilin
Copy link

bbilin commented Jul 20, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a35ed/40507/summary.html
COMMIT: 9c65d04
CMSSW: CMSSW_12_4_X_2024-07-14-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9308/40507/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

Entering library rule at src/GeneratorInterface/CepGenInterface/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_4_X_2024-07-14-0000/src/GeneratorInterface/CepGenInterface/plugins/CepGenGeneratorFilter.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DGNU_GCC -D_GNU_SOURCE -DEIGEN_DONT_PARALLELIZE -DTBB_USE_GLIBCXX_VERSION=100300 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_12_4_X_2024-07-14-0000' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_12_4_X_2024-07-14-0000' -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_4_X_2024-07-14-0000/src -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_4_X_2024-07-14-0000/poison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02846/el8_amd64_gcc10/cms/cmssw/CMSSW_12_4_X_2024-07-14-0000/src -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/evtgen/2.0.0-8483b6918b16717eadacd979fc193f80/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/tauolapp/1.1.8-e247bc5a5cfe35d28ca45be8d87eddeb/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/cepgen/1.2.5-5570693580cd316ea9b6239255d9e3fb/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/pythia8/306-ea53315aaab4137f4fbe9c149526eeff/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/highfive/2.3.1-fab0adb24235ebb82eb02538c07da582/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/lhapdf/6.4.0-68defff11ffd434c73727d03802bfb85/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/photospp/3.64-03e7dc9d794b8f29300196fc5227aa57/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/pcre/8.43-28d54724578a9006cf0dca75629374e3/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/boost/1.78.0-0eee560924071238500da28588b8fccc/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/bz2lib/1.0.6-86270889250d9cb8193d1963706a39cb/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/clhep/2.4.5.1-b3b5ef43b98fdd55fd7550138135e32f/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/fastjet/3.4.0-726cc2aa67168c4401b736ad982593f1/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/gsl/2.6-84974e6daa70611c23ebff30cbb797c4/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/hdf5/1.10.6-b47f45e9e34f400d567463a591169360/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/hepmc/2.06.10-8da3973df82bd6f0237531d0d68b40da/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/heppdt/3.04.01-1904055a90cd60b1270a44cffac64ea2/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/libuuid/2.34-fe91b21b8e54a48f2d45894d9da65f14/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/pythia6/426-604d92e9b51dd03325fbd342698d85b2/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/lcg/root/6.24.07-3a519d2d0a7c445feecb2cc52e1e0d07/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/tbb/v2021.5.0-2328a2cb8c504783674e42d9ee7f30ff/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/xerces-c/3.1.3-5b1e4ab8f5a2057565f3be0ae6a10b37/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/xz/5.2.5-d6fed2038c4e8d6e04531d1adba59f37/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/zlib/1.2.11-71514f01d2850dfd0bcd391557259a58/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/eigen/82dd3710dac619448f50331c1d6a35da673f764a-cc5ed88b76e386be0baea3ab0a896c6a/include/eigen3 -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/fmt/8.0.1-04b1d7b0f4e0f4ebd82177f8f107de05/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/hepmc3/3.2.5-c1448a381efbea7cc6e1f099763d2061/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/md5/1.0.0-0440f43b57c5656322f7cd7a65f85771/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/OpenBLAS/0.3.15-a8c37ec25750b8edfd2c93d1f2e8e582/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/openmpi/4.1.4-61e8878c56d55fbd66454288e8aab8fb/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/tinyxml2/6.2.0-d606f7b7117c01c3eda945d9671bbc88/include -O2 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++1z -ftree-vectorize -Wstrict-overflow -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -msse3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-deprecated-copy -Wno-unused-parameter -Wunused -Wparentheses -Wno-deprecated -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -O2 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++1z -ftree-vectorize -Wstrict-overflow -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -msse3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-deprecated-copy -Wno-unused-parameter -Wunused -Wparentheses -Wno-deprecated -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DUSE_CMS_DEPRECATED -DBOOST_DISABLE_ASSERTS  -fPIC  -MMD -MF tmp/el8_amd64_gcc10/src/GeneratorInterface/CepGenInterface/plugins/GeneratorInterfaceCepGenGenerator/CepGenGeneratorFilter.cc.d /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_4_X_2024-07-14-0000/src/GeneratorInterface/CepGenInterface/plugins/CepGenGeneratorFilter.cc -o tmp/el8_amd64_gcc10/src/GeneratorInterface/CepGenInterface/plugins/GeneratorInterfaceCepGenGenerator/CepGenGeneratorFilter.cc.o
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_4_X_2024-07-14-0000/src/GeneratorInterface/CepGenInterface/interface/CepGenGeneratorFilter.h:8,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_4_X_2024-07-14-0000/src/GeneratorInterface/CepGenInterface/plugins/CepGenGeneratorFilter.cc:5:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_4_X_2024-07-14-0000/src/GeneratorInterface/CepGenInterface/interface/CepGenEventGenerator.h:36:19: error: 'ParametersList' in namespace 'cepgen' does not name a type
   36 |     const cepgen::ParametersList proc_params_;
      |                   ^~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_4_X_2024-07-14-0000/src/GeneratorInterface/CepGenInterface/interface/CepGenEventGenerator.h:37:48: error: 'ParametersList' is not a member of 'cepgen'
   37 |     std::vector > modif_modules_, output_modules_;
      |                                                ^~~~~~~~~~~~~~


@smuzaffar
Copy link
Contributor

test parameters:

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a35ed/40509/summary.html
COMMIT: 9c65d04
CMSSW: CMSSW_12_4_X_2024-07-14-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9308/40509/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3766083
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3766053
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 167 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@bbilin
Copy link

bbilin commented Jul 20, 2024

+1

@smuzaffar
Copy link
Contributor

+externals

@cms-sw/orp-l2 feel free to merge it along with cms-sw/cmssw#45517

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_4_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmssw#45517

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2024

REMINDER @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen: This PR was tested with cms-sw/cmssw#45517, please check if they should be merged together

@mandrenguyen
Copy link

+1

@cmsbuild cmsbuild merged commit d4da567 into cms-sw:IB/CMSSW_12_4_X/master Sep 9, 2024
10 checks passed
@forthommel forthommel deleted the cepgen-12_4_X branch September 9, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants