Hcalnano autonano

[vlimant]

PR description:

harmonise how hcal DPG nano are configured and tested (#43961)

FYI: @DryRun

PR validation:

nano matrix succeded

a backport "might" be included in #44428

[vlimant]

enable nano

[vlimant]

type hcal

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44492/39581

• This PR adds an extra 92KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/Applications/python/ConfigBuilder.py modified in PR(s): [Dummy] Try creating big-enough cache to cause splitting #44368, Scouting NANO in autonano #44399
  • File Configuration/PyReleaseValidation/python/relval_nano.py modified in PR(s): [NanoAOD,BTVNano] Btvnano integration as customized module #43485, Customized L1T NanoAOD #43957, Update of the Phase-2 GMT Emulator #44319, l1nano import location #44391, Scouting NANO in autonano #44399, Custom MUON POG NANO includes default NANO #44425
  • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Run3 era for 2024 pp reference and UPC reco #44316, Update of the Phase-2 GMT Emulator #44319, fix standard and upgrade validation workflows #44464
  • File PhysicsTools/NanoAOD/python/autoNANO.py modified in PR(s): [NanoAOD,BTVNano] Btvnano integration as customized module #43485, Customized L1T NanoAOD #43957, Update of the Phase-2 GMT Emulator #44319, l1nano import location #44391, Scouting NANO in autonano #44399, Custom MUON POG NANO includes default NANO #44425

[cmsbuild]

A new Pull Request was created by @vlimant for master.

It involves the following packages:

• Configuration/Applications (operations)
• Configuration/PyReleaseValidation (pdmv, upgrade)
• DPGAnalysis/HcalNanoAOD (xpog)
• PhysicsTools/NanoAOD (xpog)

@davidlange6, @hqucms, @miquork, @cmsbuild, @AdrianoDee, @vlimant, @fabiocos, @rappoccio, @sunilUIET, @srimanob, @subirsarkar, @antoniovilela can you please review it and eventually sign? Thanks.
@slomeo, @fabiocos, @makortel, @missirol, @Martin-Grunewald, @gpetruc, @AnnikaStein this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[vlimant]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT RelVals-NANO
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f56e22/38294/summary.html
COMMIT: d704931
CMSSW: CMSSW_14_1_X_2024-03-20-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44492/38294/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 2500.52500.5_ScoutingNanodata13X/step2_ScoutingNanodata13X.log

RelVals-NANO

• 2500.52500.5_ScoutingNanodata13X/step2_ScoutingNanodata13X.log
• 2500.512500.51_ScoutingNanomc13X/step1_ScoutingNanomc13X.log

Comparison Summary

Summary:

• You potentially added 129 lines to the logs
• Reco comparison results: 45 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297369
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3297346
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[vlimant]

+1

[vlimant]

can we please have the remaining signatures, or comments for this trivial PR ? @cms-sw/operations-l2 @cms-sw/pdmv-l2 @cms-sw/upgrade-l2.
Is there a better way to bring such trivial changes forward in quicker way before some conflicts emerge @cms-sw/orp-l2

[AdrianoDee]

I imagine this, while unrelated with this PR, is just that you took the chance to implement the merge + steps['NANO_data13.0'] syntax also for @MUDPG auto NANO.

[vlimant]

yes, sorry indeed.

[AdrianoDee]

No worries of course

[AdrianoDee]

+pdmv

[antoniovilela]

ping @cms-sw/upgrade-l2
Thanks.

[antoniovilela]

can we please have the remaining signatures, or comments for this trivial PR ? @cms-sw/operations-l2 @cms-sw/pdmv-l2 @cms-sw/upgrade-l2. Is there a better way to bring such trivial changes forward in quicker way before some conflicts emerge @cms-sw/orp-l2

Please bring PRs that are taking time to get all signatures during the weekly ORP meeting, where we can also discuss the requested backports.
We had indeed questions concerning backports in the meeting yesterday.
Thanks.

[vlimant]

I am away this week, I'll try to connect to the ORP next week if time permits

[srimanob]

+Upgrade

[antoniovilela]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.