Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix standard and upgrade validation workflows #44464

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

vlimant
Copy link
Contributor

@vlimant vlimant commented Mar 19, 2024

PR description:

fixes what I broke in #44087

PR validation:

11024.15 ran properly

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 19, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44464/39548

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vlimant for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@miquork, @subirsarkar, @cmsbuild, @sunilUIET, @srimanob, @AdrianoDee can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo, @makortel, @missirol, @Martin-Grunewald this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@vlimant
Copy link
Contributor Author

vlimant commented Mar 19, 2024

enable nano

@vlimant
Copy link
Contributor Author

vlimant commented Mar 19, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be4698/38256/summary.html
COMMIT: ceb9dd0
CMSSW: CMSSW_14_1_X_2024-03-18-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44464/38256/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16402
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16402
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 47 log files, 27 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.548 2.548 0.000 ( +0.0% ) 5.16 5.17 -0.3% 1.874 2.086
2500.001 2.698 2.698 0.000 ( +0.0% ) 4.63 4.63 -0.1% 2.064 2.101
2500.002 2.638 2.638 0.000 ( +0.0% ) 4.78 4.83 -1.1% 2.239 2.112
2500.01 1.318 1.318 0.000 ( +0.0% ) 9.11 9.27 -1.7% 2.224 1.895
2500.011 1.740 1.740 0.000 ( +0.0% ) 5.06 5.09 -0.7% 1.997 2.030
2500.012 1.581 1.581 0.000 ( +0.0% ) 7.22 7.26 -0.4% 2.269 1.947
2500.1 2.192 2.192 0.000 ( +0.0% ) 5.17 5.24 -1.4% 1.810 1.918
2500.2 2.308 2.308 0.000 ( +0.0% ) 5.93 6.00 -1.2% 1.608 1.799
2500.21 1.181 1.181 0.000 ( +0.0% ) 4.23 4.29 -1.4% 1.635 1.837
2500.211 1.545 1.545 0.000 ( +0.0% ) 3.53 3.64 -3.0% 1.654 1.906
2500.3 2.058 2.058 0.000 ( +0.0% ) 11.87 12.38 -4.1% 1.694 1.824
2500.301 2.631 2.631 0.000 ( +0.0% ) 9.73 9.96 -2.3% 1.677 1.827
2500.31 1.254 1.254 0.000 ( +0.0% ) 18.69 19.45 -3.9% 2.074 1.823
2500.311 1.640 1.640 0.000 ( +0.0% ) 13.00 12.64 +2.9% 2.032 1.860
2500.312 7.159 7.159 0.000 ( +0.0% ) 1.39 1.37 +1.8% 1.245 1.702
2500.313 1.564 1.564 0.000 ( +0.0% ) 6.72 6.32 +6.2% 1.055 1.051
2500.314 1.163 1.163 0.000 ( +0.0% ) 13.25 12.69 +4.4% 2.049 1.688
2500.315 1.758 1.758 0.000 ( +0.0% ) 13.26 13.44 -1.3% 2.318 2.200
2500.316 3.091 3.091 0.000 ( +0.0% ) 2.16 2.20 -1.6% 1.846 1.777
2500.317 1.787 1.787 0.000 ( +0.0% ) 12.34 12.76 -3.2% 1.838 2.217
2500.4 2.058 2.058 0.000 ( +0.0% ) 11.76 12.23 -3.8% 1.860 1.764
2500.401 1.824 1.824 0.000 ( +0.0% ) 9.69 9.71 -0.2% 1.421 1.642
2500.402 2.631 2.631 0.000 ( +0.0% ) 9.52 10.08 -5.6% 1.939 1.800
2500.403 5.188 5.188 0.000 ( +0.0% ) 1.51 1.55 -2.5% 1.826 1.824
2500.404 2.620 2.620 0.000 ( +0.0% ) 9.17 9.79 -6.3% 1.746 1.748
2500.5 19.575 19.575 0.000 ( +0.0% ) 1.18 1.24 -4.7% 1.364 1.363

@vlimant
Copy link
Contributor Author

vlimant commented Mar 19, 2024

+1

@antoniovilela
Copy link
Contributor

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2
Let's get this in soon to fix the RelVals.

@perrotta
Copy link
Contributor

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 Let's get this in soon to fix the RelVals.

@antoniovilela @rappoccio it is rather annoying having all those errors in the IB, as they can hide real ones
Since the fix here is quite trivial, could you please bypass @cms-sw/pdmv-l2 @cms-sw/upgrade-l2 signatures and get it merged?

@srimanob
Copy link
Contributor

+Upgrade

@antoniovilela
Copy link
Contributor

+1

@antoniovilela
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 15928d6 into cms-sw:master Mar 22, 2024
13 checks passed
@AdrianoDee
Copy link
Contributor

+pdmv

(Signing just for the records and apologies for the delay)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants