Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the order of unit tests in CondTools/Hcal #37666

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Fixing the order of unit tests in CondTools/Hcal #37666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cdd2a0
Fixing the order of unit tests in CondTools/Hcal
igv4321 Apr 23, 2022
6338ad9
Running write_HFPhase1PMTParam executable without explicit path
igv4321 Apr 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CondTools/Hcal/test/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<library name="PMTParams" file="make_*cc">
</library>

<bin file="write_HFPhase1PMTParams.cc">
<bin name="write_HFPhase1PMTParams" file="write_HFPhase1PMTParams.cc">
<lib name="PMTParams"/>
</bin>

Expand All @@ -28,6 +28,7 @@
</bin>

<bin file="HFPhase1PMTParams_unittest.cc">
<flags PRE_TEST = "write_HFPhase1PMTParams"/>
<flags TEST_RUNNER_ARGS = "/bin/bash CondTools/Hcal/test testHFPhase1PMTParams.sh"/>
<use name="FWCore/Utilities"/>
</bin>
Expand Down
2 changes: 1 addition & 1 deletion CondTools/Hcal/test/testHFPhase1PMTParams.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
function die { echo $1: status $2 ; exit $2; }

echo "TESTING HFPhase1PMTParams generation code ..."
${CMSSW_BASE}/test/${SCRAM_ARCH}/write_HFPhase1PMTParams 1 HFPhase1PMTParams_V00_mc.bbin || die "Failure running write_HFPhase1PMTParams" $?
write_HFPhase1PMTParams 1 HFPhase1PMTParams_V00_mc.bbin || die "Failure running write_HFPhase1PMTParams" $?

echo "TESTING HFPhase1PMTParams database creation code ..."
cmsRun ${LOCAL_TEST_DIR}/HFPhase1PMTParamsDBWriter_cfg.py || die "Failure running HFPhase1PMTParamsDBWriter_cfg.py" $?
Expand Down