Fixing the order of unit tests in CondTools/Hcal

[igv4321]

PR description:

Fixing the order of unit tests in CondTools/Hcal, as the problem with out-of-order test execution was noted after PR #37650 was merged

PR validation:

"scram b runtests -j 5" appears to work fine.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37666/29470

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @igv4321 (Igor Volobouev) for master.

It involves the following packages:

• CondTools/Hcal (db)

@cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

@cmsbuild , please test

[tvami]

type bug-fix

[smuzaffar]

@igv4321 , please also update CondTools/Hcal/test/testHFPhase1PMTParams.sh and just run write_HFPhase1PMTParams instead of ${CMSSW_BASE}/test/${SCRAM_ARCH}/write_HFPhase1PMTParams ( see #37650 (comment))

By the way, your existing changes are also correct

[igv4321]

OK, changed as requested

[tvami]

@cmsbuild , please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37666/29471

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #37666 was updated. @ggovi, @malbouis, @tvami, @francescobrivio can you please check and sign again.

[qliphy]

please abort
seems to be stuck

[qliphy]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c8938/24170/summary.html
COMMIT: 6338ad9
CMSSW: CMSSW_12_4_X_2022-04-24-0000/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37666/24170/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0c8938/39434.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695434
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3695404
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[smuzaffar]

@cms-sw/db-l2 can you please review this?
@perrotta @qliphy , this is just a technical fix to properly run unit tests in IBs, so this can be merged

[tvami]

+db

• the unit test passes

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1