Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-gex08 Rearrange the sequencing of the xml files for dd4hep #31092

Merged
merged 3 commits into from
Aug 10, 2020

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Aug 7, 2020

PR description:

Rearrange the sequencing of the xml files for dd4hep

PR validation:

Tested using the runTheMatrix workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31092/17633

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2020

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@ianna
Copy link
Contributor

ianna commented Aug 7, 2020

@bsunanda - this looks terribly familiar and identical to #30963
How did it happen that the same rearrangement is needed again?

@kpedro88
Copy link
Contributor

kpedro88 commented Aug 7, 2020

@ianna #30963 did not fix all of the common/muon variations

@bsunanda
Copy link
Contributor Author

bsunanda commented Aug 7, 2020

@ianna @kpedro88 #30963 fixed O5 while this fixes O6, O7 as well as M6, M7. I did not touch M4, M5 because they were used in D49. But these changes do not affect DDD - only DD4HEP. So if you think it is OK I can fix D4, D5

@ianna
Copy link
Contributor

ianna commented Aug 7, 2020

@ianna @kpedro88 #30963 fixed O5 while this fixes O6, O7 as well as M6, M7. I did not touch M4, M5 because they were used in D49. But these changes do not affect DDD - only DD4HEP. So if you think it is OK I can fix D4, D5

Thanks, @bsunanda - it would be good to fix all of them :-)

@kpedro88
Copy link
Contributor

kpedro88 commented Aug 7, 2020

@bsunanda if it doesn't affect the DDD results, maybe it's okay to modify D49. I guess this may show up in future Phase 2 DDD vs DD4hep comparisons, though.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2020

The code-checks are being triggered in jenkins.

@bsunanda
Copy link
Contributor Author

bsunanda commented Aug 7, 2020

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31092/17636

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2020

Pull request #31092 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31092/17642

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2020

Pull request #31092 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

@bsunanda
Copy link
Contributor Author

bsunanda commented Aug 7, 2020

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2020

+1
Tested at: f6d5ce9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6d2db0/8658/summary.html
CMSSW: CMSSW_11_2_X_2020-08-07-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6d2db0/8658/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2612401
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2612352
  • DQMHistoTests: Total skipped: 48
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@cvuosalo
Copy link
Contributor

cvuosalo commented Aug 7, 2020

+1

@kpedro88
Copy link
Contributor

kpedro88 commented Aug 8, 2020

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d44c749 into cms-sw:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants