Add centrality bin in 75X and Jet DQM update

[rkunnawa]

Backporting to 75X for the HIN-Jet DQM #12194 module and the centrality bin information #12002 . When checking this, i ran the matrix after merging with the #12259 and the workflows completed without any errors. We would like this to be in the latest 75X release by the next week since we have to run several tests. thanks a lot!

Cheers
Raghav

[cmsbuild]

A new Pull Request was created by @rkunnawa (Raghav Kunnawalkam Elayavalli) for CMSSW_7_5_X.

Add centrality bin in 75X and Jet DQM update

It involves the following packages:

DQM/Physics
DQMOffline/JetMET
RecoHI/Configuration
RecoHI/HiCentralityAlgos
Validation/RecoJets

@cvuosalo, @slava77, @cmsbuild, @deguio, @danduggan, @vanbesien can you please review it and eventually sign? Thanks.
@rappoccio, @azsigmon, @richard-cms, @ahinzmann, @schoef, @mmarionncern, @jazzitup, @MiheeJo, @echapon, @jdolen, @nhanvtran, @yenjie, @kurtejung, @istaslis, @mariadalfonso, @rociovilar, @mandrenguyen, @dgulhan, @TaiSakuma, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[rkunnawa]

@Degano Since, we are trying to get this into our heavy ion data taking release asap I would very much appreciate your help in moving this forward.

[BetterWang]

Hi @deguio , can you trigger the test?
Thanks,

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9548/console

[cmsbuild]

+1
Tested at: 6c2b9b4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12310/9548/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12310/9548/summary.html

[slava77]

@rkunnawa
please make a PR for 76X and 80X

[rkunnawa]

@slava77 the PR for 76X is here #12194. I will prepare a new one for 80X later today.
thanks!

[slava77]

+1

for #12310 6c2b9b4

• reco-related changes look OK (centralityBin added to globalRecoPbPb sequence), this change was added to 76X already in Reco changes for centralityBin in DQM #12002 (and to 80X in My new centrality br #12151 ). The rest, DQM and Validation changes, didn't trigger any major concern at a quick glance.
• jenkins tests pass and comparisons with baseline show expected differences only in HI workflow (140.53):
  • monitored reco products are unchanged in fwlite comparisons
  • DQM plots show differences in Centrality/EventPlane and HIJetValidation plots
    here is a somewhat randomly picked plot from this category
    

[deguio]

to be submitted to 80x as well

[rkunnawa]

Hi @deguio, Im testing the PR for 80X at the moment with the matrix. In the meanwhile, I can remove the commented out statements in this PR (mostly in the Validation/JetTester_HeavyIon module) and we can test this again if its necessary. just checking since the timing is quite crucial for the HI datataking. Please let me know. cheers!

[rkunnawa]

@deguio and @slava77 ive created a new PR for 80X with the same Jet DQM code (with removing some of the commented out code) #12353.

[rkunnawa]

apologies for the multiple emails, do we have a chance of this going 755? I heard that 755 is getting built as we speak for release tomorrow. thanks a lot!

[deguio]

+1
I doubt it will make it for 755, but who knows..
corresponding PR approved in 76 and 80.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar