Reco changes for centralityBin in DQM

[smdogra]

To include centralityBin distribution in the DQM monitoring. For this, changes are requested in the HI reco sequence

Reconstruction_HI_cff.py
RecoHiCentrality_EventContent_cff.py
and in the
CentralityDQM module.
CentralityDQM_cfi.py

[cmsbuild]

A new Pull Request was created by @smdogra for CMSSW_7_6_X.

Reco changes for centralityBin in DQM

It involves the following packages:

DQM/Physics
RecoHI/Configuration
RecoHI/HiCentralityAlgos

@cvuosalo, @slava77, @cmsbuild, @deguio, @danduggan, @vanbesien can you please review it and eventually sign? Thanks.
@rappoccio, @azsigmon, @MiheeJo, @jazzitup, @richard-cms, @echapon, @yenjie, @kurtejung, @istaslis, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test
@smdogra I suppose you will make a PR for 75X as well.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9079/console

[cmsbuild]

-1

Tested at: 5ebae90
I found errors in the following addon tests:

cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Wed Oct 21 00:30:39 2015-date Wed Oct 21 00:18:25 2015 s - exit: 16640

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12002/9079/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12002/9079/summary.html

[slava77]

An exception of category 'NoProxyException' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'reconstruction_step'
   [2] Calling event method for module CentralityBinProducer/'centralityBin'
Exception Message:
No data of type "CentralityTable" with label "HFtowers" in record "HeavyIonRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.

the error seems real
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12002/9079/addOnTests/hlt_mc_HIon/cmsDriver.py_RelVal_-s_HLT:HIon,RAW2DIGI,L1Reco,RECO_--mc_--scenario=HeavyIons_-n_10_--conditions_auto:run2_mc_HIon_--relval_9000,50_--datatier_RAW-H.log

The same test passes in the reference IB
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc493/CMSSW_7_6_X_2015-10-20-1100/addOnTests/logs/cmsDriver-hlt_mc_HIon_cmsDriver.py_RelVal_-s_HLT:HIon,RAW2DIGI,L1Reco,RECO_--mc_--scenario=HeavyIons_-n_10_--conditions_auto:run2_mc_HIon_--relval_9000,50_--datatier_RAW-H.log

call
addOnTests.py -t hlt_mc_HIon
to reproduce

[slava77]

@smdogra
I suppose the fix to the addOnTest issue is coming soon.
Please confirm.

Thank you.

[mmusich]

@slava77 there might be a missing label in the MC Heavy Ion GTs (the inital request was to have 2 separate labels for data/mc but at some point this should have changed). Either this line
centralitybincollection = cms.InputTag("centralityBin","HFtowers")
is changed to consume some of the available MC labels or we need to modify the Global Tags.
@diguida

[mmusich]

@smdogra GTs with the label HFTower for MC are available: #12079

[smdogra]

@slava77 Can we test it again or do we need to have new PR ?

[mmusich]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9203/console

[mmusich]

@smdogra looks like #12079 made CMSSW_7_6_X_2015-10-25-2300. If an IB past that one is used to test you should have your HFtowers labels available Diff among GT.

[cmsbuild]

+1
Tested at: 5ebae90
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12002/9203/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12002/9203/summary.html

[cvuosalo]

+1

For #12002 5ebae90

Adding the centrality bin distribution for Heavy Ions.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-10-26-1100 show no significant differences except the expected addition of the centrality bin distribution for Heavy Ion workflow 140.53. An example is shown below:

[deguio]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1

[diguida]

@smdogra the 75X back-port of #12002 is ready, together with GT: #12213