Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed path names. Removed pt2 and pt3 in unnecessary cases. Added debug print (dump # of HLT passed events). Replace cout to DebugLog. Updated paths (PhotonMET, PureMET, DiPhoton, HighPtPhoton). #11456

Closed
wants to merge 7 commits into from

Conversation

ryonamin
Copy link

This is a PR replaced instead of #11047 (There was a problem to be merged).
Also this is included a latest request that corresponds to #11453. ==> Decided to remove this change and make this change at #11151 (see below).
==> In summary, Backport from 76X to 75X (#10907,#10974, #11219).

Ryo Yonamine added 3 commits August 31, 2015 17:08
…ug print (dump # of HLT passed events). Replace cout to DebugLog. Updated paths (PhotonMET, PureMET, DiPhoton, HighPtPhoton).)
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ryonamin (Ryo Yonamine) for CMSSW_7_5_X.

Fixed path names. Removed pt2 and pt3 in unnecessary cases. Added debug print (dump # of HLT passed events). Replace cout to DebugLog. Updated paths (PhotonMET, PureMET, DiPhoton, HighPtPhoton).

It involves the following packages:

HLTriggerOffline/Exotica

@cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Sep 24, 2015

ciao @ryonamin
sorry but I am confused now.
the rebase is fine, but the equivalent of #11453 should go on top of #11151 and not here.
otherwise I fear that as soon as the first one is merged, the second won't merge anymore.
F.

@ryonamin
Copy link
Author

Oh, sorry! You're completely correct. I made a mistake. Do you think I can get the change (#11453) back, and add it to #11151?

@deguio
Copy link
Contributor

deguio commented Sep 24, 2015

yep.
go ahead.
thanks,
F.

DST_L1HTT125ORHTT150ORHTT175_CaloScouting_v ==> DST_CaloJet40_CaloScouting_v
to make this change at later PR.
@cmsbuild
Copy link
Contributor

Pull request #11456 was updated. @cmsbuild, @danduggan, @vanbesien, @deguio can you please check and sign again.

"DST_HT450_PFReco_PFBTagCSVReco_PFScouting_v",
"DST_L1HTT125ORHTT150ORHTT175_PFReco_PFBTagCSVReco_PFScouting_v",
"DST_CaloJet40_PFReco_PFBTagCSVReco_PFScoutingo"
==>
"DST_HT450_PFScouting_v",
"DST_L1HT_PFScouting_v",
"DST_CaloJet40_PFScouting_v"_v"
to make these changes at later PR.
@cmsbuild
Copy link
Contributor

Pull request #11456 was updated. @cmsbuild, @danduggan, @vanbesien, @deguio can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Sep 24, 2015

please test

@deguio
Copy link
Contributor

deguio commented Sep 24, 2015

let's see how it goes...
in principle you could have just removed commit 9a5b543 and following.

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1
Tested at: c7f8f2f
I found an error when building:

gmake[1]: **\* [CompilePython] Error 1
gmake[1]: Target `PostBuild' not remade because of errors.
gmake[1]: Leaving directory`/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_5_X_2015-09-23-2300'
gmake: **\* [src] Error 2
gmake: Target `all' not remade because of errors.
gmake: **\* [There are compilation/build errors. Please see the detail log above.] Error 2


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11456/8355/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4de1b8f
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11456/8355/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11456/8355/git-merge-result

@deguio
Copy link
Contributor

deguio commented Sep 24, 2015

typo to be fixed. see:
https://github.com/cms-sw/cmssw/pull/11456/files#diff-e39cf2b11b6cc26b6dc8db0f427a819dR15

could you just remove those two new files? they will be added anyway with PR #11151
thanks,
F.

@cmsbuild
Copy link
Contributor

Pull request #11456 was updated. @cmsbuild, @danduggan, @vanbesien, @deguio can you please check and sign again.

@ryonamin
Copy link
Author

I have learned again thanks to you. Sorry for my mess.

@deguio
Copy link
Contributor

deguio commented Sep 25, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Sep 28, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants