Adding weight files for Phase 2 Ecal EB trigger primitive production #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @nancymarinelli for branch main. @aandvalenzuela, @iarspider, @AdrianoDee, @srimanob, @smuzaffar, @cmsbuild, @epalencia, @aloeliger can you please review it and eventually sign? Thanks. |
|
please test |
|
-1 Failed Tests: UnitTests Unit TestsI found 1 errors in the following unit tests: ---> test TestVectorDetId had ERRORS Comparison SummarySummary:
|
|
This error has nothing to do with the files I added with the PR.
Also, I have asked in the past days but got no reply, now that the data files
are in this new place, I need to know which path I should use to access them
I still need to test locally my other PR with the data files here.
Can somebody answer the question ?
…________________________________
From: cmsbuild ***@***.***>
Sent: Monday, October 2, 2023 19:28
To: cms-data/SimCalorimetry-EcalEBTrigPrimProducers ***@***.***>
Cc: Nancy Marinelli ***@***.***>; Mention ***@***.***>
Subject: Re: [cms-data/SimCalorimetry-EcalEBTrigPrimProducers] Add files via upload (PR #1)
-1
Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c80e4/35005/summary.html
COMMIT: 2b43ef5<2b43ef5>
CMSSW: CMSSW_13_3_X_2023-10-02-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/SimCalorimetry-EcalEBTrigPrimProducers/1/35005/install.sh to create a dev area with all the needed externals and cmssw changes.
Unit Tests
I found 1 errors in the following unit tests:
---> test TestVectorDetId had ERRORS
Comparison Summary
Summary:
* You potentially added 1 lines to the logs
* Reco comparison results: 10 differences found in the comparisons
* DQMHistoTests: Total files compared: 50
* DQMHistoTests: Total histograms compared: 3358320
* DQMHistoTests: Total failures: 31
* DQMHistoTests: Total nulls: 0
* DQMHistoTests: Total successes: 3358267
* DQMHistoTests: Total skipped: 22
* DQMHistoTests: Total Missing objects: 0
* DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
* Checked 214 log files, 167 edm output root files, 50 DQM output files
* TriggerResults<https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_13_3_X_2023-10-02-1100+7c80e4/59101/triggerResults>: found differences in 3 / 48 workflows
—
Reply to this email directly, view it on GitHub<#1 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABC6G2RHF2BVPLTAPADOCY3X5L2UXAVCNFSM6AAAAAA5MLGBTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBTGQ2TAMBXGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
please test I think with cms-data/DataFormats-DetId#1 this error should be gone. |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c80e4/35014/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
|
+l1 |
|
Hi @nancymarinelli @aloeliger |
|
Hello,
for the time being no. The 'versioning' is in the name of the file.
Nancy
…On 03.10.23 23:25, Phat Srimanobhas wrote:
Hi @nancymarinelli <https://github.com/nancymarinelli> @aloeliger
<https://github.com/aloeliger>
If I understand correctly, these files will need to be updated in the
near future. Do you think that filename should be structured a bit,
like having versioning, so that we can easily understand it in future.
Thx.
—
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABC6G2QTHT2GTSR2A4G4CULX5R7GFAVCNFSM6AAAAAA5MLGBTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBVG42TANZSG4>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Nancy Marinelli
Research Professor
University of Notre Dame, IN, US
CERN, Bdg 40/3-A01, 1211 Geneva
SWITZERLAND
Phone +41-22-76-70809
fax +41-22-76-78940
--------------fDaj6lRK7Sl6LRsd1fRMGmRU
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit
<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
Hello,<br>
for the time being no. The 'versioning' is in the name of the file.<br>
<br>
Nancy<br>
<br>
<br>
<div class="moz-cite-prefix">On 03.10.23 23:25, Phat Srimanobhas
wrote:<br>
</div>
<blockquote type="cite" ***@***.***">
<p dir="auto">Hi <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/nancymarinelli/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/nancymarinelli" ***@***.***</a> <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/aloeliger/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/aloeliger" ***@***.***</a><br>
If I understand correctly, these files will need to be updated
in the near future. Do you think that filename should be
structured a bit, like having versioning, so that we can easily
understand it in future. Thx.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>
Reply to this email directly, <a href="#1 (comment)" moz-do-not-send="true">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABC6G2QTHT2GTSR2A4G4CULX5R7GFAVCNFSM6AAAAAA5MLGBTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBVG42TANZSG4" moz-do-not-send="true">unsubscribe</a>.<br>
You are receiving this because you were mentioned.<img src="https://github.com/notifications/beacon/ABC6G2QRWSCCVYOJ6Y4344DX5R7GFA5CNFSM6AAAAAA5MLGBTOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTIBYFMO.gif" alt="" moz-do-not-send="true" width="1" height="1"><span style="color: transparent; font-size: 0; display: none;
visibility: hidden; overflow: hidden; opacity: 0; width: 0;
height: 0; max-width: 0; max-height: 0; mso-hide: all">Message
ID: <span><cms-data/SimCalorimetry-EcalEBTrigPrimProducers/pull/1/c1745750727</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
***@***.***": "http://schema.org",
***@***.***": "EmailMessage",
"potentialAction": {
***@***.***": "ViewAction",
"target": "#1 (comment)",
"url": "#1 (comment)",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
***@***.***": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Nancy Marinelli
Research Professor
University of Notre Dame, IN, US
CERN, Bdg 40/3-A01, 1211 Geneva
SWITZERLAND
Phone +41-22-76-70809
fax +41-22-76-78940</pre>
</body>
</html>
--------------fDaj6lRK7Sl6LRsd1fRMGmRU--
|
nancymarinelli
changed the title
This was referenced Oct 19, 2023
|
+Upgrade |
|
+1 |
|
merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.