Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data file for vector<DetId> unit test. #1

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Sep 26, 2023

Add initial data file for std::vector<DetId> unit test.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wddgit (W. David Dagenhart) for branch main.

@smuzaffar, @civanch, @aandvalenzuela, @iarspider, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@wddgit
Copy link
Contributor Author

wddgit commented Sep 26, 2023

please test

FYI @makortel.

This PR test does nothing, but I'm running it to check the box. The new unit test in PR cms-sw/cmssw#42877 will be the only that tests this PR. That unit test reads the input file added by this PR.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e7402/34918/summary.html
COMMIT: ed35e66
CMSSW: CMSSW_13_3_X_2023-09-26-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/DataFormats-DetId/1/34918/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3358044
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3358019
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@rappoccio
Copy link

+1

@rappoccio
Copy link

merge

  • CMSSW PR is already signed, forcing merge.

@smuzaffar
Copy link
Contributor

+externals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants