-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add walk
package to traverse an AST
#265
Add walk
package to traverse an AST
#265
Conversation
} | ||
|
||
// Preorder returns an iterator that traverses an AST in depth-first preorder. | ||
func Preorder(node Node) iter.Seq[Node] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: go.mod
still have go 1.22.0
dilective so we can't use range over func in memefish development.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go
directive in go.mod
is also updated. Is it problematic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, seems like I had missed this.
return false | ||
} | ||
|
||
return true | ||
// FIXME: The fields of `CreateTable` are not ordered by position for now, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The known requirements have been addressed and there appear to be no issues that need to be fixed.
LGTM!
Note: Lines 40 to 46 in 0052764
|
@apstndb That's updated. Thank you! |
c3a4be2
to
0030d18
Compare
- Add `ast-gen-walk` - Remove `ColumnDefOptions` and `VectorIndexOption` because they are unused.
Co-authored-by: apstndb <[email protected]>
bf134ab
to
7dfb697
Compare
Close #218
ast-gen-walk
ColumnDefOptions
andVectorIndexOption
because they are unused.