Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pos/end with new pos/end test #264

Closed
wants to merge 14 commits into from
Closed

Fix pos/end with new pos/end test #264

wants to merge 14 commits into from

Conversation

apstndb
Copy link
Contributor

@apstndb apstndb commented Jan 10, 2025 •
edited
Loading

This PR adds walk based pos/end test and fixes many pos/end bugs.

  • BinaryExpr.end
  • Join.end
  • Selector.end
  • AlterDatabase.end
  • CreateTable.end
  • ChangeStreamForAll.end, ChangeStreamForTable.end
  • TableConstraint.pos

Note

@apstndb apstndb marked this pull request as ready for review January 10, 2025 13:54
@apstndb apstndb changed the title Fix BinaryExpr.end Fix pos/end with new pos/end test Jan 10, 2025
@makenowjust makenowjust mentioned this pull request Jan 11, 2025
Merged
@apstndb
Copy link
Contributor Author

apstndb commented Jan 18, 2025

@apstndb apstndb closed this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@apstndb