Paging after filtering with the ClientSideFilter will reset the whole collection

[wyuenho]

Steps to reproduce:

1. Filter for something with more than 1 page of results
2. Page to next page
3. Clear the filter

The whole collection is now the last filtered results. The expected result should be the original result set.

[carlygeehr]

First of all, thank you for this awesome grid!

Was just wondering when you think you'll have a fix for this issue - or if you have any ideas for workarounds in the meantime. I've been trying to figure something out but don't really want to sink any more time into it. I'd be ok (for now) with just displaying an error when it gets into an error state.

This error is also happening for me with sorting:

1. apply a filter to the grid
2. sort a column
3. remove the filter
   result: collection is stuck in the filtered state

Again, thank you so much!!

[wyuenho]

Ah I had a really busy week, but expect this to be fixed this weekend!

[carlygeehr]

Awesome! Looking forward to it :)

[wyuenho]

https://github.com/wyuenho/backgrid/tree/filter-paginator-fix

Everything should work as expected. There are some changes to Paginator#controls (changed format from fastForwardHandlerLabels), All the filter types will now accept the pageable collection directly without giving it collection.fullCollection. The client filters won't listen to change events from the search box anymore and the keyup event is changed to keydown.

Let me know if it doesn't work for any reason. I'll finish up the tests in a little bit.

[carlygeehr]

Looks like the paging after filtering issue is fixed in the new branch, but the (related) filter > sort > remove filter issue is still a problem. @wyuenho - Would you like that to be in a separate issue?

[carlygeehr]

It works!! Hooray :)