Skip to content
This repository has been archived by the owner on Apr 2, 2019. It is now read-only.

First click on cell after filtering fails #190

Closed
rabbitfufu opened this issue May 16, 2013 · 2 comments
Closed

First click on cell after filtering fails #190

rabbitfufu opened this issue May 16, 2013 · 2 comments
Labels

Comments

@rabbitfufu
Copy link

I am using Backgrid with the filtering extension.

When the Backgrid first loads, I can click on a table cell to edit it. This works as expected.

However if I filter the Backgrid to narrow my results, the first time I click on a table cell to edit it, the edit cell briefly appears, then disappears. The second time I click on it, and every time thereafter, it works as expected. (This is on Chrome OSX -- I have not tested other browsers.)

You can see this behaviour on example #2 of the main Backgrid page.

Thanks again for this great tool!

@wyuenho
Copy link
Contributor

wyuenho commented May 16, 2013

Confirmed. This might have something to do with how the cell is handling the blur event now. If you first filter, and then click somewhere else to lose focus on the filter, and then click on the cell to trigger edit mode, the problem went away.

@wyuenho
Copy link
Contributor

wyuenho commented Jun 5, 2013

https://github.com/wyuenho/backgrid/tree/filter-paginator-fix

Everything should work as expected. There are some changes to Paginator#controls (changed format from fastForwardHandlerLabels), All the filter types will now accept the pageable collection directly without giving it collection.fullCollection. The client filters won't listen to change events from the search box anymore and the keyup event is changed to keydown.

Let me know if it doesn't work for any reason. I'll finish up the tests in a little bit.

wyuenho added a commit that referenced this issue Jun 9, 2013
@wyuenho wyuenho closed this as completed Jun 9, 2013
wyuenho added a commit that referenced this issue Jun 22, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants