Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert reverts of types parameter names (#165) and types npm release (#183) #220

Merged
merged 2 commits into from
Jan 16, 2023
Merged

Revert reverts of types parameter names (#165) and types npm release (#183) #220

merged 2 commits into from
Jan 16, 2023

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Dec 12, 2022 •
edited
Loading

This reverts the reverts of #165 and #183, now that we've fixed the internal build. The changes here in workerd are unchanged from #165 and #183.

@mrbbot mrbbot requested a review from jasnell December 12, 2022 15:20
@mrbbot mrbbot force-pushed the bcoll/types-parameter-names-redo branch from dc81370 to 6dc2e9d Compare December 14, 2022 16:24
@mrbbot mrbbot changed the title Types: Pull parameter names from header files Revert reverts of types parameter names (#165) and types npm release (#183) Dec 19, 2022
@mrbbot mrbbot force-pushed the bcoll/types-parameter-names-redo branch from 6dc2e9d to abae70d Compare December 19, 2022 12:52
@mrbbot mrbbot force-pushed the bcoll/types-parameter-names-redo branch from abae70d to 0254fa8 Compare January 5, 2023 10:32
dom96
dom96 approved these changes Jan 12, 2023
View reviewed changes
Copy link
Collaborator

@dom96 dom96 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is just a revert of a revert and the issue that caused the original revert is resolved I am going to approve this. Let's get the conflicts resolved and merge this :)

penalosa and others added 2 commits January 16, 2023 09:13
@penalosa @caass @mrbbot
Types: Pull parameter names from header files (#165)
cbba01e 
Co-authored-by: Somhairle MacLeòid <[email protected]>
Co-authored-by: Somhairle MacLeòid <[email protected]>
Co-authored-by: Cass Fridkin <[email protected]>
Co-authored-by: Cass Fridkin <[email protected]>
@penalosa @mrbbot
workers types npm release (#183)
030f284
@mrbbot mrbbot force-pushed the bcoll/types-parameter-names-redo branch from 0254fa8 to 030f284 Compare January 16, 2023 09:18
@dom96 dom96 merged commit 9408360 into main Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dom96 dom96 dom96 approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrbbot @dom96 @penalosa