Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workers types npm release #183

Merged
merged 10 commits into from
Dec 1, 2022
Merged

workers types npm release #183

merged 10 commits into from
Dec 1, 2022

Conversation

penalosa
Copy link
Collaborator

No description provided.

@penalosa penalosa requested a review from mrbbot November 21, 2022 11:51
@mrbbot mrbbot mentioned this pull request Nov 21, 2022
Merged
mrbbot
mrbbot approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Super-tiny nitpick, but other than that, looks great! ✅

npm/scripts/build-types-package.mjs Outdated Show resolved Hide resolved
@penalosa penalosa force-pushed the penalosa/npm-release-improvements branch 2 times, most recently from 3e32bd1 to 5c8384e Compare November 21, 2022 12:45
@penalosa penalosa force-pushed the penalosa/workers-types-npm-release branch 2 times, most recently from 6bf3b0e to 1471cce Compare November 21, 2022 12:55
@penalosa penalosa force-pushed the penalosa/workers-types-npm-release branch from 1471cce to 39b2ffe Compare November 21, 2022 13:24
@jasnell
Copy link
Member

jasnell commented Nov 29, 2022

@penalosa ... Looks like there's a test failure here that needs investigating.

Base automatically changed from penalosa/npm-release-improvements to main November 30, 2022 12:14
@jasnell jasnell merged commit 0037210 into main Dec 1, 2022
@jasnell jasnell deleted the penalosa/workers-types-npm-release branch December 1, 2022 18:01
jasnell added a commit that referenced this pull request Dec 3, 2022
@jasnell
Revert "workers types npm release (#183)"
a1530bc 
This reverts commit 0037210.
mrbbot pushed a commit that referenced this pull request Dec 14, 2022
@penalosa @mrbbot
workers types npm release (#183)
6dc2e9d
@mrbbot mrbbot mentioned this pull request Dec 14, 2022
Merged
mrbbot pushed a commit that referenced this pull request Jan 5, 2023
@penalosa @mrbbot
workers types npm release (#183)
0254fa8
mrbbot pushed a commit that referenced this pull request Jan 16, 2023
@penalosa @mrbbot
workers types npm release (#183)
030f284
dom96 pushed a commit that referenced this pull request Jan 16, 2023
@penalosa @dom96
workers types npm release (#183)
9408360
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@mrbbot mrbbot mrbbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@penalosa @jasnell @mrbbot