-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation cleanup #169
Deprecation cleanup #169
Conversation
@brorbw, please feel free to merge if you're happy 🙇♂️ |
I would have appreciated a longer notice period 🙂 Do you have some lower minimum for the notice period on breaking changes to the API (extraordinary circumstances aside)? |
Anything in particular? Regarding the separate items:
|
The
Does "deprecated" equals "will be removed"? In that case, do you have a timeline (at least a minimum) for when "deprecated" features are removed? |
It means that it'll go, eventually, yes. Not in general, as it depends on the situation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some suggestions but I'm also ok with the current state of the PR 👍
An extra suggestion:
In website/content/gateway/api_reference/transaction_status/merchant_blocked_by_cardholder_status.md
:
Perhaps change "recurring transactions" to "transactions in series" or "subsequent-in-series transactions"?
website/content/gateway/api_reference/resources/authorizations/authorizations_methods/card.md
Outdated
Show resolved
Hide resolved
Mostly formatting. Co-authored-by: Martin Toft Bay <[email protected]>
I forgot about #169 (review) 🤦♂️ I'll fix it in another PR. |
Well, after going down a historic 🐰🕳️ (#71 among others) I've ended up concluding that I'll leave it as is. My reasoning: The first sentence still holds; it's for MITs, there's no adjustment for non-series MITs. Thus, we could state that it includes all subsequent-in-series transactions, but I guess the point is to explain stuff as simple and "exemplified" as possible, and for that, recurring — being the canonical type of series — is the obvious example to use. @mt-clearhaus, please do shout enough if you disagree enough 😄 |
I don't disagree at all 🙂 👍 |
Remove parameters and values that have been deprecated long enough.