Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation cleanup #169

Merged
merged 8 commits into from
Apr 13, 2023
Merged

Deprecation cleanup #169

merged 8 commits into from
Apr 13, 2023

Conversation

ct-clearhaus
Copy link
Member

Remove parameters and values that have been deprecated long enough.

@ct-clearhaus ct-clearhaus requested a review from brorbw April 3, 2023 12:46
@ct-clearhaus
Copy link
Member Author

@brorbw, please feel free to merge if you're happy 🙇‍♂️

@tjconcept
Copy link
Contributor

I would have appreciated a longer notice period 🙂

Do you have some lower minimum for the notice period on breaking changes to the API (extraordinary circumstances aside)?

@ct-clearhaus
Copy link
Member Author

I would have appreciated a longer notice period 🙂

Anything in particular?

Regarding the separate items:

  • recurring boolean: The replacement series[] was announced in the 2021Q3 partner bulletin along with Introduce credential, initiator and series[] #111 (merged 2021-01-15) which explicitly deprecated it. I think +2 years of response time is pretty decent.
  • 3DSv1: Announced in the 2022Q3 and 2023Q1 partner bulletins along with Deprecate 3DSv1 #154 from October 2022. We've confirmed that there's basically no use, so this shouldn't pose a problem.

@tjconcept
Copy link
Contributor

Anything in particular?

The recurring flag.

I think +2 years of response time is pretty decent.

Does "deprecated" equals "will be removed"? In that case, do you have a timeline (at least a minimum) for when "deprecated" features are removed?

@ct-clearhaus
Copy link
Member Author

Does "deprecated" equals "will be removed"? In that case, do you have a timeline (at least a minimum) for when "deprecated" features are removed?

It means that it'll go, eventually, yes. Not in general, as it depends on the situation.
We definitely should inform well in advance and allow you to prepare and adopt changes in a stable and non-urgent manner so rollouts can be of high quality! Please reach out to your partner manager if you have any concerns regarding lack of information 🙇‍♂️

Copy link
Contributor

@mt-clearhaus mt-clearhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions but I'm also ok with the current state of the PR 👍

An extra suggestion:

In website/content/gateway/api_reference/transaction_status/merchant_blocked_by_cardholder_status.md:

Screenshot from 2023-04-13 09-34-22

Perhaps change "recurring transactions" to "transactions in series" or "subsequent-in-series transactions"?

@ct-clearhaus ct-clearhaus merged commit a93ddde into master Apr 13, 2023
@ct-clearhaus ct-clearhaus deleted the deprecation-cleanup branch April 13, 2023 13:30
@ct-clearhaus
Copy link
Member Author

I forgot about #169 (review) 🤦‍♂️ I'll fix it in another PR.

@ct-clearhaus
Copy link
Member Author

I forgot about #169 (review) 🤦‍♂️ I'll fix it in another PR.

Well, after going down a historic 🐰🕳️ (#71 among others) I've ended up concluding that I'll leave it as is. My reasoning: The first sentence still holds; it's for MITs, there's no adjustment for non-series MITs. Thus, we could state that it includes all subsequent-in-series transactions, but I guess the point is to explain stuff as simple and "exemplified" as possible, and for that, recurring — being the canonical type of series — is the obvious example to use.

@mt-clearhaus, please do shout enough if you disagree enough 😄

@mt-clearhaus
Copy link
Contributor

I don't disagree at all 🙂 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants