Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce credential, initiator and series[] #111

Merged
merged 37 commits into from
Jan 15, 2021
Merged

Introduce credential, initiator and series[] #111

merged 37 commits into from
Jan 15, 2021

Conversation

ct-clearhaus
Copy link
Member

@ct-clearhaus ct-clearhaus commented Sep 29, 2020 •
edited
Loading

  • credential to indicate if stored credential is being stored or used (or
    irrelevant, by leaving it out)
  • initiator to indicate what party initiate the authorization
  • series[] to replace recurring but also extend with UCOF and
    Clearhaus-internal and raw transaction reference to the previous-in-series

This PR supersedes:

To do

  • Clean-up other explanations
  • Reference partner guideline, and potentially move some text over there

@ct-clearhaus ct-clearhaus marked this pull request as draft September 29, 2020 11:38
mt-clearhaus
mt-clearhaus reviewed Sep 29, 2020
View reviewed changes
Copy link
Contributor

@mt-clearhaus mt-clearhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some comments, however, nice work 👍

ct-clearhaus
ct-clearhaus commented Sep 30, 2020
View reviewed changes
Copy link
Member Author

@ct-clearhaus ct-clearhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the early 👀!

@ct-clearhaus @mt-clearhaus
Fix wording
03079a2 
Courtesy @mt-clearhaus

Co-authored-by: Martin Toft Bay <[email protected]>
ct-clearhaus
ct-clearhaus commented Sep 30, 2020
View reviewed changes
mt-clearhaus
mt-clearhaus reviewed Sep 30, 2020
View reviewed changes
mt-clearhaus
mt-clearhaus reviewed Sep 30, 2020
View reviewed changes
ct-clearhaus
ct-clearhaus commented Sep 30, 2020
View reviewed changes
ct-clearhaus and others added 3 commits September 30, 2020 13:55
@ct-clearhaus @mt-clearhaus
Improve wording
f79aad6 
Courtesy @mt-clearhaus

Co-authored-by: Martin Toft Bay <[email protected]>
@ct-clearhaus @mt-clearhaus
Consistent regexps
2263364 
Courtesy @mt-clearhaus

Co-authored-by: Martin Toft Bay <[email protected]>
@mt-clearhaus @ct-clearhaus
Update source/index.html.md
ea7ae3c 
Co-authored-by: Casper Thomsen <[email protected]>
mt-clearhaus
mt-clearhaus reviewed Sep 30, 2020
View reviewed changes
@ct-clearhaus
Remove varying amount series explanation
8415d33 
The topic is now explained in detail in the partner guideline.
ct-clearhaus
ct-clearhaus commented Nov 16, 2020
View reviewed changes
ct-clearhaus
ct-clearhaus commented Nov 16, 2020
View reviewed changes
mt-clearhaus
mt-clearhaus reviewed Nov 16, 2020
View reviewed changes
mt-clearhaus
mt-clearhaus reviewed Nov 16, 2020
View reviewed changes
mt-clearhaus
mt-clearhaus reviewed Nov 27, 2020
View reviewed changes
Copy link
Contributor

@mt-clearhaus mt-clearhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some suggestions, comments and questions 🙂

ct-clearhaus and others added 2 commits November 30, 2020 17:12
@ct-clearhaus @mt-clearhaus
Improve wording many places
3c80125 
Courtesy of @mt-clearhaus

Co-authored-by: Martin Toft Bay <[email protected]>
@ct-clearhaus
Improve wording
c51b88d 
Courtesy of @mt-clearhaus.
mt-clearhaus
mt-clearhaus reviewed Dec 4, 2020
View reviewed changes
mt-clearhaus
mt-clearhaus reviewed Dec 10, 2020
View reviewed changes
mt-clearhaus
mt-clearhaus reviewed Dec 10, 2020
View reviewed changes
This was referenced Jan 15, 2021
Closed
Closed
Closed
Closed
ad-clearhaus
ad-clearhaus reviewed Jan 15, 2021
View reviewed changes
@ct-clearhaus @ad-clearhaus
Improve wording
0c5db62 
Co-authored-by: ad-clearhaus <[email protected]>
ad-clearhaus
ad-clearhaus approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@ad-clearhaus ad-clearhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@ct-clearhaus ct-clearhaus merged commit d9fd689 into master Jan 15, 2021
@ct-clearhaus ct-clearhaus deleted the cof-d branch January 15, 2021 14:20
tjconcept
tjconcept reviewed Jan 19, 2021
View reviewed changes
Copy link
Contributor

@tjconcept tjconcept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late comments. The many past diverging PRs scared me off.

ct-clearhaus added a commit that referenced this pull request Jan 20, 2021
@ct-clearhaus
Clarify SCA requirements
238979f 
Courtesy of @tjconcept
  #111 (comment)
@ct-clearhaus ct-clearhaus mentioned this pull request Jan 20, 2021
Open
@ct-clearhaus ct-clearhaus mentioned this pull request Jun 2, 2021
Merged
1 task
@ct-clearhaus ct-clearhaus mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjconcept tjconcept tjconcept left review comments

@mt-clearhaus mt-clearhaus mt-clearhaus left review comments

@AlexanderIversen AlexanderIversen AlexanderIversen left review comments

@ad-clearhaus ad-clearhaus ad-clearhaus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ct-clearhaus @tjconcept @mt-clearhaus @ad-clearhaus @AlexanderIversen