Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vks custom error #646

Merged
merged 5 commits into from
Sep 5, 2016
Merged

Vks custom error #646

merged 5 commits into from
Sep 5, 2016

Conversation

kbknapp
Copy link
Member

@kbknapp kbknapp commented Sep 5, 2016

No description provided.

This is useful if a more meaningful message can be displayed to the
user with `Error::exit`. For example, if a file is not found, the
converted `io::Error` will give a message like:

    "error: entity not found"

With this, it is possible to replace this message with a more useful
one, like for instance:

    "error: configuration file not found"

Coloring is respected. Some duplication in the `From::from` impls was
reduced.
@yo-bot
Copy link

yo-bot commented Sep 5, 2016

r? @Vinatorul

(yo-bot has picked a reviewer for you, use r? to override)

@kbknapp
Copy link
Member Author

kbknapp commented Sep 5, 2016

@homu r+

@homu
Copy link
Contributor

homu commented Sep 5, 2016

📌 Commit 07e6e8e has been approved by kbknapp

homu added a commit that referenced this pull request Sep 5, 2016
homu added a commit that referenced this pull request Sep 5, 2016
@homu
Copy link
Contributor

homu commented Sep 5, 2016

⌛ Testing commit 07e6e8e with merge 48bc038...

@homu
Copy link
Contributor

homu commented Sep 5, 2016

☀️ Test successful - status

@homu homu merged commit 07e6e8e into master Sep 5, 2016
@homu homu mentioned this pull request Sep 5, 2016
@kbknapp kbknapp deleted the vks-custom-error branch September 5, 2016 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants