Make it possible to construct errors with custom description #641
Conversation
|
Thanks for the pull request, and welcome! The team is excited to review your changes, and you should hear from @sru (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Please see the contribution instructions for more information. More specifically, can you change the commit message to follow the format on the link above? @kbknapp The link in the automatic bot message is pointing to |
Sure, I'll rebase after review. |
This is useful if a more meaningful message can be displayed to the
user with `Error::exit`. For example, if a file is not found, the
converted `io::Error` will give a message like:
"error: entity not found"
With this, it is possible to replace this message with a more useful
one, like for instance:
"error: configuration file not found"
Coloring is respected. Some duplication in the `From::from` impls was
reduced.
|
Rebased with a reformatted commit message and slightly extended documentation. |
|
Rebased and updated term_size dep in #646 |
This is useful if a more meaningful message can be displayed to the
user with
Error::exit. For example, if a file is not found, theconverted
io::Errorwill give a message like:With this, it is possible to replace this message with a more useful
one, like for instance:
Coloring is respected. Some duplication in the
From::fromimpls wasreduced.