Copy comments markers only when a full marker is selected #15968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mati365
force-pushed
the
ck/6053
branch
2 times, most recently
from
895d8bf to
a8cdd2a
Compare
Mati365
requested review from
DawidKossowski and
scofalik
and removed request for
scofalik and
DawidKossowski
Mati365
requested review from
DawidKossowski and
scofalik
and removed request for
DawidKossowski
DawidKossowski
requested changes
Mar 7, 2024
…tend configuration
DawidKossowski
requested changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (clipboard): By default, do not copy markers if they are partially selected. Fixes https://github.com/cksource/ckeditor5-commercial/issues/6053.
Tests (clipboard): Add missing tests for pasting duplicated markers in table plugin. Closes https://github.com/cksource/ckeditor5-commercial/issues/6056.
Internal (clipboard): Add
duplicateOnPasteto marker clipboard configuration. Closes #15966 . Related to #15968 .