Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not paste the marker when it exists in the document #15966

Closed
DawidKossowski opened this issue Mar 4, 2024 · 0 comments · Fixed by #16005
Closed

Do not paste the marker when it exists in the document #15966

DawidKossowski opened this issue Mar 4, 2024 · 0 comments · Fixed by #16005
Assignees
Labels
package:clipboard squad:collaboration Issue to be handled by the Collaboration team. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@DawidKossowski
Copy link
Contributor

📝 Provide a description of the improvement

Currently, we paste the markers even if they already exist in the content. This might not make sense for most features, such as comments. Therefore, we should not duplicate the markers after pasting. However, it is still necessary to keep them in the clipboard, since someone might remove them from the content, and after pasting, we should still display them.

📃 Other details

For now, this behavior could be global. However, it will be automatically resolved if we change how we handle unique marker names.


If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@DawidKossowski DawidKossowski added type:improvement This issue reports a possible enhancement of an existing feature. package:clipboard squad:collaboration Issue to be handled by the Collaboration team. labels Mar 4, 2024
DawidKossowski pushed a commit that referenced this issue Mar 25, 2024
Other (clipboard): By default, markers will not be copied if they are only partially selected.
Internal (clipboard): Introduced `duplicateOnPaste` and `copyPartiallySelected` options to the marker clipboard configuration. Closes #15966.
Fix (engine): Copying the content with markers will no longer trigger the `change:data` event. Closes #15943.
Tests (clipboard): Added missing tests for pasting duplicated markers in the table package.
@CKEditorBot CKEditorBot added this to the iteration 73 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:clipboard squad:collaboration Issue to be handled by the Collaboration team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
3 participants