Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The list style UI should call only the listStyle command #11171

Merged
merged 3 commits into from
Feb 2, 2022
Merged

The list style UI should call only the listStyle command #11171

merged 3 commits into from
Feb 2, 2022

Conversation

arkflpc
Copy link
Contributor

@arkflpc arkflpc commented Jan 27, 2022

Suggested merge commit message (convention)

Internal (list): Makes ListPropertiesUI not to call ListCommand and ListStyleCommand in one go. Closes #11164.

Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@maxbarnas maxbarnas self-requested a review February 2, 2022 09:21
maxbarnas
maxbarnas approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@maxbarnas maxbarnas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested changing/adding two comments to make the code slightly more clear for the next guy. Feel free to apply/modify them. Otherwise everything is great :)

packages/ckeditor5-list/src/listpropertiesui.js Outdated Show resolved Hide resolved
packages/ckeditor5-list/src/liststylecommand.js Show resolved Hide resolved
@maxbarnas maxbarnas merged commit 2c98540 into master Feb 2, 2022
@maxbarnas maxbarnas deleted the ck/11164 branch February 2, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxbarnas maxbarnas maxbarnas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Document lists] The list style UI should call only the listStyle command
2 participants
@arkflpc @maxbarnas