Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Document lists] The list style UI should call only the listStyle command #11164

Closed
Reinmar opened this issue Jan 26, 2022 · 0 comments · Fixed by #11171
Closed

[Document lists] The list style UI should call only the listStyle command #11164

Reinmar opened this issue Jan 26, 2022 · 0 comments · Fixed by #11171
Assignees
@arkflpc
Labels
package:list squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 52 (v34...

Comments

@Reinmar
Copy link
Member

Reinmar commented Jan 26, 2022

Currently it calls two commands:

ckeditor5/packages/ckeditor5-list/src/listpropertiesui.js

Lines 234 to 235 in aca6ab6

editor.execute( parentCommandName );
editor.execute( 'listStyle', { type } );

This makes little sense. E.g. in case of integration with TC, there will be two suggestions that could be accepted independently.

Try moving the first line into the ListStyleCommand#execute().

The idea is that moving that line there should not affect the UX (what the user will get). The goal is to clean up this situation before we implement list properties for #2973.
@Reinmar Reinmar added type:task This issue reports a chore (non-production change) and other types of "todos". squad:core Issue to be handled by the Core team. labels Jan 26, 2022
@arkflpc arkflpc mentioned this issue Jan 27, 2022
Merged
@Reinmar Reinmar changed the title The list style UI should call only the listStyle command [Document lists] The list style UI should call only the listStyle command Jan 28, 2022
maxbarnas pushed a commit that referenced this issue Feb 2, 2022
Merge pull request #11171 from ckeditor/ck/11164
2c98540 
Internal (list): Makes `ListPropertiesUI` not to call `ListCommand` and `ListStyleCommand` in one go. Closes #11164.
@AnnaTomanek AnnaTomanek added this to the iteration 51 milestone Feb 3, 2022
@Reinmar Reinmar modified the milestones: iteration 51, upcoming Feb 28, 2022
@CKEditorBot CKEditorBot modified the milestones: upcoming, iteration 52 Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arkflpc arkflpc

Labels
package:list squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 52 (v34.0.0)
Development

Successfully merging a pull request may close this issue.

The list style UI should call only the listStyle command ckeditor/ckeditor5
4 participants
@Reinmar @AnnaTomanek @arkflpc @CKEditorBot