Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste from word / List - List not pasting #9055

Closed
pierrickdanno opened this issue Feb 19, 2021 · 3 comments Β· Fixed by #10084
Closed

Paste from word / List - List not pasting #9055

pierrickdanno opened this issue Feb 19, 2021 · 3 comments Β· Fixed by #10084
Assignees
Labels
package:paste-from-office squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@pierrickdanno
Copy link

Hey,

πŸ“ Provide detailed reproduction steps (if any)

Here is a very basic list in a word document. Pasting it in the editor is impossible.
The file : List issue.docx

Screenshot of its content :
Screenshot 2021-02-19 at 19 53 47

❌ Actual result

It's not pasting in my app, but it looks like it's not pasting in the demo editor in the "Paste from Word" documentation either. Same error I believe.

Screenshot from the Paste from word documention :
Screenshot 2021-02-19 at 20 02 51

Screenshot from my app :
Screenshot 2021-02-19 at 20 07 02


If you'd like to see this fixed sooner, add a πŸ‘ reaction to this post.

@pierrickdanno pierrickdanno added the type:bug This issue reports a buggy (incorrect) behavior. label Feb 19, 2021
@FilipTokarski
Copy link
Member

FilipTokarski commented Feb 22, 2021

Hi, thanks for the report. It's very strange because I can reproduce this only with the file you linked. If I create my own list there is no way to trigger the error.

Stack trace from demo:

ckeditorerror.js:64 Uncaught TypeError: Cannot read property 'is' of undefined
    at list.js:236
    at list.js:203
    at list.js:184
    at list.js:50
    at Array.forEach (<anonymous>)
    at Rb (list.js:39)
    at $b.execute (mswordnormalizer.js:49)
    at Gd.t.plugins.get.on.priority (pastefromoffice.js:68)
    at Gd.fire (emittermixin.js:221)
    at sn.listenTo.priority (clipboard.js:79)

@FilipTokarski FilipTokarski added package:paste-from-office squad:core Issue to be handled by the Core team. labels Feb 22, 2021
@pierrickdanno
Copy link
Author

I found an other occurence of the same bug.
List bug.docx

Different document, from a different client of mine. I changed the content (confidential) and deleted all the part that are pasting correctly.

It looks like the bug comme from the first item of the list or the list itself.

@pomek
Copy link
Member

pomek commented Jul 7, 2021

Internal note: I removed the estimate in favor of #9954.

jacekbogdanski added a commit that referenced this issue Jul 7, 2021
Fix (paste-from-office): Fixed a crash when pasting lists from Word to the editor. Closes #9055. Closes #9954.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:paste-from-office squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants