Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button separators should follow every button in the responsive form #8296

Closed
oleq opened this issue Oct 20, 2020 · 1 comment Β· Fixed by #8298
Closed

Button separators should follow every button in the responsive form #8296

oleq opened this issue Oct 20, 2020 · 1 comment Β· Fixed by #8298
Assignees
Labels
domain:ui/ux This issue reports a problem related to UI or UX. squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@oleq
Copy link
Member

oleq commented Oct 20, 2020

Follow-up of #7704.

πŸ“ Provide detailed reproduction steps (if any)

  1. http://fake.ckeditor.com:8125/ckeditor5/tests/manual/all-features.html
  2. Create a link.

βœ”οΈ Expected result

The separator should only be displayed after the save button.

❌ Actual result

This especially becomes a problem when the form gets some padding:

πŸ“ƒ Other details

  • OS: master

If you'd like to see this fixed sooner, add a πŸ‘ reaction to this post.

@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. domain:ui/ux This issue reports a problem related to UI or UX. squad:core Issue to be handled by the Core team. labels Oct 20, 2020
@oleq oleq added this to the iteration 37 milestone Oct 20, 2020
@oleq oleq assigned pkwasnik and oleq and unassigned pkwasnik and oleq Oct 20, 2020
@oleq
Copy link
Member Author

oleq commented Oct 20, 2020

Changes required:

diff --git a/packages/ckeditor5-theme-lark/theme/ckeditor5-ui/components/responsive-form/responsiveform.css b/packages/ckeditor5-theme-lark/theme/ckeditor5-ui/components/responsive-form/responsiveform.css
index 6c93c08802..c4250b0ee9 100644
--- a/packages/ckeditor5-theme-lark/theme/ckeditor5-ui/components/responsive-form/responsiveform.css
+++ b/packages/ckeditor5-theme-lark/theme/ckeditor5-ui/components/responsive-form/responsiveform.css
@@ -6,7 +6,7 @@
 @import "@ckeditor/ckeditor5-ui/theme/mixins/_rwd.css";
 @import "@ckeditor/ckeditor5-ui/theme/mixins/_dir.css";

-.ck-vertical-form .ck-button::after {
+.ck-vertical-form > .ck-button:nth-last-child(2)::after {
          border-right: 1px solid var(--ck-color-base-border);
 }

@@ -48,10 +48,11 @@
                            }
                   }

-                  /* 'button' selector must be used because those styles shouldn't be added to other elements, like 'a'. Example in LinkActionsView. */
-                  & button.ck-button {
+                  /* Styles for two last buttons in the form (save&cancel, edit&unlink, etc.). */
+                  & > .ck-button:nth-last-child(1),
+                  & > .ck-button:nth-last-child(2) {
                            padding: var(--ck-spacing-standard);
                            border-radius: 0;
                            border: 0;

jodator added a commit that referenced this issue Oct 21, 2020
Internal (theme-lark): Fixed button separators in the link UI. Closes #8296.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants